udev: replace UDEV_ALL_EXTRAS with more fine-grained options
PATCH 1/2 udev: replace UDEV_ALL_EXTRAS with more fine-grained options
Replace the BR2_PACKAGE_UDEV_ALL_EXTRAS options with a bunch of configuration choices that allow more fine-grainded control over the features that should be built into udev.
--- package/udev/Config.in | 39 ++++++++++++++++++++++++++++++--------- package/udev/udev.mk | 41 ++++++++++++++++++++++++++++++----------- 2 files changed, 60 insertions(+), 20 deletions(-)
package/udev/Config.in +30 -9
@@ -15,20 +15,41 @@ config BR2_PACKAGE_UDEV if BR2_PACKAGE_UDEV +config BR2_PACKAGE_UDEV_ACL + bool "enable acl permissions" + help + Enable enable local user acl permissions support + +config BR2_PACKAGE_UDEV_GUDEV + bool "enable GObject libudev support" + help + Enable GObject libudev support + +config BR2_PACKAGE_UDEV_HWDATA + bool "enable hardware data" + help + Enable hardware identification and configuration data + +config BR2_PACKAGE_UDEV_INTROSPECTION + bool "enable GObject introspection" + help + Enable GObject introspection support + +config BR2_PACKAGE_UDEV_KEYMAP + bool "enable keymap fixup" + help + Enable keymap fixup support + +config BR2_PACKAGE_UDEV_MTD + bool "enable MTD support" + help + Enable MTD probe support + config BR2_PACKAGE_UDEV_RULES_GEN bool "enable rules generator" help Enable persistant rules generator -config BR2_PACKAGE_UDEV_ALL_EXTRAS - bool "enable all extras" - select BR2_PACKAGE_ACL - select BR2_PACKAGE_HWDATA - select BR2_PACKAGE_LIBGLIB2 - help - Enable all extras with external dependencies like - libacl, hwdata and libglib2 - endif comment "udev requires /dev mgmnt set to udev under System configuration"
package/udev/udev.mk +30 -11
54 lines not on this page · raw message
Signature · 1 line
1.7.9.5
PATCH 2/2 network-manager: follow udev changes
NetworkManager needs to select BR2_PACKAGE_UDEV_GUDEV.
--- package/network-manager/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/network-manager/Config.in +1 -1
@@ -7,7 +7,7 @@ config BR2_PACKAGE_NETWORK_MANAGER depends on BR2_USE_WCHAR # libglib2 select BR2_PACKAGE_DBUS_GLIB select BR2_PACKAGE_UDEV - select BR2_PACKAGE_UDEV_ALL_EXTRAS + select BR2_PACKAGE_UDEV_GUDEV select BR2_PACKAGE_GNUTLS select BR2_PACKAGE_LIBNL select BR2_PACKAGE_UTIL_LINUX
Signature · 1 line
1.7.9.5
PATCH 2/2 network-manager: follow udev changes
Quoted 3 lines · On Tuesday 17 April 2012 12:19:13 Sven Neumann wrote:
NetworkManager needs to select
BR2_PACKAGE_UDEV_GUDEV.Signed-off-by Sven Neumann <[email protected]>
I would include this one in the previous patch, otherwise the previous
patch breaks the build.
Regards,
Arnout
Quoted 18 lines
--- package/network-manager/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)package/network-manager/Config.in +1
-1@@ -7,7 +7,7 @@ config BR2_PACKAGE_NETWORK_MANAGER depends on BR2_USE_WCHAR # libglib2 select BR2_PACKAGE_DBUS_GLIB select BR2_PACKAGE_UDEV - select BR2_PACKAGE_UDEV_ALL_EXTRAS + select BR2_PACKAGE_UDEV_GUDEV select BR2_PACKAGE_GNUTLS select BR2_PACKAGE_LIBNL select BR2_PACKAGE_UTIL_LINUX
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286540 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 1/2 udev: replace UDEV_ALL_EXTRAS with more fine-grained options
In reply to Sven NeumannQuoted 2 lines · On Tuesday 17 April 2012 12:19:12 Sven Neumann wrote:
Replace the
BR2_PACKAGE_UDEV_ALL_EXTRASoptions with a bunch of configuration choices that allow more fine-grainded control over
^ Spelling
Quoted 13 lines
the features that should be built into udev.
Signed-off-by Sven Neumann <[email protected]>--- package/udev/Config.in | 39 ++++++++++++++++++++++++++++++--------- package/udev/udev.mk | 41 ++++++++++++++++++++++++++++++----------- 2 files changed, 60 insertions(+), 20 deletions(-)package/udev/Config.in +0
-0
package/udev/Config.in config BR2_PACKAGE_UDEV · line 19
Quoted 5 lines
package/udev/Config.in +2
-0@@ -15,20 +15,41 @@ config BR2_PACKAGE_UDEV if BR2_PACKAGE_UDEV +config BR2_PACKAGE_UDEV_ACL + bool "enable acl permissions"
select BR2_PACKAGE_ACL
package/udev/Config.in config BR2_PACKAGE_UDEV · line 24
Quoted 5 lines
package/udev/Config.in +5
-0+ help + Enable enable local user acl permissions support + +config BR2_PACKAGE_UDEV_GUDEV + bool "enable GObject libudev support"
select BR2_PACKAGE_LIBGLIB2
package/udev/Config.in config BR2_PACKAGE_UDEV · line 29
Quoted 5 lines
package/udev/Config.in +5
-0+ help + Enable GObject libudev support + +config BR2_PACKAGE_UDEV_HWDATA + bool "enable hardware data"
select BR2_PACKAGE_HWDATA
package/udev/Config.in config BR2_PACKAGE_UDEV · line 34
Quoted 5 lines
package/udev/Config.in +5
-0+ help + Enable hardware identification and configuration data + +config BR2_PACKAGE_UDEV_INTROSPECTION + bool "enable GObject introspection"
select BR2_PACKAGE_LIBGLIB2
And doesn't this depend on BR2_PACKAGE_UDEV_GUDEV?
Quoted 35 lines
package/udev/Config.in +13
-9+ help + Enable GObject introspection support + +config BR2_PACKAGE_UDEV_KEYMAP + bool "enable keymap fixup" + help + Enable keymap fixup support + +config BR2_PACKAGE_UDEV_MTD + bool "enable MTD support" + help + Enable MTD probe support + config BR2_PACKAGE_UDEV_RULES_GEN bool "enable rules generator" help Enable persistant rules generator -config BR2_PACKAGE_UDEV_ALL_EXTRAS - bool "enable all extras" - select BR2_PACKAGE_ACL - select BR2_PACKAGE_HWDATA - select BR2_PACKAGE_LIBGLIB2 - help - Enable all extras with external dependencies like - libacl, hwdata and libglib2 - endif comment "udev requires /dev mgmnt set to udev under System configuration"package/udev/udev.mk +0
-0
package/udev/udev.mk UDEV_CONF_OPT = \ · line 20
Quoted 9 lines
package/udev/udev.mk +2
-3@@ -15,24 +15,43 @@ UDEV_CONF_OPT = \ --sbindir=/sbin \ --with-rootlibdir=/lib \ --libexecdir=/lib \ - --with-usb-ids-path=/usr/share/hwdata/usb.ids \ - --with-pci-ids-path=/usr/share/hwdata/pci.ids \ --with-firmware-path=/lib/firmware \ - --disable-introspection + --with-usb-ids-path=/usr/share/hwdata/usb.ids \ + --with-pci-ids-path=/usr/share/hwdata/pci.ids
I guess this reordering of the config options is meaningless?
package/udev/udev.mk UDEV_CONF_OPT = \ · line 26
Quoted 8 lines
package/udev/udev.mk +3
-2UDEV_DEPENDENCIES = host-gperf host-pkg-config util-linux kmod -ifeq ($(BR2_PACKAGE_UDEV_RULES_GEN),y) -UDEV_CONF_OPT += --enable-rule_generator +ifeq ($(BR2_PACKAGE_UDEV_ACL),y) +UDEV_CONF_OPT += --enable-udev_acl +UDEV_DEPENDENCIES += acl
Probably cleaner to explicitly disable it in the else case.
package/udev/udev.mk UDEV_CONF_OPT = \ · line 29
Quoted 3 lines
package/udev/udev.mk +3
-0+endif + +ifeq ($(BR2_PACKAGE_UDEV_GUDEV),y)
Probably cleaner to explicitly enable it.
package/udev/udev.mk UDEV_CONF_OPT = \ · line 36
Quoted 7 lines
package/udev/udev.mk +7
-0+UDEV_DEPENDENCIES += libglib2 +else +UDEV_CONF_OPT += --disable-gudev +endif + +ifeq ($(BR2_PACKAGE_UDEV_HWDATA),y) +UDEV_DEPENDENCIES += hwdata
Is there no enable/disable option for this?
package/udev/udev.mk UDEV_CONF_OPT = \ · line 40
Quoted 8 lines
package/udev/udev.mk +2
-4endif -ifeq ($(BR2_PACKAGE_UDEV_ALL_EXTRAS),y) -UDEV_DEPENDENCIES += acl hwdata libglib2 -UDEV_CONF_OPT += \ - --enable-udev_acl +ifeq ($(BR2_PACKAGE_UDEV_INTROSPECTION),y) +UDEV_DEPENDENCIES += libglib2
Probably cleaner to explicitly enable it.
package/udev/udev.mk UDEV_CONF_OPT = \ · line 45
Quoted 7 lines
package/udev/udev.mk +4
-2else -UDEV_CONF_OPT += \ - --disable-gudev +UDEV_CONF_OPT += --disable-introspection +endif + +ifneq ($(BR2_PACKAGE_UDEV_KEYMAP),y)
Probably cleaner to explicitly enable it.
package/udev/udev.mk UDEV_CONF_OPT = \ · line 49
Quoted 4 lines
package/udev/udev.mk +4
-0+UDEV_CONF_OPT += --disable-keymap +endif + +ifneq ($(BR2_PACKAGE_UDEV_MTD),y)
Probably cleaner to explicitly enable it.
package/udev/udev.mk UDEV_CONF_OPT = \ · line 53
Quoted 4 lines
package/udev/udev.mk +4
-0+UDEV_CONF_OPT += --disable-mtd_probe +endif + +ifeq ($(BR2_PACKAGE_UDEV_RULES_GEN),y)
Probably cleaner to explicitly disable it.
package/udev/udev.mk UDEV_CONF_OPT = \
Quoted 5 lines
package/udev/udev.mk +1
-0+UDEV_CONF_OPT += --enable-rule_generator endif ifeq ($(BR2_PACKAGE_SYSTEMD),y)
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286540 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH 1/2 udev: replace UDEV_ALL_EXTRAS with more fine-grained options
In reply to Sven NeumannDear Sven Neumann,
Quoted 5 lines · Sven Neumann
Replace the
BR2_PACKAGE_UDEV_ALL_EXTRASoptions with a bunch of configuration choices that allow more fine-grainded control over the features that should be built into udev.Signed-off-by Sven Neumann <[email protected]>
This patch is rather old, and with the movement around systemd/udev, I don't think there is really too much incentive to put efforts into the legacy udev package. Therefore, I've removed this patch, as well as your PATCH 2/2 that depended on this one, from the patchwork.
If you're still interested by this feature, do not hesitate to come back with updated versions of those patches, taking into account the comments that were raised during the review.
Thanks,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com