Skip to contentSkip to conversation

Add cortex-a8 cpu spec to ffmpeg neon config.

PATCH New Danomi Manchego 2 participants 2 messages Apr 22, 2012 – Mar 24, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add cortex-a8 cpu spec to ffmpeg neon config.

Since neon support is specific to Arm Cortex-A8, and buildroot recognizes this by having a specific Cortex-A8 clause in ffmpeg.mk, let's add the --cpu needed to make the ffmpeg configuration actually report the arch as "arm (cortex-a8)", instead of just "arm (generic)".

---
 package/multimedia/ffmpeg/ffmpeg.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
package/multimedia/ffmpeg/ffmpeg.mk +1 -1
index 4cc29ee..633ec9e 100644
@@ -145,7 +145,7 @@ FFMPEG_CONF_OPT += --enable-armvfp
 endif
 # NEON is optional for A9
 ifeq ($(BR2_cortex_a8),y)
-FFMPEG_CONF_OPT += --enable-neon
+FFMPEG_CONF_OPT += --enable-neon --cpu=cortex-a8
 endif
 # Set powerpc altivec appropriately
 ifeq ($(BR2_powerpc),y)
Signature · 1 line
1.7.5.4
#1 lore raw

PATCH 1/1 Add cortex-a8 cpu spec to ffmpeg neon config.

Dear Danomi Manchego,

Quoted 15 lines · Danomi Manchego

Since neon support is specific to Arm Cortex-A8, and buildroot recognizes this by having a specific Cortex-A8 clause in ffmpeg.mk, let's add the --cpu needed to make the ffmpeg configuration actually report the arch as "arm (cortex-a8)", instead of just "arm (generic)".

---
 package/multimedia/ffmpeg/ffmpeg.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
package/multimedia/ffmpeg/ffmpeg.mk +0 -0
index 4cc29ee..633ec9e 100644

package/multimedia/ffmpeg/ffmpeg.mk FFMPEG_CONF_OPT += --enable-armvfp · line 149

Quoted 6 lines
package/multimedia/ffmpeg/ffmpeg.mk +1 -1
@@ -145,7 +145,7 @@ FFMPEG_CONF_OPT += --enable-armvfp
 endif
 # NEON is optional for A9
 ifeq ($(BR2_cortex_a8),y)
-FFMPEG_CONF_OPT += --enable-neon
+FFMPEG_CONF_OPT += --enable-neon --cpu=cortex-a8
 endif

I believe this patch is not useful, because the only effect of --cpu=<foo> options in ffmpeg configure is to add the relevant -march, -mcpu and al. gcc options. But Buildroot is already passing them: in the internal and Crosstool-NG toolchain backends, the toolchain is built to automatically generate code for the selected CPU, and for the external toolchain backend, a wrapper automatically passes -mcpu/-march/-mtune to the compiler.

Therefore, this patch is not needed IMO, and I've removed it from the patch work. If you don't agree, do not hesitate to send an updated version that includes more details as to why it is needed.

Thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com