Skip to contentSkip to conversation

firewire: sbp2: replace BUG_ON by WARN_ON

PATCH New Stefan Richter 1 participant 1 message Mar 24, 2013 Firewire

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 firewire: sbp2: replace BUG_ON by WARN_ON

No need to crash and burn if S/G element sizes cannot be set to our liking; just leave a message in the log.

---
 drivers/firewire/sbp2.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/firewire/sbp2.c +2 -2
@@ -1144,8 +1144,8 @@ static int sbp2_probe(struct device *dev
 		return -ENODEV;
 
 	if (dma_get_max_seg_size(device->card->device) > SBP2_MAX_SEG_SIZE)
-		BUG_ON(dma_set_max_seg_size(device->card->device,
-					    SBP2_MAX_SEG_SIZE));
+		WARN_ON(dma_set_max_seg_size(device->card->device,
+					     SBP2_MAX_SEG_SIZE));
 
 	shost = scsi_host_alloc(&scsi_driver_template, sizeof(*tgt));
 	if (shost == NULL)
Signature · 3 lines
Stefan Richter
-=====-===-= --== ==---
http://arcgraph.de/sr/