ARM: mach-imx: cpu: Include "common.h"
Subsystems (3)
PATCH 1/17 ARM: mach-imx: cpu: Include "common.h"
Fix the following sparse warnings:
arch/arm/mach-imx/cpu.c:10:6: warning: symbol 'mxc_set_cpu_type' was not declared. Should it be static? arch/arm/mach-imx/cpu.c:15:6: warning: symbol 'imx_print_silicon_rev' was not declared. Should it be static? arch/arm/mach-imx/cpu.c:24:13: warning: symbol 'imx_set_aips' was not declared. Should it be static?
--- arch/arm/mach-imx/cpu.c | 1 + 1 file changed, 1 insertion(+)
arch/arm/mach-imx/cpu.c +1 -0
@@ -3,6 +3,7 @@#include <linux/io.h> #include "hardware.h" +#include "common.h" unsigned int __mxc_cpu_type;EXPORT_SYMBOL (__mxc_cpu_type);
Signature · 1 line
1.7.9.5
PATCH 2/17 ARM: mach-imx: mm-imx3: Staticize imx3_init_l2x0()
Fix the following sparse warning:
arch/arm/mach-imx/mm-imx3.c:85:13: warning: symbol 'imx3_init_l2x0' was not declared. Should it be static?
--- arch/arm/mach-imx/mm-imx3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-imx/mm-imx3.c +1 -1
@@ -82,7 +82,7 @@ static void __iomem *imx3_ioremap_caller(unsigned long phys_addr, size_t size,return __arm_ioremap_caller (phys_addr, size, mtype, caller); } -void __init imx3_init_l2x0 (void ) +static void __init imx3_init_l2x0 (void ) {#ifdef CONFIG_CACHE_L2X0 void __iomem *l2x0_base;
Signature · 1 line
1.7.9.5
PATCH 3/17 ARM: mach-imx: iomux-imx31: Staticize mxc_pin_alloc_map
In reply to Fabio EstevamFix the following sparse warning:
arch/arm/mach-imx/iomux-imx31.c:43:15: warning: symbol 'mxc_pin_alloc_map' was not declared. Should it be static?
--- arch/arm/mach-imx/iomux-imx31.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-imx/iomux-imx31.c +1 -1
@@ -40,7 +40,7 @@ static DEFINE_SPINLOCK(gpio_mux_lock);#define IOMUX_REG_MASK (IOMUX_PADNUM_MASK & ~0x3) -unsigned long mxc_pin_alloc_map[NB_PORTS *32 /BITS_PER_LONG ]; +static unsigned long mxc_pin_alloc_map[NB_PORTS *32 /BITS_PER_LONG ];/* * set the mode for a IOMUX pin. */
Signature · 1 line
1.7.9.5
PATCH 4/17 ARM: mach-imx: cpu-imx5: Include "common.h"
In reply to Fabio EstevamFix the following sparse warnings:
arch/arm/mach-imx/cpu-imx5.c:65:12: warning: symbol 'mx51_neon_fixup' was not declared. Should it be static? arch/arm/mach-imx/cpu-imx5.c:99:5: warning: symbol 'mx53_revision' was not declared. Should it be static?
--- arch/arm/mach-imx/cpu-imx5.c | 1 + 1 file changed, 1 insertion(+)
arch/arm/mach-imx/cpu-imx5.c +1 -0
@@ -18,6 +18,7 @@#include <linux/io.h> #include "hardware.h" +#include "common.h" static int mx5_cpu_rev =-1 ;
Signature · 1 line
1.7.9.5
PATCH 5/17 ARM: mach-imx: cpu_op-mx51: Include "cpu_op-mx51.h"
In reply to Fabio EstevamFix the following sparse warning:
arch/arm/mach-imx/cpu_op-mx51.c:27:15: warning: symbol 'mx51_get_cpu_op' was not declared. Should it be static?
--- arch/arm/mach-imx/cpu_op-mx51.c | 1 + 1 file changed, 1 insertion(+)
arch/arm/mach-imx/cpu_op-mx51.c +1 -0
@@ -16,6 +16,7 @@#include <linux/kernel.h> #include "hardware.h" +#include "cpu_op-mx51.h" static struct cpu_op mx51_cpu_op[] = { {
Signature · 1 line
1.7.9.5
PATCH 6/17 ARM: mach-imx: clk-pllv1: Staticize clk_pllv1_ops
In reply to Fabio EstevamFix the following sparse warning:
arch/arm/mach-imx/clk-pllv1.c:81:16: warning: symbol 'clk_pllv1_ops' was not declared. Should it be static?
--- arch/arm/mach-imx/clk-pllv1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-imx/clk-pllv1.c +1 -1
@@ -78,7 +78,7 @@ static unsigned long clk_pllv1_recalc_rate(struct clk_hw *hw,return ll; } -struct clk_ops clk_pllv1_ops = { +static struct clk_ops clk_pllv1_ops = { .recalc_rate = clk_pllv1_recalc_rate, };
Signature · 1 line
1.7.9.5
PATCH 7/17 ARM: mach-imx: clk-pllv2: Staticize clk_pllv2_ops
In reply to Fabio EstevamFix the following sparse warning:
rch/arm/mach-imx/clk-pllv2.c:232:16: warning: symbol 'clk_pllv2_ops' was not declared. Should it be static?
--- arch/arm/mach-imx/clk-pllv2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-imx/clk-pllv2.c +1 -1
@@ -229,7 +229,7 @@ static void clk_pllv2_unprepare(struct clk_hw *hw)__raw_writel (reg, pllbase +MXC_PLL_DP_CTL ); } -struct clk_ops clk_pllv2_ops = { +static struct clk_ops clk_pllv2_ops = { .prepare = clk_pllv2_prepare, .unprepare = clk_pllv2_unprepare, .recalc_rate = clk_pllv2_recalc_rate,
Signature · 1 line
1.7.9.5
PATCH 8/17 ARM: mach-imx: clk-gate2: Include "clk.h"
In reply to Fabio EstevamFix the following sparse warning:
arch/arm/mach-imx/clk-gate2.c:86:12: warning: symbol 'clk_register_gate2' was not declared. Should it be static?
--- arch/arm/mach-imx/clk-gate2.c | 1 + 1 file changed, 1 insertion(+)
arch/arm/mach-imx/clk-gate2.c +1 -0
@@ -15,6 +15,7 @@#include <linux/io.h> #include <linux/err.h> #include <linux/string.h> +#include "clk.h" /** * DOC: basic gatable clock which can gate and ungate it's ouput
Signature · 1 line
1.7.9.5
PATCH 9/17 ARM: mach-imx: irq-common: Remove imx_irq_set_priority()
In reply to Fabio Estevamimx_irq_set_priority() is not used anywhere, so remove it.
This fixes the following sparse warnings:
arch/arm/mach-imx/irq-common.c:24:5: warning: symbol 'imx_irq_set_priority' was not declared. Should it be static?
--- arch/arm/mach-imx/irq-common.c | 19 ------------------- 1 file changed, 19 deletions(-)
arch/arm/mach-imx/irq-common.c +0 -19
@@ -21,25 +21,6 @@#include "irq-common.h" -int imx_irq_set_priority (unsigned char irq,unsigned char prio) -{ -struct irq_chip_generic *gc; -struct mxc_extra_irq *exirq; -int ret; - - ret = -ENOSYS ; - - gc =irq_get_chip_data (irq); -if (gc && gc->private) { - exirq = gc->private; -if (exirq->set_priority) - ret = exirq->set_priority (irq, prio); - } - -return ret; -} -EXPORT_SYMBOL (imx_irq_set_priority); -int mxc_set_irq_fiq (unsigned int irq,unsigned int type) {struct irq_chip_generic *gc;
Signature · 1 line
1.7.9.5
PATCH 10/17 ARM: mach-imx: clk-busy: Staticize clk_busy_mux_ops
In reply to Fabio EstevamFix the following sparse warning:
arch/arm/mach-imx/clk-busy.c:150:16: warning: symbol 'clk_busy_mux_ops' was not declared. Should it be static?
--- arch/arm/mach-imx/clk-busy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-imx/clk-busy.c +1 -1
@@ -147,7 +147,7 @@ static int clk_busy_mux_set_parent(struct clk_hw *hw, u8 index)return ret; } -struct clk_ops clk_busy_mux_ops = { +static struct clk_ops clk_busy_mux_ops = { .get_parent = clk_busy_mux_get_parent, .set_parent = clk_busy_mux_set_parent, };
Signature · 1 line
1.7.9.5
PATCH 11/17 ARM: mach-imx: clk: Include "clk.h"
In reply to Fabio EstevamFix the following sparse warning:
arch/arm/mach-imx/clk.c:3:1: warning: symbol 'imx_ccm_lock' was not declared. Should it be static?
--- arch/arm/mach-imx/clk.c | 1 + 1 file changed, 1 insertion(+)
arch/arm/mach-imx/clk.c +1 -0
@@ -1,3 +1,4 @@#include <linux/spinlock.h> +#include "clk.h" DEFINE_SPINLOCK (imx_ccm_lock);
Signature · 1 line
1.7.9.5
PATCH 12/17 ARM: mach-imx: tzic: Staticize *tzic_base
In reply to Fabio EstevamFix the following sparse warning:
arch/arm/mach-imx/tzic.c:52:14: warning: symbol 'tzic_base' was not declared. Should it be static?
Also, reduce the comment in order to fit into 80 characters.
--- arch/arm/mach-imx/tzic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-imx/tzic.c +1 -1
@@ -49,7 +49,7 @@#define TZIC_SWINT 0x0F00/* Software Interrupt Rigger Register */ #define TZIC_ID0 0x0FD0/* Indentification Register 0 */ -void __iomem *tzic_base;/* Used as irq controller base in entry-macro.S */ +static void __iomem *tzic_base;/* irq controller base in entry-macro.S */ static struct irq_domain *domain;#define TZIC_NUM_IRQS 128
Signature · 1 line
1.7.9.5
Sascha Hauer
maintainerPATCH 12/17 ARM: mach-imx: tzic: Staticize *tzic_base
Quoted 16 lines · Fabio Estevam
Fix the following sparse warning:
arch/arm/mach-imx/tzic.c:52:14: warning: symbol 'tzic_base' was not declared. Should it be static?Also, reduce the comment in order to fit into 80 characters.
Signed-off-by Fabio Estevam <[email protected]>--- arch/arm/mach-imx/tzic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/mach-imx/tzic.c +0
-0
arch/arm/mach-imx/tzic.c line 52
Quoted 5 lines
arch/arm/mach-imx/tzic.c +1
-1@@ -49,7 +49,7 @@#define TZIC_SWINT 0x0F00/* Software Interrupt Rigger Register */ #define TZIC_ID0 0x0FD0/* Indentification Register 0 */ -void __iomem *tzic_base;/* Used as irq controller base in entry-macro.S */ +static void __iomem *tzic_base;/* irq controller base in entry-macro.S */
The comment is wrong since Linux v3.2, you should remove it.
Sascha
Signature · 4 lines
Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
PATCH 13/17 ARM: mach-imx: avic: Staticize *avic_base
In reply to Fabio EstevamFix the following sparse warning:
arch/arm/mach-imx/avic.c:54:14: warning: symbol 'avic_base' was not declared. Should it be static?
--- arch/arm/mach-imx/avic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-imx/avic.c +1 -1
@@ -51,7 +51,7 @@#define AVIC_NUM_IRQS 64 -void __iomem *avic_base; +static void __iomem *avic_base;static struct irq_domain *domain;static u32 avic_saved_mask_reg[2 ];
Signature · 1 line
1.7.9.5
PATCH 14/17 ARM: mach-imx: anatop: Include "common.h"
In reply to Fabio EstevamFix the following sparse warnings:
arch/arm/mach-imx/anatop.c:56:6: warning: symbol 'imx_anatop_pre_suspend' was not declared. Should it be static? arch/arm/mach-imx/anatop.c:62:6: warning: symbol 'imx_anatop_post_resume' was not declared. Should it be static? arch/arm/mach-imx/anatop.c:68:6: warning: symbol 'imx_anatop_usb_chrg_detect_disable' was not declared. Should it be static? arch/arm/mach-imx/anatop.c:78:5: warning: symbol 'imx_anatop_get_digprog' was not declared. Should it be static? arch/arm/mach-imx/anatop.c:86:13: warning: symbol 'imx_anatop_init' was not declared. Should it be static?
--- arch/arm/mach-imx/anatop.c | 1 + 1 file changed, 1 insertion(+)
arch/arm/mach-imx/anatop.c +1 -0
@@ -15,6 +15,7 @@#include <linux/of_address.h> #include <linux/mfd/syscon.h> #include <linux/regmap.h> +#include "common.h" #define REG_SET 0x4#define REG_CLR 0x8
Signature · 1 line
1.7.9.5
PATCH 15/17 ARM: mach-imx: gpc: Include "common.h"
In reply to Fabio EstevamFix the following sparse warnings:
arch/arm/mach-imx/gpc.c:29:6: warning: symbol 'imx_gpc_pre_suspend' was not declared. Should it be static? arch/arm/mach-imx/gpc.c:43:6: warning: symbol 'imx_gpc_post_resume' was not declared. Should it be static? arch/arm/mach-imx/gpc.c:71:6: warning: symbol 'imx_gpc_mask_all' was not declared. Should it be static? arch/arm/mach-imx/gpc.c:83:6: warning: symbol 'imx_gpc_restore_all' was not declared. Should it be static? arch/arm/mach-imx/gpc.c:122:13: warning: symbol 'imx_gpc_init' was not declared. Should it be static?
--- arch/arm/mach-imx/gpc.c | 1 + 1 file changed, 1 insertion(+)
arch/arm/mach-imx/gpc.c +1 -0
@@ -16,6 +16,7 @@#include <linux/of_address.h> #include <linux/of_irq.h> #include <linux/irqchip/arm-gic.h> +#include "common.h" #define GPC_IMR1 0x008#define GPC_PGC_CPU_PDN 0x2a0
Signature · 1 line
1.7.9.5
PATCH 16/17 ARM: mach-imx: src: Include "common.h
In reply to Fabio EstevamFix the following sparse warnings:
arch/arm/mach-imx/src.c:28:6: warning: symbol 'imx_enable_cpu' was not declared. Should it be static? arch/arm/mach-imx/src.c:39:6: warning: symbol 'imx_set_cpu_jump' was not declared. Should it be static? arch/arm/mach-imx/src.c:46:6: warning: symbol 'imx_src_prepare_restart' was not declared. Should it be static? arch/arm/mach-imx/src.c:59:13: warning: symbol 'imx_src_init' was not declared. Should it be static?
--- arch/arm/mach-imx/src.c | 1 + 1 file changed, 1 insertion(+)
arch/arm/mach-imx/src.c +1 -0
@@ -16,6 +16,7 @@#include <linux/of_address.h> #include <linux/smp.h> #include <asm/smp_plat.h> +#include "common.h" #define SRC_SCR 0x000#define SRC_GPR1 0x020
Signature · 1 line
1.7.9.5
PATCH 17/17 ARM: mach-imx: mach-imx6q: Fix sparse warnings
In reply to Fabio EstevamFix the following sparse warnings:
arch/arm/mach-imx/mach-imx6q.c:60:6: warning: symbol 'imx6q_restart' was not declared. Should it be static? arch/arm/mach-imx/mach-imx6q.c:223:24: warning: symbol 'imx6q_cpufreq_pdev' was not declared. Should it be static?
--- arch/arm/mach-imx/mach-imx6q.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/mach-imx/mach-imx6q.c +2 -2
@@ -57,7 +57,7 @@ static int imx6q_revision(void) } } -void imx6q_restart (char mode,const char *cmd) +static void imx6q_restart (char mode,const char *cmd) {struct device_node *np;void __iomem *wdog_base;
@@ -220,7 +220,7 @@ put_node:of_node_put (np); } -struct platform_device imx6q_cpufreq_pdev = { +static struct platform_device imx6q_cpufreq_pdev = { .name ="imx6q-cpufreq" , };
Signature · 1 line
1.7.9.5
PATCH 1/17 ARM: mach-imx: cpu: Include "common.h"
In reply to Fabio EstevamQuoted 7 lines · Fabio Estevam
Fix the following sparse warnings:
arch/arm/mach-imx/cpu.c:10:6: warning: symbol 'mxc_set_cpu_type' was not declared. Should it be static?arch/arm/mach-imx/cpu.c:15:6: warning: symbol 'imx_print_silicon_rev' was not declared. Should it be static?arch/arm/mach-imx/cpu.c:24:13: warning: symbol 'imx_set_aips' was not declared. Should it be static?Signed-off-by Fabio Estevam <[email protected]>
All applied on imx/non-critical-fixes branch except #14 which is applied on branch imx/soc.
Shawn
Quoted 20 lines
--- arch/arm/mach-imx/cpu.c | 1 + 1 file changed, 1 insertion(+)arch/arm/mach-imx/cpu.c +1
-0@@ -3,6 +3,7 @@#include <linux/io.h> #include "hardware.h" +#include "common.h" unsigned int __mxc_cpu_type;EXPORT_SYMBOL (__mxc_cpu_type);Signature · 1 line
1.7.9.5