Skip to contentSkip to conversation

Initialise correct GPMC WAITx irq for AM33xx

PATCH In review Mark Jackson 3 participants 3 messages Feb 21, 2013 – Mar 26, 2013 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Initialise correct GPMC WAITx irq for AM33xx

Currently WAIT0 irq is reset and then WAIT1 irq is enabled. Fix it such that WAIT0 irq is enabled instead.

---
 arch/arm/cpu/armv7/am33xx/mem.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/cpu/armv7/am33xx/mem.c +1 -1
index b8f54ab..b86b0de 100644
@@ -83,7 +83,7 @@ void gpmc_init(void)
 	/* global settings */
 	writel(0x00000008, &gpmc_cfg->sysconfig);
 	writel(0x00000100, &gpmc_cfg->irqstatus);
-	writel(0x00000200, &gpmc_cfg->irqenable);
+	writel(0x00000100, &gpmc_cfg->irqenable);
 	writel(0x00000012, &gpmc_cfg->config);
 	/*
 	 * Disable the GPMC0 config set by ROM code
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 Initialise correct GPMC WAITx irq for AM33xx

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Mark" == Mark Jackson <[email protected]> writes:

Mark> Currently WAIT0 irq is reset and then WAIT1 irq is enabled. Mark> Fix it such that WAIT0 irq is enabled instead.

Mark> Signed-off-by: Mark Jackson <[email protected]> Mark> ---

 Mark>  arch/arm/cpu/armv7/am33xx/mem.c |    2 +-

Mark> 1 file changed, 1 insertion(+), 1 deletion(-)

Mark> diff --git a/arch/arm/cpu/armv7/am33xx/mem.c b/arch/arm/cpu/armv7/am33xx/mem.c Mark> index b8f54ab..b86b0de 100644
Mark> --- a/arch/arm/cpu/armv7/am33xx/mem.c
Mark> +++ b/arch/arm/cpu/armv7/am33xx/mem.c
Mark> @@ -83,7 +83,7 @@ void gpmc_init(void)

 Mark>  	/* global settings */
 Mark>  	writel(0x00000008, &gpmc_cfg->sysconfig);
 Mark>  	writel(0x00000100, &gpmc_cfg->irqstatus);

Mark> - writel(0x00000200, &gpmc_cfg->irqenable);
Mark> + writel(0x00000100, &gpmc_cfg->irqenable);

Why do we even enable the irq in the first place? The gpmc driver just polls irqstatus anyway.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw
In reply to Mark Jackson
Quoted 5 lines · Mark Jackson

Currently WAIT0 irq is reset and then WAIT1 irq is enabled. Fix it such that WAIT0 irq is enabled instead.

Applied to u-boot-ti/master (and already pulled into u-boot-arm), thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130326/968f8a78/attachment.pgp>