Skip to contentSkip to conversation

Enhancement needed to UNIX extensions to correctly support Linux EA's.

DISCUSSION Jeremy Allison 3 participants 5 messages Mar 26, 2013 – Mar 27, 2013 2 messages not in the archive

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

See bug https://bugzilla.samba.org/show_bug.cgi?id=9743

No way to set zero length EA's with CIFS vfs.

I was doing some investigations around bug #9130, where Windows fails to copy a file when we return a zero-length EA associated with it.

Looking carefully into this this is a deficiency in the CIFS UNIX protocols. On Linux it's possible to set a zero-length EA on a file/directory as a tag of some kind, with no associated data.

On Windows this is impossible - trying to set a zero-length EA will just delete it, plus the EA names are case insensitive (and always returned uppercase).

We need to add a UNIX_GET_EAS call that can return all POSIX EA's without mangling case, and can also return zero-length EA's, also we need a UNIX_SET_EAS call that can set a zero length EA, and also has an additional 'flags' field that can delete an EA if set.

Please discuss,

Jeremy.

#1 lore raw

Seems like a reasonable request. What version of kernel do you want
me to give you some test patches for?

Quoted 22 lines · Jeremy Allison

See bug https://bugzilla.samba.org/show_bug.cgi?id=9743

No way to set zero length EA's with CIFS vfs.

I was doing some investigations around bug #9130, where Windows fails to copy a file when we return a zero-length EA associated with it.

Looking carefully into this this is a deficiency in the CIFS UNIX protocols. On Linux it's possible to set a zero-length EA on a file/directory as a tag of some kind, with no associated data.

On Windows this is impossible - trying to set a zero-length EA will just delete it, plus the EA names are case insensitive (and always returned uppercase).

We need to add a UNIX_GET_EAS call that can return all POSIX EA's without mangling case, and can also return zero-length EA's, also we need a UNIX_SET_EAS call that can set a zero length EA, and also has an additional 'flags' field that can delete an EA if set.

Please discuss,

Jeremy.

Signature · 3 lines
Thanks,

Steve

A message that is not in the archive (sent off-list or not yet received): CAH2r5msU86Q0_PbiqZCf729hDkX9o0e_jYh87d=T8wmQKsYHHg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#3 lore raw
Quoted 2 lines · Steve French

Seems like a reasonable request. What version of kernel do you want
me to give you some test patches for?

Well first let's work out the wire format, then we can look at implementations.

I'm assuming you'll be re-using the existing EA marshalling/de-marshalling code, so let's decide exactly which Windows info-level we want to base it on.

Jeremy.

#4 lore raw
Quoted 7 lines · On Tue, 26 Mar 2013 14:33:01 -0700 Jeremy Allison…
Quoted 2 lines · Steve French

Seems like a reasonable request. What version of kernel do you want
me to give you some test patches for?

Well first let's work out the wire format, then we can look at implementations.

Quoted 6 lines

I'm assuming you'll be re-using the existing EA marshalling/de-marshalling code, so let's decide exactly which Windows info-level we want to base it on.

Jeremy.

Yeah, sounds reasonable to me too. We currently only use:

SMB_INFO_QUERY_ALL_EAS
SMB_SET_FILE_EA

However, the current marshalling/unmarshalling code is a bit of a mess, so if it makes sense to depart from how those work then we can do so.

Note that we ought to add a new unix capability bit for this too.

Signature · 1 line
Jeff Layton <[email protected]>

A message that is not in the archive (sent off-list or not yet received): 20130327102957.4dcd9f65-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org

#6 lore raw
Quoted 17 lines · Jeff Layton
Quoted 7 lines · On Tue, 26 Mar 2013 14:33:01 -0700 Jeremy Allison…
Quoted 2 lines · Steve French

Seems like a reasonable request. What version of kernel do you want
me to give you some test patches for?

Well first let's work out the wire format, then we can look at implementations.

Quoted 6 lines

I'm assuming you'll be re-using the existing EA marshalling/de-marshalling code, so let's decide exactly which Windows info-level we want to base it on.

Jeremy.

Quoted 7 lines

Yeah, sounds reasonable to me too. We currently only use:

SMB_INFO_QUERY_ALL_EAS
SMB_SET_FILE_EA

However, the current marshalling/unmarshalling code is a bit of a mess, so if it makes sense to depart from how those work then we can do so.

Yeah, but we already have working server-side marshalling/unmarshalling code, so I'd rather not invent a new mechanism, other than specify that the EA name be in utf8 rather than DOS charset.

Quoted 1 line

Note that we ought to add a new unix capability bit for this too.

Yep, and also raise the minor version number.

Jeremy.