cmd_ext4: BREAK and correct ext4write parameter order
PATCH 1/1 cmd_ext4: BREAK and correct ext4write parameter order
The ext4write command was taking the in-memory address and filename path in reverse order from the rest of the filesystem read and write commands. This corrects the order to be the same as fatload, etc.
Signed-off-by Tom Rini <[email protected]>
--- common/cmd_ext4.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
common/cmd_ext4.c +3 -3
@@ -88,10 +88,10 @@ int do_ext4_write(cmd_tbl_t *cmdtp, int flag, int argc, dev = dev_desc->dev;/* get the filename */ - filename = argv[3 ]; + filename = argv[4 ];/* get the address in hexadecimal format (string to int) */ - ram_address =simple_strtoul (argv[4 ],NULL ,16 ); + ram_address =simple_strtoul (argv[3 ],NULL ,16 );/* get the filesize in base 10 format */ file_size =simple_strtoul (argv[5 ],NULL ,10 );
@@ -122,7 +122,7 @@ fail:U_BOOT_CMD (ext4write,6 ,1 , do_ext4_write,"create a file in the root directory" , -"<interface> <dev[:part]> [Absolute filename path] [Address] [sizebytes]\n" +"<interface> <dev[:part]> <addr> <absolute filename path> [sizebytes]\n" " - create a file in / directory" );#endif
Signature · 1 line
1.7.9.5
Quoted 5 lines · Tom Rini
The ext4write command was taking the in-memory address and filename path in reverse order from the rest of the filesystem read and write commands. This corrects the order to be the same as fatload, etc.
Signed-off-by Tom Rini <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130327/7e4541cd/attachment.pgp>