ARM: mvebu: Add gpio button to Mirabox board
A message that is not in the archive (sent off-list or not yet received): CABx3TkVyVAzEJ54FV70fK3BoULKCOkgNcw32_K3XT-oCUWjEfg@mail.gmail.com
PATCH 1/1 ARM: mvebu: Add gpio button to Mirabox board
Hi Ryan,
Quoted 6 lines · Ryan Press
Quoted 5 lines · Ezequiel Garcia
The Globalscale Mirabox board has a little gpio button placed just above the SD card slot; the board user guide labels this button as "System reset button".
Quoted 13 lines
arch/arm/boot/dts/armada-370-mirabox.dts
Quoted 10 lines
This patch adds support for this button in the device tree file.
arch/arm/boot/dts/armada-370-mirabox.dts +8
-0+ gpio-keys { + compatible = "gpio-keys"; + #address-cells = <1>; + #size-cells = <0>; + reset at 1 { + label = "Reset Button"; + linux,code = <116>; + gpios = <&gpio1 26 1>;Were you able to get the button to work in user space with "gpio-keys"?
I did a very minimal test using evdev debug interface.
http://troll.ws/paste/ac62e292
http://troll.ws/paste/b22699e1
Quoted 4 lines
I was not able to get this to work, I think there is some IRQ problem. I was able to get it to work with "gpio-keys-polled" however.
Could you explain what you did and what was your problem?
Quoted 2 lines
I've also added support for the LEDs; would you like me to submit a patch?
Mirabox LEDs? Sure! I'll definitely give them a try...
Signature · 3 lines
Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com
PATCH 1/1 ARM: mvebu: Add gpio button to Mirabox board
Hi Ezequiel,
Quoted 7 lines · Ezequiel Garcia
Quoted 6 lines · Ryan Press
Quoted 5 lines · Ezequiel Garcia
The Globalscale Mirabox board has a little gpio button placed just above the SD card slot; the board user guide labels this button as "System reset button".
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
This patch adds support for this button in the device tree file.
I was not able to get this to work, I think there is some IRQ problem. I was able to get it to work with "gpio-keys-polled" however.
Could you explain what you did and what was your problem?
Just to be on the same page, I pulled the latest 3-9-rc4, with no other changes, and then added your patch. Does this rely on a patch? No interrupt events are shown in /proc/interrupts. I have a lot more things running than your box, maybe there is a conflict.
#cat /proc/interrupts
CPU0
16: 12222 armada_370_xp_irq armada_370_xp_per_cpu_tick 17: 552 armada_370_xp_irq serial 25: 0 armada_370_xp_irq d0010300.rtc 27: 6438 armada_370_xp_irq ehci_hcd:usb1 28: 0 armada_370_xp_irq ehci_hcd:usb2 95: 0 d0018140.gpio Reset Button 104: 2 armada_370_xp_irq d0060800.xor 105: 2 armada_370_xp_irq d0060800.xor 106: 2 armada_370_xp_irq d0060900.xor 107: 2 armada_370_xp_irq d0060900.xor IPI0: 0 CPU wakeup interrupts IPI1: 0 Timer broadcast interrupts IPI2: 0 Rescheduling interrupts IPI3: 0 Function call interrupts IPI4: 0 Single function call interrupts IPI5: 0 CPU stop interrupts Err: 0
Here is my kernel config:
http://pastebin.com/rFQSUAPs
Maybe you can send me your config and I will try it.
Oh and although I guess the bootloader sets it up, i wouldn't trust it. There should probably be the pinctrl in the device tree, yes?
Thanks,
Ryan
(quoted diff) +0 -0
b/arch/arm/boot/dts/armada-370-mirabox.dts
index dd0c57d..f083f56 100644
arch/arm/boot/dts/armada-370-mirabox.dts +8 -0
@@ -33,6 +33,14 @@ clock-frequency = <600000000>; status = "okay"; }; + + pinctrl { + reset_button_pin: reset-button-pin { + marvell,pins = "mpp58"; + marvell,function = "gpio"; + }; + } + gpio-keys { compatible = "gpio-keys"; #address-cells = <1>;
PATCH 1/1 ARM: mvebu: Add gpio button to Mirabox board
Quoted 17 lines · Ryan Press
Hi Ezequiel,
Quoted 13 lines · Ezequiel Garcia
Quoted 11 lines · Ryan Press
Quoted 6 lines · Ezequiel Garcia
The Globalscale Mirabox board has a little gpio button placed just above the SD card slot; the board user guide labels this button as "System reset button".
This patch adds support for this button in the device tree file.
I was not able to get this to work, I think there is some IRQ problem. I was able to get it to work with "gpio-keys-polled" however.
Quoted 7 lines
Quoted 1 line
Could you explain what you did and what was your problem?
Just to be on the same page, I pulled the latest 3-9-rc4, with no other changes, and then added your patch. Does this rely on a patch? No interrupt events are shown in
/proc/interrupts. I have a lot more things running than your box, maybe there is a conflict.
Try disabling SMP in your config.
Quoted 4 lines
Oh and although I guess the bootloader sets it up, i wouldn't trust it. There should probably be the pinctrl in the device tree, yes?
Yes, you're right. I'll take this into a v2.
Signature · 3 lines
Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com
PATCH 1/1 ARM: mvebu: Add gpio button to Mirabox board
Quoted 18 lines · Ezequiel Garcia
Quoted 17 lines · Ryan Press
Quoted 14 lines · Ezequiel Garcia
Quoted 11 lines · Ryan Press
Quoted 6 lines · Ezequiel Garcia
The Globalscale Mirabox board has a little gpio button placed just above the SD card slot; the board user guide labels this button as "System reset button".
This patch adds support for this button in the device tree file.
I was not able to get this to work, I think there is some IRQ problem. I was able to get it to work with "gpio-keys-polled" however.
Could you explain what you did and what was your problem?
Quoted 7 lines
Quoted 5 lines
Just to be on the same page, I pulled the latest 3-9-rc4, with no other changes, and then added your patch. Does this rely on a patch? No interrupt events are shown in
/proc/interrupts. I have a lot more things running than your box, maybe there is a conflict.Try disabling SMP in your config.
Yes, that worked, thanks! I used mvebu_defconfig initially, and this has CONFIG_SMP. That's more for the Armada-XP I guess as for the Armada-370 it's not needed.
So I guess that means that there's something wrong with the GPIO IRQs with SMP. Anyway it doesn't matter for the 370.
Thanks,
Ryan
PATCH 1/1 ARM: mvebu: Add gpio button to Mirabox board
Quoted 26 lines · Ryan Press
Quoted 24 lines · Ezequiel Garcia
Quoted 22 lines · Ryan Press
Quoted 7 lines · Ezequiel Garcia
Quoted 6 lines · Ryan Press
Quoted 5 lines · Ezequiel Garcia
The Globalscale Mirabox board has a little gpio button placed just above the SD card slot; the board user guide labels this button as "System reset button".
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
This patch adds support for this button in the device tree file.
I was not able to get this to work, I think there is some IRQ problem. I was able to get it to work with "gpio-keys-polled" however.
Could you explain what you did and what was your problem?
Just to be on the same page, I pulled the latest 3-9-rc4, with no other changes, and then added your patch. Does this rely on a patch? No interrupt events are shown in
/proc/interrupts. I have a lot more things running than your box, maybe there is a conflict.
Quoted 6 lines
Quoted 1 line
Try disabling SMP in your config.
Yes, that worked, thanks! I used
mvebu_defconfiginitially, and this hasCONFIG_SMP. That's more for the Armada-XP I guess as for the Armada-370 it's not needed.
Great.
Quoted 3 lines
So I guess that means that there's something wrong with the GPIO IRQs with SMP. Anyway it doesn't matter for the 370.
Indeed, it doesn't matter if you plan to use your kernel only in a A370 SoC based product (A370 is single core). However, I'm afraid this could be a problem if you plan to use the same kernel on A370 *and* AXP (multi core) SoCs.
Next week, we'll try to debug this issue (I've added Thomas, Gregory and Lior in Cc who might have better understanding about this).
Thanks,
Signature · 3 lines
Ezequiel Garc?a, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com