Skip to contentSkip to conversation

ARM: at91: dts: add adc resolution stuff

PATCH New ludovic.desroches at atmel.com 4 participants 5 messages Mar 29, 2013 – Apr 2, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: at91: dts: add adc resolution stuff

From: Ludovic Desroches <[email protected]>

Add the ADC low and high resolution configuration and which one to use.

---

Hi,

This patch is a split from this set of patches:
http://thread.gmane.org/gmane.linux.ports.arm.kernel/206130/focus=6321

Then device tree changes can go through ARM-SOC and driver changes through the iio subsystem.

Regards

Ludovic

 arch/arm/boot/dts/at91sam9260.dtsi | 3 +++
 arch/arm/boot/dts/at91sam9g45.dtsi | 3 +++
 arch/arm/boot/dts/at91sam9x5.dtsi  | 3 +++
 3 files changed, 9 insertions(+)
arch/arm/boot/dts/at91sam9260.dtsi +3 -0
index cb7bcc5..367a604 100644
@@ -484,6 +484,9 @@
 				atmel,adc-drdy-mask = <0x10000>;
 				atmel,adc-status-register = <0x1c>;
 				atmel,adc-trigger-register = <0x04>;
+				atmel,adc-res = <8 10>;
+				atmel,adc-res-names = "lowres", "highres";
+				atmel,adc-use-res = "highres";
 
 				trigger at 0 {
 					trigger-name = "timer-counter-0";
arch/arm/boot/dts/at91sam9g45.dtsi +3 -0
index 6b1d4ca..0fa28af 100644
@@ -484,6 +484,9 @@
 				atmel,adc-drdy-mask = <0x10000>;
 				atmel,adc-status-register = <0x1c>;
 				atmel,adc-trigger-register = <0x08>;
+				atmel,adc-res = <8 10>;
+				atmel,adc-res-names = "lowres", "highres";
+				atmel,adc-use-res = "highres";
 
 				trigger at 0 {
 					trigger-name = "external-rising";
arch/arm/boot/dts/at91sam9x5.dtsi +3 -0
index a98c0d5..08bcdd7 100644
@@ -505,6 +505,9 @@
 				atmel,adc-drdy-mask = <0x1000000>;
 				atmel,adc-status-register = <0x30>;
 				atmel,adc-trigger-register = <0xc0>;
+				atmel,adc-res = <8 10>;
+				atmel,adc-res-names = "lowres", "highres";
+				atmel,adc-use-res = "highres";
 
 				trigger at 0 {
 					trigger-name = "external-rising";
Signature · 1 line
1.7.11.3
maintainer
#1 lore raw

PATCH 1/1 ARM: at91: dts: add adc resolution stuff

Quoted 8 lines · ludovic.desroches at atmel.com

From: Ludovic Desroches <[email protected]>

Add the ADC low and high resolution configuration and which one to use.

---

Quoted 7 lines

Hi,

This patch is a split from this set of patches:
http://thread.gmane.org/gmane.linux.ports.arm.kernel/206130/focus=6321

Then device tree changes can go through ARM-SOC and driver changes through the iio subsystem.

I am guessing the IIO side is to follow. Even when posting series where it different bits are to go through different trees, it is useful to have them in one series so that people can see the whole result.

Quoted 53 lines

Regards

Ludovic

 arch/arm/boot/dts/at91sam9260.dtsi | 3 +++
 arch/arm/boot/dts/at91sam9g45.dtsi | 3 +++
 arch/arm/boot/dts/at91sam9x5.dtsi  | 3 +++
 3 files changed, 9 insertions(+)
arch/arm/boot/dts/at91sam9260.dtsi +3 -0
index cb7bcc5..367a604 100644
@@ -484,6 +484,9 @@
 				atmel,adc-drdy-mask = <0x10000>;
 				atmel,adc-status-register = <0x1c>;
 				atmel,adc-trigger-register = <0x04>;
+				atmel,adc-res = <8 10>;
+				atmel,adc-res-names = "lowres", "highres";
+				atmel,adc-use-res = "highres";
 
 				trigger at 0 {
 					trigger-name = "timer-counter-0";
arch/arm/boot/dts/at91sam9g45.dtsi +3 -0
index 6b1d4ca..0fa28af 100644
@@ -484,6 +484,9 @@
 				atmel,adc-drdy-mask = <0x10000>;
 				atmel,adc-status-register = <0x1c>;
 				atmel,adc-trigger-register = <0x08>;
+				atmel,adc-res = <8 10>;
+				atmel,adc-res-names = "lowres", "highres";
+				atmel,adc-use-res = "highres";
 
 				trigger at 0 {
 					trigger-name = "external-rising";
arch/arm/boot/dts/at91sam9x5.dtsi +3 -0
index a98c0d5..08bcdd7 100644
@@ -505,6 +505,9 @@
 				atmel,adc-drdy-mask = <0x1000000>;
 				atmel,adc-status-register = <0x30>;
 				atmel,adc-trigger-register = <0xc0>;
+				atmel,adc-res = <8 10>;
+				atmel,adc-res-names = "lowres", "highres";
+				atmel,adc-use-res = "highres";
 
 				trigger at 0 {
 					trigger-name = "external-rising";
#2 lore raw

PATCH 1/1 ARM: at91: dts: add adc resolution stuff

On 03/29/2013 10:47 AM, Jonathan Cameron :

Quoted 11 lines · ludovic.desroches at atmel.com
Quoted 10 lines

From: Ludovic Desroches <[email protected]>

Add the ADC low and high resolution configuration and which one to use.

---

Hi,

Quoted 8 lines
Quoted 5 lines

This patch is a split from this set of patches:
http://thread.gmane.org/gmane.linux.ports.arm.kernel/206130/focus=6321

Then device tree changes can go through ARM-SOC and driver changes through the iio subsystem.

I am guessing the IIO side is to follow. Even when posting series where it different bits are to go through different trees, it is useful to have them in one series so that people can see the whole result.

Yes, a v2 series is coming. In fact, I asked Ludovic to post his .dtsi modifications separately because:
- From the fist discussion, it seemed that we reached a consensus and that the current binding is okay
- I have to reassemble a pull-request to arm-soc maintainers for 3.10 and it seems that is is time to collect all material.

So, I plan to stack this update of AT91 device tree files real soon. If you want to give me your acknowledgement once you have read the whole series, let me know...

Best regards,

Quoted 50 lines
Quoted 48 lines
 arch/arm/boot/dts/at91sam9260.dtsi | 3 +++
 arch/arm/boot/dts/at91sam9g45.dtsi | 3 +++
 arch/arm/boot/dts/at91sam9x5.dtsi  | 3 +++
 3 files changed, 9 insertions(+)
arch/arm/boot/dts/at91sam9260.dtsi +3 -0
index cb7bcc5..367a604 100644
@@ -484,6 +484,9 @@
 				atmel,adc-drdy-mask = <0x10000>;
 				atmel,adc-status-register = <0x1c>;
 				atmel,adc-trigger-register = <0x04>;
+				atmel,adc-res = <8 10>;
+				atmel,adc-res-names = "lowres", "highres";
+				atmel,adc-use-res = "highres";
 
 				trigger at 0 {
 					trigger-name = "timer-counter-0";
arch/arm/boot/dts/at91sam9g45.dtsi +3 -0
index 6b1d4ca..0fa28af 100644
@@ -484,6 +484,9 @@
 				atmel,adc-drdy-mask = <0x10000>;
 				atmel,adc-status-register = <0x1c>;
 				atmel,adc-trigger-register = <0x08>;
+				atmel,adc-res = <8 10>;
+				atmel,adc-res-names = "lowres", "highres";
+				atmel,adc-use-res = "highres";
 
 				trigger at 0 {
 					trigger-name = "external-rising";
arch/arm/boot/dts/at91sam9x5.dtsi +3 -0
index a98c0d5..08bcdd7 100644
@@ -505,6 +505,9 @@
 				atmel,adc-drdy-mask = <0x1000000>;
 				atmel,adc-status-register = <0x30>;
 				atmel,adc-trigger-register = <0xc0>;
+				atmel,adc-res = <8 10>;
+				atmel,adc-res-names = "lowres", "highres";
+				atmel,adc-use-res = "highres";
 
 				trigger at 0 {
 					trigger-name = "external-rising";
Signature · 1 line
Nicolas Ferre
maintainer
#3 lore raw

PATCH 1/1 ARM: at91: dts: add adc resolution stuff

Quoted 17 lines · Nicolas Ferre

On 03/29/2013 10:47 AM, Jonathan Cameron :

Quoted 16 lines · ludovic.desroches at atmel.com
Quoted 15 lines

From: Ludovic Desroches <[email protected]>

Add the ADC low and high resolution configuration and which one to use.

---

Hi,

This patch is a split from this set of patches:
http://thread.gmane.org/gmane.linux.ports.arm.kernel/206130/focus=6321

Then device tree changes can go through ARM-SOC and driver changes through the iio subsystem.

Quoted 8 lines
Quoted 3 lines

I am guessing the IIO side is to follow. Even when posting series where it different bits are to go through different trees, it is useful to have them in one series so that people can see the whole result.

Yes, a v2 series is coming. In fact, I asked Ludovic to post his .dtsi modifications separately because:
- From the fist discussion, it seemed that we reached a consensus and that the current binding is okay

Consensus is probably putting it a bit strongly given Maxime's comments but as there was no specific alternative suggested and they Maxime was raising general issues rathe rthan specifics, I'll take the iio side of these as is.

Quoted 62 lines

- I have to reassemble a pull-request to arm-soc maintainers for 3.10 and it seems that is is time to collect all material.

So, I plan to stack this update of AT91 device tree files real soon. If you want to give me your acknowledgement once you have read the whole series, let me know...

Best regards,

Quoted 50 lines
Quoted 48 lines
 arch/arm/boot/dts/at91sam9260.dtsi | 3 +++
 arch/arm/boot/dts/at91sam9g45.dtsi | 3 +++
 arch/arm/boot/dts/at91sam9x5.dtsi  | 3 +++
 3 files changed, 9 insertions(+)
arch/arm/boot/dts/at91sam9260.dtsi +3 -0
index cb7bcc5..367a604 100644
@@ -484,6 +484,9 @@
 				atmel,adc-drdy-mask = <0x10000>;
 				atmel,adc-status-register = <0x1c>;
 				atmel,adc-trigger-register = <0x04>;
+				atmel,adc-res = <8 10>;
+				atmel,adc-res-names = "lowres", "highres";
+				atmel,adc-use-res = "highres";
 
 				trigger at 0 {
 					trigger-name = "timer-counter-0";
arch/arm/boot/dts/at91sam9g45.dtsi +3 -0
index 6b1d4ca..0fa28af 100644
@@ -484,6 +484,9 @@
 				atmel,adc-drdy-mask = <0x10000>;
 				atmel,adc-status-register = <0x1c>;
 				atmel,adc-trigger-register = <0x08>;
+				atmel,adc-res = <8 10>;
+				atmel,adc-res-names = "lowres", "highres";
+				atmel,adc-use-res = "highres";
 
 				trigger at 0 {
 					trigger-name = "external-rising";
arch/arm/boot/dts/at91sam9x5.dtsi +3 -0
index a98c0d5..08bcdd7 100644
@@ -505,6 +505,9 @@
 				atmel,adc-drdy-mask = <0x1000000>;
 				atmel,adc-status-register = <0x30>;
 				atmel,adc-trigger-register = <0xc0>;
+				atmel,adc-res = <8 10>;
+				atmel,adc-res-names = "lowres", "highres";
+				atmel,adc-use-res = "highres";
 
 				trigger at 0 {
 					trigger-name = "external-rising";
#4 lore raw

PATCH 1/1 ARM: at91: dts: add adc resolution stuff

In reply to Jonathan Cameron
Quoted 11 lines · Jonathan Cameron
Quoted 10 lines · ludovic.desroches at atmel.com

From: Ludovic Desroches <[email protected]>

Add the ADC low and high resolution configuration and which one to use.

---

Hi,

Quoted 8 lines
Quoted 5 lines

This patch is a split from this set of patches:
http://thread.gmane.org/gmane.linux.ports.arm.kernel/206130/focus=6321

Then device tree changes can go through ARM-SOC and driver changes through the iio subsystem.

I am guessing the IIO side is to follow. Even when posting series where it different bits are to go through different trees, it is useful to have them in one series so that people can see the whole result.

I agree too

Ludo please resend the whole series

Best Regards,
J.

Quoted 55 lines
Quoted 55 lines

Regards

Ludovic

 arch/arm/boot/dts/at91sam9260.dtsi | 3 +++
 arch/arm/boot/dts/at91sam9g45.dtsi | 3 +++
 arch/arm/boot/dts/at91sam9x5.dtsi  | 3 +++
 3 files changed, 9 insertions(+)
arch/arm/boot/dts/at91sam9260.dtsi +3 -0
index cb7bcc5..367a604 100644
@@ -484,6 +484,9 @@
 				atmel,adc-drdy-mask = <0x10000>;
 				atmel,adc-status-register = <0x1c>;
 				atmel,adc-trigger-register = <0x04>;
+				atmel,adc-res = <8 10>;
+				atmel,adc-res-names = "lowres", "highres";
+				atmel,adc-use-res = "highres";
 
 				trigger at 0 {
 					trigger-name = "timer-counter-0";
arch/arm/boot/dts/at91sam9g45.dtsi +3 -0
index 6b1d4ca..0fa28af 100644
@@ -484,6 +484,9 @@
 				atmel,adc-drdy-mask = <0x10000>;
 				atmel,adc-status-register = <0x1c>;
 				atmel,adc-trigger-register = <0x08>;
+				atmel,adc-res = <8 10>;
+				atmel,adc-res-names = "lowres", "highres";
+				atmel,adc-use-res = "highres";
 
 				trigger at 0 {
 					trigger-name = "external-rising";
arch/arm/boot/dts/at91sam9x5.dtsi +3 -0
index a98c0d5..08bcdd7 100644
@@ -505,6 +505,9 @@
 				atmel,adc-drdy-mask = <0x1000000>;
 				atmel,adc-status-register = <0x30>;
 				atmel,adc-trigger-register = <0xc0>;
+				atmel,adc-res = <8 10>;
+				atmel,adc-res-names = "lowres", "highres";
+				atmel,adc-use-res = "highres";
 
 				trigger at 0 {
 					trigger-name = "external-rising";