misc/vmw_vmci: VMWARE_VMCI depends on NET
Subsystems (2)
PATCH 1/1 misc/vmw_vmci: VMWARE_VMCI depends on NET
Fix:
ERROR: "memcpy_toiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined!
ERROR: "memcpy_fromiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined!
Both functions are defined in the core networking code.
--- drivers/misc/vmw_vmci/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/misc/vmw_vmci/Kconfig +1 -1
@@ -4,7 +4,7 @@ config VMWARE_VMCI tristate "VMware VMCI Driver" - depends on X86 && PCI + depends on X86 && PCI && NET help This is VMware's Virtual Machine Communication Interface. It enables high-speed communication between host and guest in a virtual
Signature · 1 line
1.7.9.7
Quoted 8 lines · Guenter Roeck
Fix:
ERROR: "
memcpy_toiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined!
ERROR: "memcpy_fromiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined!Both functions are defined in the core networking code.
Signed-off-by Guenter Roeck <[email protected]>
Thanks.
Quoted 18 lines
--- drivers/misc/vmw_vmci/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/misc/vmw_vmci/Kconfig +1
-1@@ -4,7 +4,7 @@ config VMWARE_VMCI tristate "VMware VMCI Driver" - depends on X86 && PCI + depends on X86 && PCI && NET help This is VMware's Virtual Machine Communication Interface. It enables high-speed communication between host and guest in a virtual
Signature · 1 line
~Randy
Greg Kroah-Hartman
maintainerQuoted 6 lines · Guenter Roeck
Fix:
ERROR: "
memcpy_toiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined!
ERROR: "memcpy_fromiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined!Both functions are defined in the core networking code.
This is already in linux-next, thanks.
greg k-h
Quoted 10 lines · Greg Kroah-Hartman
Quoted 6 lines · Guenter Roeck
Fix:
ERROR: "
memcpy_toiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined!
ERROR: "memcpy_fromiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined!Both functions are defined in the core networking code.
This is already in linux-next, thanks.
Uuh ... and I submitted it. Sorry for the noise.
Any chance to apply this to 3.9-rc ? It causes a bunch of unnecessary nightly build errors for me.
Thanks,
Guenter
Greg Kroah-Hartman
maintainerQuoted 7 lines · Guenter Roeck
Quoted 6 lines · Greg Kroah-Hartman
Quoted 5 lines · Guenter Roeck
Fix:
ERROR: "
memcpy_toiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined!
ERROR: "memcpy_fromiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined!
Quoted 8 lines
Quoted 4 lines
Quoted 1 line
Both functions are defined in the core networking code.
This is already in linux-next, thanks.
Uuh ... and I submitted it. Sorry for the noise.
Any chance to apply this to 3.9-rc ? It causes a bunch of unnecessary nightly build errors for me.
As it's a configuration that no "real" user would ever hit, it's not really 3.9 material, sorry.
greg k0h
Quoted 12 lines · Greg Kroah-Hartman
Quoted 11 lines · Guenter Roeck
Quoted 10 lines · Greg Kroah-Hartman
Quoted 6 lines · Guenter Roeck
Fix:
ERROR: "
memcpy_toiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined!
ERROR: "memcpy_fromiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined!Both functions are defined in the core networking code.
This is already in linux-next, thanks.
Quoted 8 lines
Quoted 4 lines
Uuh ... and I submitted it. Sorry for the noise.
Any chance to apply this to 3.9-rc ? It causes a bunch of unnecessary nightly build errors for me.
As it's a configuration that no "real" user would ever hit, it's not really 3.9 material, sorry.
Fair enough.
On the other side, value of "make randconfig" has been reduced significantly compared to earlier times, when patches like this tended to be accepted into release candidates. Until a few releases ago, "make randconfig" usually passed at least for main targets by the time a kernel was relased. With this no longer the case, fewer and fewer people will look into nightly or per-rc build results and provide patches. This in turn will likely reduce reliability, as real problems are more and more hidden among all the "unreal" build errors. In addition to that, more and more people will end up with non-buildable configurations and have to spend time trying to figure out why exactly a build failed.
But maybe this is all my imagination, so feel free to just ignore my ranting ;).
Guenter
Quoted 34 lines · Guenter Roeck
Quoted 12 lines · Greg Kroah-Hartman
Quoted 11 lines · Guenter Roeck
Quoted 10 lines · Greg Kroah-Hartman
Quoted 6 lines · Guenter Roeck
Fix:
ERROR: "
memcpy_toiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined!
ERROR: "memcpy_fromiovec" [drivers/misc/vmw_vmci/vmw_vmci.ko] undefined!Both functions are defined in the core networking code.
This is already in linux-next, thanks.
Quoted 8 lines
Quoted 4 lines
Uuh ... and I submitted it. Sorry for the noise.
Any chance to apply this to 3.9-rc ? It causes a bunch of unnecessary nightly build errors for me.
As it's a configuration that no "real" user would ever hit, it's not really 3.9 material, sorry.
Fair enough.
On the other side, value of "make randconfig" has been reduced significantly compared to earlier times, when patches like this tended to be accepted into release candidates. Until a few releases ago, "make randconfig" usually passed at least for main targets by the time a kernel was relased. With this no longer the case, fewer and fewer people will look into nightly or per-rc build results and provide patches. This in turn will likely reduce reliability, as real problems are more and more hidden among all the "unreal" build errors. In addition to that, more and more people will end up with non-buildable configurations and have to spend time trying to figure out why exactly a build failed.
Quoted 1 line
But maybe this is all my imagination, so feel free to just ignore my ranting ;).
My experiences have been that Linus is not opposed to taking such build fixes at almost any time. IOW, I think that Greg is being more strict than Linus would be, but Greg is the misc/ maintainer, so it's his call.
Signature · 1 line
~Randy