pwm: mxs: Remove unused *dev from struct mxs_pwm_chip
Subsystems (2)
PATCH 1/2 pwm: mxs: Remove unused *dev from struct mxs_pwm_chip
Signed-off-by Axel Lin <[email protected]>
--- drivers/pwm/pwm-mxs.c | 2 -- 1 file changed, 2 deletions(-)
drivers/pwm/pwm-mxs.c +0 -2
@@ -38,7 +38,6 @@struct mxs_pwm_chip {struct pwm_chip chip; -struct device *dev;struct clk *clk;void __iomem *base; };
@@ -166,7 +165,6 @@ static int mxs_pwm_probe(struct platform_device *pdev)return ret; } - mxs->dev = &pdev->dev;platform_set_drvdata (pdev, mxs);stmp_reset_block (mxs->base);
Signature · 1 line
1.7.10.4
PATCH 2/2 pwm: mxs: Remove unused *dev from struct spear_pwm_chip
Signed-off-by Axel Lin <[email protected]>
--- drivers/pwm/pwm-spear.c | 3 --- 1 file changed, 3 deletions(-)
drivers/pwm/pwm-spear.c +0 -3
@@ -49,13 +49,11 @@* @mmio_base: base address of pwm chip * @clk: pointer to clk structure of pwm chip * @chip: linux pwm chip representation -* @dev: pointer to device structure of pwm chip */ struct spear_pwm_chip {void __iomem *mmio_base;struct clk *clk;struct pwm_chip chip; -struct device *dev; };static inline struct spear_pwm_chip *to_spear_pwm_chip (struct pwm_chip *chip)
@@ -200,7 +198,6 @@ static int spear_pwm_probe(struct platform_device *pdev)if (IS_ERR (pc->clk))return PTR_ERR (pc->clk); - pc->dev = &pdev->dev;platform_set_drvdata (pdev, pc); pc->chip.dev = &pdev->dev;
Signature · 1 line
1.7.10.4
Re: [PATCH 2/2] pwm: mxs: Remove unused *dev from struct spear_pwm_chip
Hi Axel,
Perhaps you meant pwm: spear: (instead of pwm: mxs) in the subject line.
Quoted 33 lines · Axel Lin
Signed-off-by Axel Lin <[email protected]>--- drivers/pwm/pwm-spear.c | 3 --- 1 file changed, 3 deletions(-)drivers/pwm/pwm-spear.c +0
-3@@ -49,13 +49,11 @@* @mmio_base: base address of pwm chip * @clk: pointer to clk structure of pwm chip * @chip: linux pwm chip representation -* @dev: pointer to device structure of pwm chip */ struct spear_pwm_chip {void __iomem *mmio_base;struct clk *clk;struct pwm_chip chip; -struct device *dev; };static inline struct spear_pwm_chip *to_spear_pwm_chip (struct pwm_chip *chip)@@ -200,7 +198,6 @@ static int spear_pwm_probe(struct platform_device *pdev)if (IS_ERR (pc->clk))return PTR_ERR (pc->clk); - pc->dev = &pdev->dev;platform_set_drvdata (pdev, pc); pc->chip.dev = &pdev->dev;Signature · 1 line
1.7.10.4
otherwise,
Acked-by Shiraz Hashim <[email protected]>
Re: [PATCH 2/2] pwm: mxs: Remove unused *dev from struct spear_pwm_chip
In reply to Axel LinOn 1 April 2013 08:19, Axel Lin <[email protected]> wrote:
Apart from fixing subject you need to write something in logs too..
Quoted 24 lines
Signed-off-by Axel Lin <[email protected]>--- drivers/pwm/pwm-spear.c | 3 --- 1 file changed, 3 deletions(-)drivers/pwm/pwm-spear.c +0
-2@@ -49,13 +49,11 @@* @mmio_base: base address of pwm chip * @clk: pointer to clk structure of pwm chip * @chip: linux pwm chip representation -* @dev: pointer to device structure of pwm chip */ struct spear_pwm_chip {void __iomem *mmio_base;struct clk *clk;struct pwm_chip chip; -struct device *dev; };static inline struct spear_pwm_chip *to_spear_pwm_chip (struct pwm_chip *chip)
drivers/pwm/pwm-spear.c static int spear_pwm_probe(struct platform_device *pdev) · line 203
Quoted 7 lines
drivers/pwm/pwm-spear.c +0
-1@@ -200,7 +198,6 @@ static int spear_pwm_probe(struct platform_device *pdev)if (IS_ERR (pc->clk))return PTR_ERR (pc->clk); - pc->dev = &pdev->dev;platform_set_drvdata (pdev, pc); pc->chip.dev = &pdev->dev;
Acked-by Viresh Kumar <[email protected]>
Quoted 1 line · Axel Lin
Signed-off-by Axel Lin <[email protected]>
Acked-by Shawn Guo <[email protected]>
Quoted 29 lines
--- drivers/pwm/pwm-mxs.c | 2 -- 1 file changed, 2 deletions(-)drivers/pwm/pwm-mxs.c +0
-2@@ -38,7 +38,6 @@struct mxs_pwm_chip {struct pwm_chip chip; -struct device *dev;struct clk *clk;void __iomem *base; };@@ -166,7 +165,6 @@ static int mxs_pwm_probe(struct platform_device *pdev)return ret; } - mxs->dev = &pdev->dev;platform_set_drvdata (pdev, mxs);stmp_reset_block (mxs->base);Signature · 1 line
1.7.10.4
Quoted 4 lines · Axel Lin
Signed-off-by Axel Lin <[email protected]>--- drivers/pwm/pwm-mxs.c | 2 -- 1 file changed, 2 deletions(-)
Both patches applied, thanks.
Thierry