Skip to contentSkip to conversation

ARM: imx1: mm: add call to mxc_device_init

PATCH New Gwenhael Goavec-Merou 3 participants 5 messages Mar 16, 2013 – Apr 2, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: imx1: mm: add call to mxc_device_init

mxc_device_init() is mandatory for mxc_aips and mxc_ahb bus registration, needed as parents, at least, for gpio and dma.

---
 arch/arm/mach-imx/mm-imx1.c | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/mach-imx/mm-imx1.c +2 -0
index 7a14667..3c609c5 100644
@@ -51,6 +51,8 @@ void __init mx1_init_irq(void)
 
 void __init imx1_soc_init(void)
 {
+	mxc_device_init();
+
 	mxc_register_gpio("imx1-gpio", 0, MX1_GPIO1_BASE_ADDR, SZ_256,
 						MX1_GPIO_INT_PORTA, 0);
 	mxc_register_gpio("imx1-gpio", 1, MX1_GPIO2_BASE_ADDR, SZ_256,
Signature · 1 line
1.8.1.5
#1 lore raw

PATCH 1/1 ARM: imx1: mm: add call to mxc_device_init

Ping?
Gwenhael

Quoted 30 lines · On Sat, 16 Mar 2013 16:49:59 +0100 Gwenhael Goavec-Merou…

mxc_device_init() is mandatory for mxc_aips and mxc_ahb bus registration, needed as parents, at least, for gpio and dma.

---
 arch/arm/mach-imx/mm-imx1.c | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/mach-imx/mm-imx1.c +2 -0
index 7a14667..3c609c5 100644
@@ -51,6 +51,8 @@ void __init mx1_init_irq(void)
 
 void __init imx1_soc_init(void)
 {
+	mxc_device_init();
+
 	mxc_register_gpio("imx1-gpio", 0, MX1_GPIO1_BASE_ADDR, SZ_256,
 						MX1_GPIO_INT_PORTA, 0);
 	mxc_register_gpio("imx1-gpio", 1, MX1_GPIO2_BASE_ADDR, SZ_256,
Signature · 7 lines
1.8.1.5


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
maintainer Applied
#2 lore raw

PATCH 1/1 ARM: imx1: mm: add call to mxc_device_init

In reply to Gwenhael Goavec-Merou
Quoted 4 lines · Gwenhael Goavec-Merou

mxc_device_init() is mandatory for mxc_aips and mxc_ahb bus registration, needed as parents, at least, for gpio and dma.

Applied, thanks

Sascha

Quoted 21 lines
---
 arch/arm/mach-imx/mm-imx1.c | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/mach-imx/mm-imx1.c +2 -0
index 7a14667..3c609c5 100644
@@ -51,6 +51,8 @@ void __init mx1_init_irq(void)
 
 void __init imx1_soc_init(void)
 {
+	mxc_device_init();
+
 	mxc_register_gpio("imx1-gpio", 0, MX1_GPIO1_BASE_ADDR, SZ_256,
 						MX1_GPIO_INT_PORTA, 0);
 	mxc_register_gpio("imx1-gpio", 1, MX1_GPIO2_BASE_ADDR, SZ_256,
Signature · 1 line
1.8.1.5
Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#3 lore raw

PATCH 1/1 ARM: imx1: mm: add call to mxc_device_init

Sascha,

Quoted 7 lines · Sascha Hauer
Quoted 4 lines · Gwenhael Goavec-Merou

mxc_device_init() is mandatory for mxc_aips and mxc_ahb bus registration, needed as parents, at least, for gpio and dma.

Applied, thanks

I did not see this patch in those you ask me to handle. Has it been handled or just missed?

Shawn

maintainer
#4 lore raw

PATCH 1/1 ARM: imx1: mm: add call to mxc_device_init

Quoted 7 lines · Shawn Guo

Sascha,

Quoted 4 lines · Sascha Hauer
Quoted 3 lines · Gwenhael Goavec-Merou

mxc_device_init() is mandatory for mxc_aips and mxc_ahb bus registration, needed as parents, at least, for gpio and dma.

Quoted 6 lines
Quoted 3 lines
Quoted 1 line

Applied, thanks

I did not see this patch in those you ask me to handle. Has it been handled or just missed?

I seem to have lost it, although I'm pretty sure I really applied it and not just said so.

Sascha

Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |