Skip to contentSkip to conversation

OMAP5: I2C: Add I2C4 and I2C5 bases

PATCH New Lubomir Popov 2 participants 2 messages Apr 4, 2013 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 OMAP5: I2C: Add I2C4 and I2C5 bases

V2 fixes line wrap issue of the patch itself.

Need to add these base addresses in order to use I2C4 and I2C5.

---
 arch/arm/include/asm/arch-omap5/cpu.h |    2 ++
 1 file changed, 2 insertions(+)
arch/arm/include/asm/arch-omap5/cpu.h +2 -0
index 5e62013..044ab55 100644
@@ -142,6 +142,8 @@ struct watchdog {
 #define I2C_BASE1		(OMAP54XX_L4_PER_BASE + 0x70000)
 #define I2C_BASE2		(OMAP54XX_L4_PER_BASE + 0x72000)
 #define I2C_BASE3		(OMAP54XX_L4_PER_BASE + 0x60000)
+#define I2C_BASE4		(OMAP54XX_L4_PER_BASE + 0x7A000)
+#define I2C_BASE5		(OMAP54XX_L4_PER_BASE + 0x7C000)
 
 /* MUSB base */
 #define MUSB_BASE		(OMAP54XX_L4_CORE_BASE + 0xAB000)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v2 1/1 OMAP5: I2C: Add I2C4 and I2C5 bases

Quoted 15 lines · Lubomir Popov

V2 fixes line wrap issue of the patch itself.

Need to add these base addresses in order to use I2C4 and I2C5.

---
 arch/arm/include/asm/arch-omap5/cpu.h |    2 ++
 1 file changed, 2 insertions(+)
arch/arm/include/asm/arch-omap5/cpu.h +0 -0
index 5e62013..044ab55 100644

arch/arm/include/asm/arch-omap5/cpu.h struct watchdog { · line 146

Quoted 5 lines
arch/arm/include/asm/arch-omap5/cpu.h +2 -0
@@ -142,6 +142,8 @@ struct watchdog {
 #define I2C_BASE1		(OMAP54XX_L4_PER_BASE + 0x70000)
 #define I2C_BASE2		(OMAP54XX_L4_PER_BASE + 0x72000)
 #define I2C_BASE3		(OMAP54XX_L4_PER_BASE + 0x60000)
+#define I2C_BASE4		(OMAP54XX_L4_PER_BASE + 0x7A000)
+#define I2C_BASE5		(OMAP54XX_L4_PER_BASE + 0x7C000)

and used where.

Also could you repost the patches generated with
git format-patch -M -o someplace --cover-letter master..
so that the patches are numbered in the order that needs to be reviewed.

in general, if you introduce an macro, you need to use the macro in the same patch. So, it seems to me that a few of your patches are supposed to be squashed into a single one which enables i2c5 for omap5 as an single patch.

Quoted 9 lines
arch/arm/include/asm/arch-omap5/cpu.h +0 -0
 /* MUSB base */
 #define MUSB_BASE		(OMAP54XX_L4_CORE_BASE + 0xAB000)
Signature · 5 lines
1.7.9.5
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Signature · 2 lines
Regards,
Nishanth Menon