Skip to contentSkip to conversation

OMAP4: Add ID for OMAP4470_ES1_0

PATCH Superseded Lubomir Popov 3 participants 6 messages Apr 4, 2013 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 OMAP4: Add ID for OMAP4470_ES1_0

V2 fixes garbled subject.

---
 arch/arm/include/asm/omap_common.h   |    1 +
 1 file changed, 1 insertion(+)
arch/arm/include/asm/omap_common.h +1 -0
index 091ddb5..f042c10 100644
@@ -573,6 +573,7 @@ static inline u32 omap_revision(void)
 #define OMAP4430_ES2_3	0x44300230
 #define OMAP4460_ES1_0	0x44600100
 #define OMAP4460_ES1_1	0x44600110
+#define OMAP4470_ES1_0	0x44700100
 
 /* omap5 */
 #define OMAP5430_SILICON_ID_INVALID	0
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v2 1/1 OMAP4: Add ID for OMAP4470_ES1_0

Quoted 1 line · Lubomir Popov

V2 fixes garbled subject.

move this to diffstat section - here and in the rest of the patches.

Quoted 12 lines
---
 arch/arm/include/asm/omap_common.h   |    1 +
 1 file changed, 1 insertion(+)
arch/arm/include/asm/omap_common.h +0 -0
index 091ddb5..f042c10 100644

arch/arm/include/asm/omap_common.h static inline u32 omap_revision(void) · line 576

Quoted 4 lines
arch/arm/include/asm/omap_common.h +1 -0
@@ -573,6 +573,7 @@ static inline u32 omap_revision(void)
 #define OMAP4430_ES2_3	0x44300230
 #define OMAP4460_ES1_0	0x44600100
 #define OMAP4460_ES1_1	0x44600110
+#define OMAP4470_ES1_0	0x44700100

and used where? we do not support 4470 in u-boot today, and to my knowledge, there is no plans to do it either.

Quoted 9 lines
arch/arm/include/asm/omap_common.h +0 -0
 /* omap5 */
 #define OMAP5430_SILICON_ID_INVALID	0
Signature · 5 lines
1.7.9.5
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Signature · 2 lines
Regards,
Nishanth Menon
#2 lore raw

PATCH v2 1/1 OMAP4: Add ID for OMAP4470_ES1_0

Hello,

Quoted 10 lines · Nishanth Menon
Quoted 1 line · Lubomir Popov

V2 fixes garbled subject.

move this to diffstat section - here and in the rest of the patches.

Quoted 7 lines
---
 arch/arm/include/asm/omap_common.h   |    1 +
 1 file changed, 1 insertion(+)
Quoted 11 lines

arch/arm/include/asm/omap_common.h static inline u32 omap_revision(void) · line 576

Quoted 9 lines
arch/arm/include/asm/omap_common.h +1 -0
index 091ddb5..f042c10 100644
@@ -573,6 +573,7 @@ static inline u32 omap_revision(void)
 #define OMAP4430_ES2_3	0x44300230
 #define OMAP4460_ES1_0	0x44600100
 #define OMAP4460_ES1_1	0x44600110
+#define OMAP4470_ES1_0	0x44700100

and used where? we do not support 4470 in u-boot today, and to my knowledge, there is no plans to do it either.

Used on a custom MMS board that I'm working upon; it is up and running U-Boot with a TI 750-2173 processor card, including USB EHCI (including HSIC devices). Please see patch 233501 on my (very initial) 4470/6032 support.

If interested, I can post the board files as well.

Quoted 10 lines
Quoted 9 lines
arch/arm/include/asm/omap_common.h +0 -0
 /* omap5 */
 #define OMAP5430_SILICON_ID_INVALID	0
Signature · 5 lines
1.7.9.5
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Regards,
Lubomir

#3 lore raw

PATCH v2 1/1 OMAP4: Add ID for OMAP4470_ES1_0

Quoted 25 lines · Lubomir Popov

Hello,

Quoted 10 lines · Nishanth Menon
Quoted 1 line · Lubomir Popov

V2 fixes garbled subject.

move this to diffstat section - here and in the rest of the patches.

Quoted 7 lines
---
 arch/arm/include/asm/omap_common.h   |    1 +
 1 file changed, 1 insertion(+)
Quoted 11 lines

arch/arm/include/asm/omap_common.h static inline u32 omap_revision(void) · line 576

Quoted 9 lines
arch/arm/include/asm/omap_common.h +1 -0
index 091ddb5..f042c10 100644
@@ -573,6 +573,7 @@ static inline u32 omap_revision(void)
 #define OMAP4430_ES2_3	0x44300230
 #define OMAP4460_ES1_0	0x44600100
 #define OMAP4460_ES1_1	0x44600110
+#define OMAP4470_ES1_0	0x44700100

and used where? we do not support 4470 in u-boot today, and to my knowledge, there is no plans to do it either.

Quoted 5 lines

Used on a custom MMS board that I'm working upon; it is up and running U-Boot with a TI 750-2173 processor card, including USB EHCI (including HSIC devices). Please see patch 233501 on my (very initial) 4470/6032 support.

If interested, I can post the board files as well.

there is no u-boot support for 4470

$ git branch -v
  * master         c814263 Prepare v2013.04-rc2
$ git grep 4470 .|grep OMAP
$

What is the point in having board files for an SoC that is not supported in upstream?? My suggestion is that you either provide and maintain support for the SoC upstream (considering that inside TI, there seems be to no known motivation to do so) and introduce your board file, OR maintain this patch in the u-boot fork for the vendor board.

Signature · 2 lines
Regards,
Nishanth Menon
#4 lore raw

PATCH v2 1/1 OMAP4: Add ID for OMAP4470_ES1_0

Quoted 37 lines · Nishanth Menon
Quoted 25 lines · Lubomir Popov

Hello,

Quoted 10 lines · Nishanth Menon
Quoted 1 line · Lubomir Popov

V2 fixes garbled subject.

move this to diffstat section - here and in the rest of the patches.

Quoted 7 lines
---
 arch/arm/include/asm/omap_common.h   |    1 +
 1 file changed, 1 insertion(+)
Quoted 11 lines

arch/arm/include/asm/omap_common.h static inline u32 omap_revision(void) · line 576

Quoted 9 lines
arch/arm/include/asm/omap_common.h +1 -0
index 091ddb5..f042c10 100644
@@ -573,6 +573,7 @@ static inline u32 omap_revision(void)
 #define OMAP4430_ES2_3	0x44300230
 #define OMAP4460_ES1_0	0x44600100
 #define OMAP4460_ES1_1	0x44600110
+#define OMAP4470_ES1_0	0x44700100

and used where? we do not support 4470 in u-boot today, and to my knowledge, there is no plans to do it either.

Quoted 5 lines

Used on a custom MMS board that I'm working upon; it is up and running U-Boot with a TI 750-2173 processor card, including USB EHCI (including HSIC devices). Please see patch 233501 on my (very initial) 4470/6032 support.

If interested, I can post the board files as well.

there is no u-boot support for 4470

$ git branch -v
  * master         c814263 Prepare v2013.04-rc2
$ git grep 4470 .|grep OMAP
$
Quoted 5 lines

What is the point in having board files for an SoC that is not supported in upstream?? My suggestion is that you either provide and maintain support for the SoC upstream (considering that inside TI, there seems be to no known motivation to do so) and introduce your board file, OR maintain this patch in the u-boot fork for the vendor board.

Those were patchwork numbers, not git hashes :) He's posted a v1 of board support for his platform already.

Signature · 1 line
Tom
#5 lore raw

PATCH v2 1/1 OMAP4: Add ID for OMAP4470_ES1_0

Quoted 38 lines · Tom Rini
Quoted 37 lines · Nishanth Menon
Quoted 25 lines · Lubomir Popov

Hello,

Quoted 10 lines · Nishanth Menon
Quoted 1 line · Lubomir Popov

V2 fixes garbled subject.

move this to diffstat section - here and in the rest of the patches.

Quoted 7 lines
---
 arch/arm/include/asm/omap_common.h   |    1 +
 1 file changed, 1 insertion(+)
Quoted 11 lines

arch/arm/include/asm/omap_common.h static inline u32 omap_revision(void) · line 576

Quoted 9 lines
arch/arm/include/asm/omap_common.h +1 -0
index 091ddb5..f042c10 100644
@@ -573,6 +573,7 @@ static inline u32 omap_revision(void)
 #define OMAP4430_ES2_3	0x44300230
 #define OMAP4460_ES1_0	0x44600100
 #define OMAP4460_ES1_1	0x44600110
+#define OMAP4470_ES1_0	0x44700100

and used where? we do not support 4470 in u-boot today, and to my knowledge, there is no plans to do it either.

Quoted 5 lines

Used on a custom MMS board that I'm working upon; it is up and running U-Boot with a TI 750-2173 processor card, including USB EHCI (including HSIC devices). Please see patch 233501 on my (very initial) 4470/6032 support.

If interested, I can post the board files as well.

there is no u-boot support for 4470

$ git branch -v
  * master         c814263 Prepare v2013.04-rc2
$ git grep 4470 .|grep OMAP
$
Quoted 8 lines
Quoted 5 lines

What is the point in having board files for an SoC that is not supported in upstream?? My suggestion is that you either provide and maintain support for the SoC upstream (considering that inside TI, there seems be to no known motivation to do so) and introduce your board file, OR maintain this patch in the u-boot fork for the vendor board.

Those were patchwork numbers, not git hashes :) He's posted a v1 of board support for his platform already.

Aaah.. Thanks for the pointer. http://patchwork.ozlabs.org/patch/233501/
this patch does belong to that series. unfortunately, it is a bit hard to review the pedigree of an patch when it is not properly sequenced :(.

Signature · 2 lines
Regards,
Nishanth Menon