drivers/staging/silicom/bp_proc.c removal
It's all ifdefed out (on BYPASS_SUPPORT), severely bitrotten (try
to remove the ifdef and watch what happens on attempt to build) and, AFAICS, it's a duplicate of the stuff in bp_mod.c.
Is there any reason to keep it around? IOW, how about
git rm drivers/staging/silicom/bp_proc.c
git mv drivers/staging/silicom/bp{,ctl}_mod.c
ed drivers/staging/silicom/Makefile <<EOF
/bp_proc/d
wq
EOF
and if anybody needs to see what used to be there, git history is enough...
Another thing: please, check the vfs.git patches to bp_mod.c
in linux-next. I think they are safe, but I don't have the hardware to test them on...
A message that is not in the archive (sent off-list or not yet received): CAN4nR9cuvPgNK++N2=Mz3sifeuBfRtKdAEQ8m6MhcSvQVKn-Sg@mail.gmail.com
Quoted 12 lines · Puff .
No reason not to.
~~~~~~
DanielCOn Thu, Apr 4, 2013 at 12:12 PM, Al Viro <[email protected]> wrote:
It's all ifdefed out (on
BYPASS_SUPPORT), severely bitrotten (try to remove the ifdef and watch what happens on attempt to build) and, AFAICS,
it's a duplicate of the stuff inbp_mod.c.
Quoted 8 lines
Is there any reason to keep it around? IOW, how about git rm
drivers/staging/silicom/bp_proc.c
git mvdrivers/staging/silicom/bp{,ctl}_mod.c
eddrivers/staging/silicom/Makefile<<EOF
/bp_proc/d
wq
EOF
and if anybody needs to see what used to be there, git history is enough...
Ok, I'll go do that later today, thanks.
greg k-h
Quoted 1 line · Puff .
No reason not to.
Done (in vfs.git#for-next, should propagate in a few)
Quoted 4 lines · Al Viro
Quoted 1 line · Puff .
No reason not to.
Done (in vfs.git#for-next, should propagate in a few)
Thanks for doing that, you beat me to it.
greg k-h