Skip to contentSkip to conversation

CRITICAL error in v2013.04-rc2 (true and false not working)

PATCH New Pali Rohár 4 participants 13 messages Apr 4, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 CRITICAL error in v2013.04-rc2 (true and false not working)

Hello,

with this version of gcc which is default in ubuntu 12.10:

$ arm-linux-gnueabi-gcc -v
Using built-in specs.
COLLECT_GCC=arm-linux-gnueabi-gcc
COLLECT_LTO_WRAPPER=/usr/lib/gcc/arm-linux-gnueabi/4.7/lto-wrapper
Target: arm-linux-gnueabi
Configured with: ../src/configure -v --with-pkgversion='Ubuntu/Linaro 4.7.2-1ubuntu1' --with-
bugurl=file:///usr/share/doc/gcc-4.7/README.Bugs --enable-languages=c,c++,go,fortran,objc,obj-c++ --prefix=/usr --program-
suffix=-4.7 --enable-shared --enable-linker-build-id --with-system-zlib --libexecdir=/usr/lib --without-included-gettext --enable-
threads=posix --with-gxx-include-dir=/usr/arm-linux-gnueabi/include/c++/4.7.2 --libdir=/usr/lib --enable-nls --enable-
clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --enable-gnu-unique-object --disable-libitm --enable-plugin 
--enable-objc-gc --enable-multilib --disable-sjlj-exceptions --with-arch=armv5t --with-float=soft --disable-werror --enable-
checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=arm-linux-gnueabi --program-prefix=arm-linux-
gnueabi- --includedir=/usr/arm-linux-gnueabi/include --with-headers=/usr/arm-linux-gnueabi/include --with-libs=/usr/arm-linux-
gnueabi/lib
Thread model: posix
gcc version 4.7.2 (Ubuntu/Linaro 4.7.2-1ubuntu1)

u-boot "true" and "false" hush commands are copiled incorrectly in uboot v2013.04-rc2 (c8142633e169665b246352918df5b76fd243bb71)

when I run help in u-boot it show:

# help
0       - do nothing, unsuccessfully
1       - do nothing, successfully
?       - alias for 'help'
base    - print or set address offset
...

Instead "0" and "1" there should be "false" and "true" command.

This happen when stdbool.h from C99 compiler is included in cmd_test.c and then true and false macros are expanded to 1 and
0. Quick fix for this is adding #undef before U_BOOT_CMD:

common/cmd_test.c +2 -0
index d4ec186..a7ec8ac 100644
@@ -155,6 +155,7 @@ static int do_false(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	return 1;
 }
 
+#undef false
 U_BOOT_CMD(
 	false,	CONFIG_SYS_MAXARGS,	1,	do_false,
 	"do nothing, unsuccessfully",
@@ -166,6 +167,7 @@ static int do_true(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	return 0;
 }
 
+#undef true
 U_BOOT_CMD(
 	true,	CONFIG_SYS_MAXARGS,	1,	do_true,
 	"do nothing, successfully",

Without above patch and with gcc 4.7.2 it is not possible to use u-boot on Nokia RX-51, becuase it has true and false commands in preboot env.

Please fix this problem in u-boot v2013.04.

Signature · 9 lines
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130404/db5ec94e/attachment.pgp>
#1 lore raw

PATCH 1/1 CRITICAL error in v2013.04-rc2 (true and false not working)

Dear Pali Roh?r,

Quoted 6 lines · In message <201304041946.55455@pali> you wrote:

u-boot "true" and "false" hush commands are copiled incorrectly in uboot v2013.04-rc2 (c8142633e169665b246352918df5b76fd243bb71)

when I run help in u-boot it show:

Quoted 8 lines
# help
0       - do nothing, unsuccessfully
1       - do nothing, successfully
?       - alias for 'help'
base    - print or set address offset
...

Instead "0" and "1" there should be "false" and "true" command.

I confirm the problem.

York, your commit 472d546 "Consolidate bool type" is causing this issue, so I suggest you send a fix, please.

Please check for other, similar use cases.

Thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Generally speaking, there are other ways to accomplish whatever it is
that you think you need ...                               - Doug Gwyn
#2 lore raw

PATCH 1/1 CRITICAL error in v2013.04-rc2 (true and false not working)

Quoted 18 lines · Wolfgang Denk

Dear Pali Roh?r,

Quoted 6 lines · In message <201304041946.55455@pali> you wrote:

u-boot "true" and "false" hush commands are copiled incorrectly in uboot v2013.04-rc2 (c8142633e169665b246352918df5b76fd243bb71)

when I run help in u-boot it show:

Quoted 8 lines
# help
0       - do nothing, unsuccessfully
1       - do nothing, successfully
?       - alias for 'help'
base    - print or set address offset
...

Instead "0" and "1" there should be "false" and "true" command.

Quoted 8 lines

I confirm the problem.

York, your commit 472d546 "Consolidate bool type" is causing this issue, so I suggest you send a fix, please.

Please check for other, similar use cases.

Thanks.

Thanks for catching it. I am working on the fix now.

York

#3 lore raw

PATCH 1/1 CRITICAL error in v2013.04-rc2 (true and false not working)

In reply to Wolfgang Denk
Quoted 16 lines · Wolfgang Denk

Dear Pali Roh?r,

Quoted 13 lines · In message <201304041946.55455@pali> you wrote:

u-boot "true" and "false" hush commands are copiled incorrectly in uboot v2013.04-rc2 (c8142633e169665b246352918df5b76fd243bb71)

when I run help in u-boot it show:

# help
0       - do nothing, unsuccessfully
1       - do nothing, successfully
?       - alias for 'help'
base    - print or set address offset
...
Quoted 10 lines
Quoted 1 line

Instead "0" and "1" there should be "false" and "true" command.

I confirm the problem.

York, your commit 472d546 "Consolidate bool type" is causing this issue, so I suggest you send a fix, please.

Please check for other, similar use cases.

I found the cause but I don't know the best fix. Please help.

This is cause by common/cmd_test.c. It has command "true" and "false". Shall I undef true and false before the U_BOOT_CMD in this file, or use True and False as the names? If there is a better way to do that, please enlighten me.

York

#4 lore raw

PATCH 1/1 CRITICAL error in v2013.04-rc2 (true and false not working)

Quoted 27 lines · On Thursday 04 April 2013 23:05:18 York Sun wrote:
Quoted 19 lines · Wolfgang Denk

Dear Pali Roh?r,

Quoted 13 lines · In message <201304041946.55455@pali> you wrote:

u-boot "true" and "false" hush commands are copiled incorrectly in uboot v2013.04-rc2 (c8142633e169665b246352918df5b76fd243bb71)

when I run help in u-boot it show:

# help
0       - do nothing, unsuccessfully
1       - do nothing, successfully
?       - alias for 'help'
base    - print or set address offset
...
Quoted 2 lines

Instead "0" and "1" there should be "false" and "true" command.

Quoted 6 lines

I confirm the problem.

York, your commit 472d546 "Consolidate bool type" is causing this issue, so I suggest you send a fix, please.

Please check for other, similar use cases.

Quoted 8 lines

I found the cause but I don't know the best fix. Please help.

This is cause by common/cmd_test.c. It has command "true" and "false". Shall I undef true and false before the U_BOOT_CMD in this file, or use True and False as the names? If there is a better way to do that, please enlighten me.

York

If you rename commands "true" and "false" to "True" and "False" you will break all code which using it. Now RX-51 board do not booting due to missing "true" and "false" commands...

Signature · 9 lines
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130404/c3b3b8e6/attachment-0001.pgp>
#5 lore raw

PATCH 1/1 CRITICAL error in v2013.04-rc2 (true and false not working)

Quoted 35 lines · Pali Roh?r
Quoted 34 lines · On Thursday 04 April 2013 23:05:18 York Sun wrote:
Quoted 19 lines · Wolfgang Denk

Dear Pali Roh?r,

Quoted 13 lines · In message <201304041946.55455@pali> you wrote:

u-boot "true" and "false" hush commands are copiled incorrectly in uboot v2013.04-rc2 (c8142633e169665b246352918df5b76fd243bb71)

when I run help in u-boot it show:

# help
0       - do nothing, unsuccessfully
1       - do nothing, successfully
?       - alias for 'help'
base    - print or set address offset
...
Quoted 2 lines

Instead "0" and "1" there should be "false" and "true" command.

Quoted 6 lines

I confirm the problem.

York, your commit 472d546 "Consolidate bool type" is causing this issue, so I suggest you send a fix, please.

Please check for other, similar use cases.

I found the cause but I don't know the best fix. Please help.

This is cause by common/cmd_test.c. It has command "true" and "false". Shall I undef true and false before the U_BOOT_CMD in this file, or use True and False as the names? If there is a better way to do that, please enlighten me.

Quoted 6 lines
Quoted 1 line

York

If you rename commands "true" and "false" to "True" and "False" you will break all code which using it. Now RX-51 board do not booting due to missing "true" and "false" commands...

Would this fix be acceptable?

common/cmd_test.c +0 -0
index d4ec186..2ce3d3d 100644
@@ -155,6 +155,10 @@ static int do_false(cmd_tbl_t *cmdtp, int flag, int

argc, char * const argv[])

        return 1;

}

+#ifdef true
+#undef true
+#undef false
+
U_BOOT_CMD(
false, CONFIG_SYS_MAXARGS, 1, do_false,
"do nothing, unsuccessfully",
@@ -171,3 +175,5 @@ U_BOOT_CMD(
"do nothing, successfully",
NULL
);
+
+#endif

York

#6 lore raw

PATCH 1/1 CRITICAL error in v2013.04-rc2 (true and false not working)

Quoted 70 lines · On Thursday 04 April 2013 23:21:22 York Sun wrote:
Quoted 37 lines · Pali Roh?r
Quoted 36 lines · On Thursday 04 April 2013 23:05:18 York Sun wrote:
Quoted 19 lines · Wolfgang Denk

Dear Pali Roh?r,

Quoted 13 lines · In message <201304041946.55455@pali> you wrote:

u-boot "true" and "false" hush commands are copiled incorrectly in uboot v2013.04-rc2 (c8142633e169665b246352918df5b76fd243bb71)

when I run help in u-boot it show:

# help
0       - do nothing, unsuccessfully
1       - do nothing, successfully
?       - alias for 'help'
base    - print or set address offset
...
Quoted 2 lines

Instead "0" and "1" there should be "false" and "true" command.

Quoted 6 lines

I confirm the problem.

York, your commit 472d546 "Consolidate bool type" is causing this issue, so I suggest you send a fix, please.

Please check for other, similar use cases.

I found the cause but I don't know the best fix. Please help.

This is cause by common/cmd_test.c. It has command "true" and "false". Shall I undef true and false before the U_BOOT_CMD in this file, or use True and False as the names? If there is a better way to do that, please enlighten me.

Quoted 6 lines
Quoted 1 line

York

If you rename commands "true" and "false" to "True" and "False" you will break all code which using it. Now RX-51 board do not booting due to missing "true" and "false" commands...

Would this fix be acceptable?

common/cmd_test.c +4 -0
index d4ec186..2ce3d3d 100644
@@ -155,6 +155,10 @@ static int do_false(cmd_tbl_t *cmdtp, int
 flag, int argc, char * const argv[])
        return 1;
 }
 
+#ifdef true
+#undef true
+#undef false
+
 U_BOOT_CMD(
        false,  CONFIG_SYS_MAXARGS,     1,      do_false,

"do nothing, unsuccessfully",

common/cmd_test.c +2 -0
@@ -171,3 +175,5 @@ U_BOOT_CMD(
        "do nothing, successfully",
        NULL
 );
+
+#endif
Quoted 1 line

York

I already proposed patch in first email:
http://lists.denx.de/pipermail/u-boot/2013-April/151009.html

Adding #undef true and #undef false fixing this problem.

Signature · 9 lines
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130404/4d23e139/attachment.pgp>
#7 lore raw

PATCH 1/1 CRITICAL error in v2013.04-rc2 (true and false not working)

Quoted 71 lines · Pali Roh?r
Quoted 70 lines · On Thursday 04 April 2013 23:21:22 York Sun wrote:
Quoted 37 lines · Pali Roh?r
Quoted 36 lines · On Thursday 04 April 2013 23:05:18 York Sun wrote:
Quoted 19 lines · Wolfgang Denk

Dear Pali Roh?r,

Quoted 13 lines · In message <201304041946.55455@pali> you wrote:

u-boot "true" and "false" hush commands are copiled incorrectly in uboot v2013.04-rc2 (c8142633e169665b246352918df5b76fd243bb71)

when I run help in u-boot it show:

# help
0       - do nothing, unsuccessfully
1       - do nothing, successfully
?       - alias for 'help'
base    - print or set address offset
...
Quoted 2 lines

Instead "0" and "1" there should be "false" and "true" command.

Quoted 6 lines

I confirm the problem.

York, your commit 472d546 "Consolidate bool type" is causing this issue, so I suggest you send a fix, please.

Please check for other, similar use cases.

I found the cause but I don't know the best fix. Please help.

This is cause by common/cmd_test.c. It has command "true" and "false". Shall I undef true and false before the U_BOOT_CMD in this file, or use True and False as the names? If there is a better way to do that, please enlighten me.

Quoted 6 lines
Quoted 1 line

York

If you rename commands "true" and "false" to "True" and "False" you will break all code which using it. Now RX-51 board do not booting due to missing "true" and "false" commands...

Would this fix be acceptable?

common/cmd_test.c +4 -0
index d4ec186..2ce3d3d 100644
@@ -155,6 +155,10 @@ static int do_false(cmd_tbl_t *cmdtp, int
 flag, int argc, char * const argv[])
        return 1;
 }
 
+#ifdef true
+#undef true
+#undef false
+
 U_BOOT_CMD(
        false,  CONFIG_SYS_MAXARGS,     1,      do_false,

"do nothing, unsuccessfully",

common/cmd_test.c +2 -0
@@ -171,3 +175,5 @@ U_BOOT_CMD(
        "do nothing, successfully",
        NULL
 );
+
+#endif
Quoted 7 lines
Quoted 1 line

York

I already proposed patch in first email:
http://lists.denx.de/pipermail/u-boot/2013-April/151009.html

Adding #undef true and #undef false fixing this problem.

Thanks, Pali.

Wolfgang, shall we change U_BOOT_CMD to take string instead of stringifying or use the local undef?

York

#8 lore raw

PATCH 1/1 CRITICAL error in v2013.04-rc2 (true and false not working)

Dear York,

Quoted 3 lines · In message <[email protected]> you wrote:

Wolfgang, shall we change U_BOOT_CMD to take string instead of stringifying or use the local undef?

I tend to prefer Pali Rohar's fix.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Ernest asks Frank how long he has been working for the company.
        "Ever since they threatened to fire me."
#9 lore raw

PATCH 1/1 CRITICAL error in v2013.04-rc2 (true and false not working)

Quoted 9 lines · Wolfgang Denk

Dear York,

Quoted 3 lines · In message <[email protected]> you wrote:

Wolfgang, shall we change U_BOOT_CMD to take string instead of stringifying or use the local undef?

I tend to prefer Pali Rohar's fix.

I sent out two fixes. No strong feeling of either one.

York

#10 lore raw

PATCH 1/1 CRITICAL error in v2013.04-rc2 (true and false not working)

In reply to York Sun

Dear York Sun,

Quoted 2 lines · In message <[email protected]> you wrote:

Would this fix be acceptable?

No...

Review U_BOOT_CMD( · line 179

Quoted 13 lines
(quoted diff) +6 -0
+#ifdef true
+#undef true
+#undef false
+
 U_BOOT_CMD(
        false,  CONFIG_SYS_MAXARGS,     1,      do_false,
        "do nothing, unsuccessfully",
@@ -171,3 +175,5 @@ U_BOOT_CMD(
        "do nothing, successfully",
        NULL
 );
+
+#endif

... as it would completely remove the command entries if "true" was not defined.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A right is not what someone gives you; it's what no one can take from
you.                                                   - Ramsey Clark
#11 lore raw

PATCH 1/1 CRITICAL error in v2013.04-rc2 (true and false not working)

Quoted 8 lines · Wolfgang Denk

Dear York Sun,

Quoted 2 lines · In message <[email protected]> you wrote:

Would this fix be acceptable?

No...

Quoted 17 lines

Review U_BOOT_CMD( · line 179

Quoted 13 lines
(quoted diff) +6 -0
+#ifdef true
+#undef true
+#undef false
+
 U_BOOT_CMD(
        false,  CONFIG_SYS_MAXARGS,     1,      do_false,
        "do nothing, unsuccessfully",
@@ -171,3 +175,5 @@ U_BOOT_CMD(
        "do nothing, successfully",
        NULL
 );
+
+#endif

... as it would completely remove the command entries if "true" was not defined.

Right. I will go with Tom's suggestion.

York

#12 lore raw

PATCH 1/1 CRITICAL error in v2013.04-rc2 (true and false not working)

In reply to York Sun

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 27 lines · York Sun
Quoted 17 lines · Wolfgang Denk

Dear Pali Roh?r,

Quoted 5 lines · In message <201304041946.55455@pali> you wrote:

u-boot "true" and "false" hush commands are copiled incorrectly in uboot v2013.04-rc2 (c8142633e169665b246352918df5b76fd243bb71)

Quoted 8 lines

when I run help in u-boot it show:

# help 0       - do nothing, unsuccessfully 1       - do 
nothing, successfully ?       - alias for 'help' base    - 
print or set address offset ...

Instead "0" and "1" there should be "false" and "true" command.

Quoted 8 lines

I confirm the problem.

York, your commit 472d546 "Consolidate bool type" is causing this issue, so I suggest you send a fix, please.

Please check for other, similar use cases.

Quoted 6 lines

I found the cause but I don't know the best fix. Please help.

This is cause by common/cmd_test.c. It has command "true" and "false". Shall I undef true and false before the U_BOOT_CMD in this file, or use True and False as the names? If there is a better way to do that, please enlighten me.

The problem is with how U_BOOT_CMD is constructed. We pass in the command name as the first arg, but don't stringify it until some levels later. I can't think of a better work-around than #define _STDBOOL_H at the top, with a big fat comment.

- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJRXfKZAAoJENk4IS6UOR1Wn2oP/RpQll6j7FanZr5ClwgFwerX 2ESvlkoGmrhlz5lFzk2IPXl8ZGsSVjVFdjkbPZgcXzHcYTGFNi/+wCCALp0GD7D5 G3JVQFeYPEB+3/C+d98jcsex/8wGNPdQXZI6oYhH1yXyXrbhQdVij/ieX/aTYepG iOb9hXwf2P80uNwnnoVN6b9QEfy09hWcgpv0cnfREOykRv0cEq0Ybj7PioGxiXuh RtdVK2o3K0Zw4ruLq7FNUL5vF6AUPOrqDbtlC0Hd3n0shfqEWlAjbQLvBJougLba HHvCCQe/nr6o88vJ+SCGwWIZ/xHTQf/zX064pWGCpMQKKOZEP6/pR97EL9s6Jga1 2Hb795bBeCZYuKFJhcmmIQqJ+5uCqbWBXGMoSlrZim5rWmAteYGCtBXuY2iqVbbY KJ+PO1C9vZJM3FiY0+4ctNrETTyzXyDb9k0umiZUviZBwTJX2ll2pvg/f7/7hdL/ HfAc+FiiyV3NwgL1eT0BduEfT0PyIsswFqKGbK3dTs/6d53E6Dr0S0I4OGHBT2up 1StlfuFw2jEfwNiPHnXJoYyDjjxkDP78Jb35WJB22WeNH73Zj1TtRTYA1Wagvzqs 7yE8iaUI7g2hyBk9XW8xqoHE4ziPUCvXQfunxd7C2Xy7mTyKYKXKwDWIpwj+MKmr DNezPxxDIQSjDryhUfEg
=vWhK
-----END PGP SIGNATURE-----