Skip to contentSkip to conversation

lib80211: make lib80211 can be enabled independently

PATCH NAK Wang YanQing 5 participants 7 messages Apr 4, 2013 – Apr 5, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib80211: make lib80211 can be enabled independently

Current we can only enable lib80211 by enable a driver in tree use it which will select it, but some out tree's drivers also use it, so I think it has sense to make lib80211 can be enabled independently.

A example of the out tree's drivers use lib80211 is:
hybird driver(wl) for Broadcom Corporation BCM43225 802.11b/g/n

---
 net/wireless/Kconfig | 22 +++++++++++++++++-----
 1 file changed, 17 insertions(+), 5 deletions(-)
net/wireless/Kconfig +17 -5
index 16d08b3..6e83f0a 100644
@@ -140,22 +140,34 @@ config CFG80211_WEXT
 	  extensions with cfg80211-based drivers.
 
 config LIB80211
-	tristate
+	tristate "common routines used by IEEE802.11 wireless LAN drivers"
 	default n
 	help
 	  This options enables a library of common routines used
 	  by IEEE802.11 wireless LAN drivers.
 
-	  Drivers should select this themselves if needed.
+	  Drivers could select this themselves if needed.
 
 config LIB80211_CRYPT_WEP
-	tristate
+	tristate "host-based WEP encryption implementation for lib80211"
+	depends on LIB80211
+	default n
+	---help---
+	   host-based WEP encryption implementation for lib80211
 
 config LIB80211_CRYPT_CCMP
-	tristate
+	tristate "host-based CCMP encryption implementation for lib80211"
+	depends on LIB80211
+	default n
+	---help---
+	   host-based CCMP encryption implementation for lib80211
 
 config LIB80211_CRYPT_TKIP
-	tristate
+	tristate "host-based TKIP encryption implementation for lib80211"
+	depends on LIB80211
+	default n
+	---help---
+	    host-based TKIP encryption implementation for lib80211
 
 config LIB80211_DEBUG
 	bool "lib80211 debugging messages"
Signature · 1 line
1.7.12.4.dirty
maintainer NAK
#1 lore raw
Quoted 7 lines · Wang YanQing

Current we can only enable lib80211 by enable a driver in tree use it which will select it, but some out tree's drivers also use it, so I think it has sense to make lib80211 can be enabled independently.

A example of the out tree's drivers use lib80211 is:
hybird driver(wl) for Broadcom Corporation BCM43225 802.11b/g/n

Tough luck.

NACK.

johannes

#2 lore raw
In reply to Wang YanQing

Hi Wang,

Quoted 5 lines · Wang YanQing

Current we can only enable lib80211 by enable a driver in tree use it which will select it, but some out tree's drivers also use it, so I think it has sense to make lib80211 can be enabled independently.

Just as a bit of explanation for Johannes' NACK:

1. The only reason lib80211 still exists is because a couple of in-tree drivers still use it. If this weren't the case, the code would have been removed a long time ago as it's been completely replaced by mac80211 and cfg80211. All modern drivers _must_ use mac80211 or cfg80211 without exception.
2. In general, there is no official in-kernel support for out-of-kernel drivers, regardless of quality, status or importance.
3. I believe that the in-tree brcmsmac driver already supports the Broadcom card you reference.

Thanks,

--
Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/

#3 lore raw
Quoted 11 lines · Julian Calaby

Hi Wang,

Quoted 5 lines · Wang YanQing

Current we can only enable lib80211 by enable a driver in tree use it which will select it, but some out tree's drivers also use it, so I think it has sense to make lib80211 can be enabled independently.

Just as a bit of explanation for Johannes' NACK:

Quoted 9 lines

1. The only reason lib80211 still exists is because a couple of in-tree drivers still use it. If this weren't the case, the code would have been removed a long time ago as it's been completely replaced by mac80211 and cfg80211. All modern drivers _must_ use mac80211 or cfg80211 without exception.
2. In general, there is no official in-kernel support for out-of-kernel drivers, regardless of quality, status or importance.
3. I believe that the in-tree brcmsmac driver already supports the Broadcom card you reference.

3b. If 3. is not correct, someone should endeavor to merge this out-of-tree driver into the kernel tree.

Signature · 1 line
~Randy
#4 lore raw
Quoted 23 lines · Randy Dunlap
Quoted 11 lines · Julian Calaby

Hi Wang,

Quoted 5 lines · Wang YanQing

Current we can only enable lib80211 by enable a driver in tree use it which will select it, but some out tree's drivers also use it, so I think it has sense to make lib80211 can be enabled independently.

Just as a bit of explanation for Johannes' NACK:

Quoted 9 lines

1. The only reason lib80211 still exists is because a couple of in-tree drivers still use it. If this weren't the case, the code would have been removed a long time ago as it's been completely replaced by mac80211 and cfg80211. All modern drivers _must_ use mac80211 or cfg80211 without exception.
2. In general, there is no official in-kernel support for out-of-kernel drivers, regardless of quality, status or importance.
3. I believe that the in-tree brcmsmac driver already supports the Broadcom card you reference.

Quoted 2 lines

3b. If 3. is not correct, someone should endeavor to merge this out-of-tree driver into the kernel tree.

Actually, it is correct and brcmsmac and the out-of-tree wl driver are coming from the same code base although you should not compare the two these days.

Gr. AvS

#5 lore raw
In reply to Julian Calaby
Quoted 11 lines · Julian Calaby

Just as a bit of explanation for Johannes' NACK:

1. The only reason lib80211 still exists is because a couple of in-tree drivers still use it. If this weren't the case, the code would have been removed a long time ago as it's been completely replaced by mac80211 and cfg80211. All modern drivers _must_ use mac80211 or cfg80211 without exception.
2. In general, there is no official in-kernel support for out-of-kernel drivers, regardless of quality, status or importance.
3. I believe that the in-tree brcmsmac driver already supports the Broadcom card you reference.

Hi Julian.

Thanks for your complete explanation.
I have tried in-tree brcmsmac driver and it works well, I use it to send out this email! This is wonderful, then I don't need to fix compilation errors about the old, ugly and closed wl driver for my notebook with BCM43225 802.11b/g/n every time I upgrade kernel.

Thanks Julian and all.

#6 lore raw
In reply to Julian Calaby
Quoted 9 lines · Julian Calaby

Hi Wang,

Quoted 5 lines · Wang YanQing

Current we can only enable lib80211 by enable a driver in tree use it which will select it, but some out tree's drivers also use it, so I think it has sense to make lib80211 can be enabled independently.

Quoted 4 lines

Just as a bit of explanation for Johannes' NACK:

3. I believe that the in-tree brcmsmac driver already supports the Broadcom card you reference.

That is correct.

Gr. AvS