Skip to contentSkip to conversation

Staging: Android: looping issue, need break when get value firstly.

PATCH Greg KH 3 participants 8 messages Apr 5, 2013 – Apr 6, 2013 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Greg KH

author
#1 lore raw
Quoted 6 lines · Chen Gang

need break when 'target_thread' get value, firstly.

'tmp' is a stack (thread->transaction_stack),
if 'proc' was the same between child node and parent node, the child would have higher priority than parent.

Are you sure about this?

have you tested it?

greg k-h

#2 lore raw
Quoted 4 lines · Greg KH
Quoted 3 lines · Chen Gang

need break when 'target_thread' get value, firstly.

Quoted 8 lines
Quoted 3 lines

'tmp' is a stack (thread->transaction_stack),
if 'proc' was the same between child node and parent node, the child would have higher priority than parent.

Are you sure about this?

have you tested it?

Theoretically this should not change the behavior. The purpose of this code it to make sure only thread per process is part of a transaction stack, so if it finds more than one transaction with a matching process, they should all point to the same thread object. I think a better change description is needed though.

--
Arve Hjønnevåg

#3 lore raw
Quoted 11 lines · Arve Hjønnevåg
Quoted 10 lines · Greg KH
Quoted 10 lines · Chen Gang
Quoted 6 lines
Quoted 6 lines

need break when 'target_thread' get value, firstly.

'tmp' is a stack (thread->transaction_stack),
if 'proc' was the same between child node and parent node, the child would have higher priority than parent.

Are you sure about this?

Quoted 7 lines
Quoted 2 lines
Quoted 2 lines

have you tested it?

Theoretically this should not change the behavior. The purpose of this code it to make sure only thread per process is part of a transaction stack, so if it finds more than one transaction with a matching process, they should all point to the same thread object. I think a better change description is needed though.

ok, thanks.
I will send patch v2 (also mark you as Signed-off).
(if the patch v2 still need improvement, please reply in time).

thanks.

:-)

Signature · 3 lines
Chen Gang

Asianux Corporation
#4 lore raw
Quoted 7 lines · Chen Gang
Quoted 5 lines · Arve Hjønnevåg

Theoretically this should not change the behavior. The purpose of this code it to make sure only thread per process is part of a transaction stack, so if it finds more than one transaction with a matching process, they should all point to the same thread object. I think a better change description is needed though.

oh, sorry, I forgot to be sure one thing before send patch v2.
(the reason maybe is my English is not quite well)

I guess what your meaning is:
in this condition:
one thread is related with one process. also one process is related with one thread.

is it correct ?

thanks.

Quoted 10 lines

ok, thanks.
I will send patch v2 (also mark you as Signed-off).
(if the patch v2 still need improvement, please reply in time).

thanks.

:-)

Signature · 3 lines
Chen Gang

Asianux Corporation
author
#5 lore raw
In reply to Chen Gang
Quoted 21 lines · Chen Gang
Quoted 11 lines · Arve Hjønnevåg
Quoted 10 lines · Greg KH
Quoted 10 lines · Chen Gang
Quoted 6 lines
Quoted 6 lines

need break when 'target_thread' get value, firstly.

'tmp' is a stack (thread->transaction_stack),
if 'proc' was the same between child node and parent node, the child would have higher priority than parent.

Are you sure about this?

Quoted 7 lines
Quoted 2 lines
Quoted 2 lines

have you tested it?

Theoretically this should not change the behavior. The purpose of this code it to make sure only thread per process is part of a transaction stack, so if it finds more than one transaction with a matching process, they should all point to the same thread object. I think a better change description is needed though.

Quoted 2 lines

ok, thanks.
I will send patch v2 (also mark you as Signed-off).

You can NEVER add someone else's "Signed-off-by", unless they actually do it (hint, that did not happen here at all.)

Please go read Documentation/SubmittingPatches again to learn exactly what Signed-off-by: really is (a legal agreement), it is not something to throw around lightly like this.

Quoted 1 line

(if the patch v2 still need improvement, please reply in time).

In time for what?

Please test these patches before you resend them.

greg k-h

#6 lore raw
Quoted 27 lines · Greg KH
Quoted 21 lines · Chen Gang
Quoted 21 lines · Arve Hjønnevåg
Quoted 18 lines
Quoted 18 lines · Greg KH
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines · Chen Gang
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

need break when 'target_thread' get value, firstly.

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

'tmp' is a stack (thread->transaction_stack),
if 'proc' was the same between child node and parent node,
the child would have higher priority than parent.

Are you sure about this?

have you tested it?

Theoretically this should not change the behavior. The purpose of this code it to make sure only thread per process is part of a transaction stack, so if it finds more than one transaction with a matching process, they should all point to the same thread object. I think a better change description is needed though.

Quoted 2 lines
Quoted 2 lines

ok, thanks.
I will send patch v2 (also mark you as Signed-off).

You can NEVER add someone else's "Signed-off-by", unless they actually do it (hint, that did not happen here at all.)

Quoted 7 lines

Please go read Documentation/SubmittingPatches again to learn exactly what Signed-off-by: really is (a legal agreement), it is not something to throw around lightly like this.

Quoted 1 line
Quoted 1 line

(if the patch v2 still need improvement, please reply in time).

In time for what?

ok, thanks.

Quoted 2 lines

Please test these patches before you resend them.

ok, thanks, I will try to find ways to test it.

Quoted 3 lines

greg k-h

Signature · 3 lines
Chen Gang

Asianux Corporation
#7 lore raw
In reply to Arve Hjønnevåg
Quoted 5 lines · On 2013年04月06日 07:48, � wrote:

Theoretically this should not change the behavior. The purpose of this code it to make sure only thread per process is part of a transaction stack, so if it finds more than one transaction with a matching process, they should all point to the same thread object. I think a better change description is needed though.

after reading code again, I think:
in our condition, one proc can be related with multiple threads.

can you provide more information for:
why can we be sure "they should all point to the same thread object" ?

result:
if it is an issue (can not be sure all point to the same thread object)
it seems need additional considerations for it.
what my fix seems incorrect, either.
(for its transaction processing, it seems not should obey stack rules).

else (can be sure)
my patch seems minor (only can increasing a little performance). it is not quite suitable to spend much time to test a minor patch !!

so whether what will happen, my patch seems obsoleted !!

:-(

Signature · 3 lines
Chen Gang

Asianux Corporation
#8 lore raw
In reply to Greg KH
Quoted 8 lines · Greg KH
Quoted 6 lines · Chen Gang

need break when 'target_thread' get value, firstly.

'tmp' is a stack (thread->transaction_stack),
if 'proc' was the same between child node and parent node, the child would have higher priority than parent.

Quoted 7 lines

Are you sure about this?

have you tested it?

greg k-h

excuse me, I have not tested it.

I find it only by reading code.
I want to discuss it with related members.
(although I use [PATCH] title instead of [Suggestion] title)

if what I have done is not quite suitable, please provide suggestions.

thanks.

Signature · 3 lines
Chen Gang

Asianux Corporation