Skip to contentSkip to conversation

ARM: makefile: add tuning options for Armada 370/XP

PATCH New Willy Tarreau 3 participants 4 messages Apr 6, 2013 – Apr 8, 2013 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: makefile: add tuning options for Armada 370/XP

Hi,

A patch from Marvell was merged in GCC 4.8 to add support for their PJ4 CPU core used in Armada370 and XP. I noticed a steady 2% network performance increase using -mcpu=marvell-pj4 and around 1% when using -mtune=xscale instead. I have no idea whether it provides anything to the Dove platform and I don't have one to test, so I didn't touch it.

Now that 4.8 is released, it would be nice to have this option used when supported.

Regards,
Willy

Quoted 1 line

From b5b34f87e753fbd756f3c23536e731bb1aa6bf7f Mon Sep 17 00:00:00 2001

From: Willy Tarreau <[email protected]>
Date: Sun, 3 Mar 2013 23:26:41 +0100
Subject: [PATCH] ARM: makefile: add tuning options for Armada 370/XP

Let's pass -mcpu=marvell-pj4 and fall back to -mtune=xscale for Armada370 and ArmadaXP. Both settings have shown an improvement over the default setting on these chips using gcc-4.7 with and without the Marvell patch (typically 2% on network traffic).

---
 arch/arm/Makefile | 1 +
 1 file changed, 1 insertion(+)
arch/arm/Makefile +1 -0
index 15747d9..7dd5418 100644
@@ -93,6 +93,7 @@ tune-$(CONFIG_CPU_XSC3)		:=$(call cc-option,-mtune=xscale,-mtune=strongarm110) -
 tune-$(CONFIG_CPU_FEROCEON)	:=$(call cc-option,-mtune=marvell-f,-mtune=xscale)
 tune-$(CONFIG_CPU_V6)		:=$(call cc-option,-mtune=arm1136j-s,-mtune=strongarm)
 tune-$(CONFIG_CPU_V6K)		:=$(call cc-option,-mtune=arm1136j-s,-mtune=strongarm)
+tune-$(CONFIG_MACH_ARMADA_370_XP)	:=$(call cc-option,-mcpu=marvell-pj4,-mtune=xscale)
 
 ifeq ($(CONFIG_AEABI),y)
 CFLAGS_ABI	:=-mabi=aapcs-linux -mno-thumb-interwork
Signature · 1 line
1.7.12.2.21.g234cd45.dirty
#1 lore raw

PATCH 1/1 ARM: makefile: add tuning options for Armada 370/XP

Hi Willy,

Quoted 10 lines · Willy Tarreau

Hi,

A patch from Marvell was merged in GCC 4.8 to add support for their PJ4 CPU core used in Armada370 and XP. I noticed a steady 2% network performance increase using -mcpu=marvell-pj4 and around 1% when using -mtune=xscale instead. I have no idea whether it provides anything to the Dove platform and I don't have one to test, so I didn't touch it.

Now that 4.8 is released, it would be nice to have this option used when supported.

Sure it will be very nice! But what happens when the kernel is built in multiarch?
It seems to me that in this case gcc will tune the code for PJ4 whereas the kernel built can also be run on a Cortex-A, a Scorpion or a Krait.

Regards,

Quoted 32 lines

Regards,
Willy

From b5b34f87e753fbd756f3c23536e731bb1aa6bf7f Mon Sep 17 00:00:00 2001
From: Willy Tarreau <[email protected]>
Date: Sun, 3 Mar 2013 23:26:41 +0100
Subject: [PATCH] ARM: makefile: add tuning options for Armada 370/XP

Let's pass -mcpu=marvell-pj4 and fall back to -mtune=xscale for Armada370 and ArmadaXP. Both settings have shown an improvement over the default setting on these chips using gcc-4.7 with and without the Marvell patch (typically 2% on network traffic).

---
 arch/arm/Makefile | 1 +
 1 file changed, 1 insertion(+)
arch/arm/Makefile +1 -0
index 15747d9..7dd5418 100644
@@ -93,6 +93,7 @@ tune-$(CONFIG_CPU_XSC3)		:=$(call cc-option,-mtune=xscale,-mtune=strongarm110) -
 tune-$(CONFIG_CPU_FEROCEON)	:=$(call cc-option,-mtune=marvell-f,-mtune=xscale)
 tune-$(CONFIG_CPU_V6)		:=$(call cc-option,-mtune=arm1136j-s,-mtune=strongarm)
 tune-$(CONFIG_CPU_V6K)		:=$(call cc-option,-mtune=arm1136j-s,-mtune=strongarm)
+tune-$(CONFIG_MACH_ARMADA_370_XP)	:=$(call cc-option,-mcpu=marvell-pj4,-mtune=xscale)
 
 ifeq ($(CONFIG_AEABI),y)
 CFLAGS_ABI	:=-mabi=aapcs-linux -mno-thumb-interwork
Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 ARM: makefile: add tuning options for Armada 370/XP

Hi Gr?gory,

Quoted 11 lines · Gregory CLEMENT

Hi Willy,

Quoted 8 lines · Willy Tarreau

Hi,

A patch from Marvell was merged in GCC 4.8 to add support for their PJ4 CPU core used in Armada370 and XP. I noticed a steady 2% network performance increase using -mcpu=marvell-pj4 and around 1% when using -mtune=xscale instead. I have no idea whether it provides anything to the Dove platform and I don't have one to test, so I didn't touch it.

Quoted 7 lines
Quoted 2 lines

Now that 4.8 is released, it would be nice to have this option used when supported.

Sure it will be very nice! But what happens when the kernel is built in multiarch?
It seems to me that in this case gcc will tune the code for PJ4 whereas the kernel built can also be run on a Cortex-A, a Scorpion or a Krait.

I have not thought about that. Maybe we're already reaching the limits of the multiarch mode ? After all, pj4 is not a cortex-a, which probably is the reason that justifies having specific gcc optimizations that are different from cortex-a.

So in the end, I'm starting to wonder whether it makes sense to permit non-100% compatible armv7 chips to coexist in the same kernel :-/

Otherwise we could do what already exists on x86, which is to let the user select which chip he wants to optimize for. I have no idea on the subject to be honnest.

Best regards,
Willy

#3 lore raw

PATCH 1/1 ARM: makefile: add tuning options for Armada 370/XP

In reply to Willy Tarreau

arch/arm/Makefile tune-$(CONFIG_CPU_XSC3) :=$(call cc-option,-mtune=xscale,-mtune=strongarm110) - · line 96

Quoted 9 lines · Willy Tarreau
arch/arm/Makefile +1 -0
index 15747d9..7dd5418 100644
@@ -93,6 +93,7 @@ tune-$(CONFIG_CPU_XSC3)		:=$(call cc-option,-mtune=xscale,-mtune=strongarm110) -
 tune-$(CONFIG_CPU_FEROCEON)	:=$(call cc-option,-mtune=marvell-f,-mtune=xscale)
 tune-$(CONFIG_CPU_V6)		:=$(call cc-option,-mtune=arm1136j-s,-mtune=strongarm)
 tune-$(CONFIG_CPU_V6K)		:=$(call cc-option,-mtune=arm1136j-s,-mtune=strongarm)
+tune-$(CONFIG_MACH_ARMADA_370_XP)	:=$(call cc-option,-mcpu=marvell-pj4,-mtune=xscale)

Do not do this. This is not how these options work. Look at all the above - they all use -mtune=.

The reason for this is that we want to control which instructions are used (-march=) independently of how the instructions are scheduled (-mtune=).

Using -mcpu= influences both of those in an adverse way - it can enable instructions which are not present on other CPUs in the same kernel.

So, the use of -mcpu= is not permitted in the kernel. Instead, use -march= and -mtune= in an appropriate manner to achieve your goal.