new package: libqmi
PATCH 1/1 new package: libqmi
From: "Shawn J. Goff" <[email protected]>
libqmi includes a library and command line interface for interacting with modems that speak the QMI protocol.
--- package/libqmi/Config.in | 5 + .../libqmi-Add-files-created-by-autogen.patch | 29 ++ .../libqmi-Add-files-created-by-gtkdocize.patch | 309 +++++++++++++++++++++ package/libqmi/libqmi.mk | 21 ++ 4 files changed, 364 insertions(+) create mode 100644 package/libqmi/Config.in create mode 100644 package/libqmi/libqmi-Add-files-created-by-autogen.patch create mode 100644 package/libqmi/libqmi-Add-files-created-by-gtkdocize.patch create mode 100644 package/libqmi/libqmi.mk
package/libqmi/Config.in new file +5 -0
@@ -0,0 +1,5 @@ +config BR2_PACKAGE_LIBQMI + bool "libqmi" + depends on BR2_PACKAGE_LIBGLIB2 + help + libqmi is a library for interacting with devices that use Qualcomm's QMI protocol.
package/libqmi/libqmi-Add-files-created-by-autogen.patch new file +29 -0
@@ -0,0 +1,29 @@ +From 6d4db1bde5f9f0883468dbead27a41ac98430e9a Mon Sep 17 00:00:00 2001 +From: "Shawn J. Goff" <[email protected]> +Date: Wed, 26 Sep 2012 15:21:48 -0400 +Subject: [PATCH 2/2] Add files created by autogen + +--- + ChangeLog | 1 + + README | 1 + + 3 files changed, 3 insertions(+) + create mode 100644 ChangeLog + create mode 100644 README + +diff --git a/ChangeLog b/ChangeLog +new file mode 100644 +index 0000000..8b13789 +--- /dev/null ++++ b/ChangeLog +@@ -0,0 +1 @@ ++ +diff --git a/README b/README +new file mode 100644 +index 0000000..8b13789 +--- /dev/null ++++ b/README +@@ -0,0 +1 @@ ++ +-- +1.7.12 +
package/libqmi/libqmi-Add-files-created-by-gtkdocize.patch new file +309 -0
309 lines not on this page · raw message
package/libqmi/libqmi.mk new file +21 -0
@@ -0,0 +1,21 @@ +############################################################# +# +# libqmi +# +############################################################# +LIBQMI_VERSION = 9e60ef6c0f3e6ac579fb360481488c5ed00382cc +LIBQMI_SITE = git://anongit.freedesktop.org/libqmi +LIBQMI_SITE_METHOD = git +LIBQMI_AUTORECONF = YES +LIBQMI_AUTORECONF_OPT = --force --install --verbose +LIBQMI_INSTALL_STAGING = YES +LIBQMI_CONF_OPT = --with-docs=no\ + --enable-gtk-doc-html=no\ + --enable-gtk-doc=no\ + --enable-gtk-doc-pdf=no\ + --with-tests=no\ + --with-traces=no + +LIBQMI_DEPENDENCIES = libglib2 + +$(eval $(autotools-package))
Signature · 1 line
1.8.1.2
PATCH 1/1 new package: libqmi
Shawn,
Thanks a lot for your contribution. Some comments below.
Quoted 8 lines · On Sun, 17 Feb 2013 18:46:47 -0500, shawn7400 at gmail.com wrote:
From: "Shawn J. Goff" <[email protected]>
libqmi includes a library and command line interface for interacting with modems that speak the QMI protocol.
--- package/libqmi/Config.in | 5 + .../libqmi-Add-files-created-by-autogen.patch | 29 ++ .../libqmi-Add-files-created-by-gtkdocize.patch | 309 +++++++++++++++++++++
I think we prefer lower-case filenames for patches.
Quoted 1 line
package/libqmi/libqmi.mk | 21 ++
Your patch lacks the change to package/Config.in. For now, your package doesn't appear anywhere in menuconfig.
Quoted 12 lines
4 files changed, 364 insertions(+) create mode 100644 package/libqmi/Config.in create mode 100644 package/libqmi/libqmi-Add-files-created-by-autogen.patch create mode 100644 package/libqmi/libqmi-Add-files-created-by-gtkdocize.patch create mode 100644 package/libqmi/libqmi.mkpackage/libqmi/Config.in new file +0
-0
package/libqmi/Config.in line 3
Quoted 3 lines
package/libqmi/Config.in new file +3
-0@@ -0,0 +1,5 @@ +config BR2_PACKAGE_LIBQMI + bool "libqmi" + depends on BR2_PACKAGE_LIBGLIB2
This should be:
select BR2_PACKAGE_LIBGLIB2 depends on BR2_USE_WCHAR # libglib2 -> gettext
package/libqmi/Config.in line 5
Quoted 2 lines
package/libqmi/Config.in new file +2
-0+ help + libqmi is a library for interacting with devices that use Qualcomm's QMI protocol.
Indentation of the help text should be one tab plus two spaces. This line should also be wrapped at around ~72 columns. And you should add an empty new line, and the URL of the upstream project.
package/libqmi/libqmi-Add-files-created-by-autogen.patch line 5
Quoted 11 lines
package/libqmi/libqmi-Add-files-created-by-autogen.patch new file +5
-0@@ -0,0 +1,29 @@ +From 6d4db1bde5f9f0883468dbead27a41ac98430e9a Mon Sep 17 00:00:00 2001 +From: "Shawn J. Goff" <[email protected]> +Date: Wed, 26 Sep 2012 15:21:48 -0400 +Subject: [PATCH 2/2] Add files created by autogen +
I think we generally prefer a hook in POST_PATCH_HOOKS to create those files using 'touch'.
Quoted 7 lines
package/libqmi/libqmi-Add-files-created-by-gtkdocize.patch new file +1
-0@@ -0,0 +1,309 @@ +From 5fd915fb74d35bc67b007b5f7659109954daa837 Mon Sep 17 00:00:00 2001
package/libqmi/libqmi-Add-files-created-by-gtkdocize.patch line 11
Quoted 10 lines
package/libqmi/libqmi-Add-files-created-by-gtkdocize.patch new file +10
-0+From: "Shawn J. Goff" <[email protected]> +Date: Wed, 26 Sep 2012 15:20:23 -0400 +Subject: [PATCH 1/2] Add files created by gtkdocize + +--- + gtk-doc.make | 280 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ + m4/gtk-doc.m4 | 1 + + 2 files changed, 281 insertions(+) + create mode 100644 gtk-doc.make + create mode 100644 m4/gtk-doc.m4
Hum, there's really no other way? I.e the package doesn't build at all if you don't do this?
package/libqmi/libqmi.mk line 5
Quoted 11 lines
package/libqmi/libqmi.mk new file +5
-0@@ -0,0 +1,21 @@ +############################################################# +# +# libqmi +# +#############################################################
One empty new line between the header and the first variable.
package/libqmi/libqmi.mk line 6
Quoted 1 line
package/libqmi/libqmi.mk new file +1
-0+LIBQMI_VERSION = 9e60ef6c0f3e6ac579fb360481488c5ed00382cc
I see that this project has some tags for versions, the latest being 1.2.0. Any reason for using an apparently 'random' Git commit? The 1.2.0 has been tagged 3 weeks ago, so it's not very old.
package/libqmi/libqmi.mk line 8
Quoted 2 lines
package/libqmi/libqmi.mk new file +2
-0+LIBQMI_SITE = git://anongit.freedesktop.org/libqmi +LIBQMI_SITE_METHOD = git
I think the site method is not needed here since your site starts withgit://.
package/libqmi/libqmi.mk line 17
Quoted 9 lines
package/libqmi/libqmi.mk new file +9
-0+LIBQMI_AUTORECONF = YES +LIBQMI_AUTORECONF_OPT = --force --install --verbose +LIBQMI_INSTALL_STAGING = YES +LIBQMI_CONF_OPT = --with-docs=no\ + --enable-gtk-doc-html=no\ + --enable-gtk-doc=no\ + --enable-gtk-doc-pdf=no\ + --with-tests=no\ + --with-traces=no
Once space before each backslash please.
package/libqmi/libqmi.mk line 21
Quoted 3 lines
package/libqmi/libqmi.mk new file +3
-0+LIBQMI_DEPENDENCIES = libglib2 + +$(eval $(autotools-package))
It would be good to add the licensing informations:
LIBQMI_LICENSE = LGPLv2+ (library), GPLv2+ (programs) LIBQMI_LICENSE_FILES = COPYING
Thanks!
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com