Skip to contentSkip to conversation

nouveau: Fix unconditional return waiting on memory

PATCH In review Calvin Owens 3 participants 3 messages Apr 8, 2013 – Apr 9, 2013 2 messages not in the archive

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nouveau: Fix unconditional return waiting on memory

----- Forwarded message from Calvin Owens <[email protected]> -----

From: Calvin Owens <[email protected]>
To: [email protected], [email protected]
CC: Ben Skeggs <[email protected]>, Calvin Owens <[email protected]>
Date: Thu, 21 Mar 2013 13:10:12 -0500
Subject: [PATCH] nouveau: Fix unconditional return waiting on memory

Typo in nv50_display_flip_wait allows page flipping to run ahead before memory has time to settle.

---
 drivers/gpu/drm/nouveau/nv50_display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/gpu/drm/nouveau/nv50_display.c +1 -1
index 2db5799..96bc2f3 100644
@@ -479,7 +479,7 @@ nv50_display_flip_wait(void *data)
 {
 	struct nv50_display_flip *flip = data;
 	if (nouveau_bo_rd32(flip->disp->sync, flip->chan->addr / 4) ==
-					      flip->chan->data);
+					      flip->chan->data)
 		return true;
 	usleep_range(1, 2);
 	return false;
Signature · 3 lines
1.7.3.4

----- End forwarded message -----

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): CA+GA0_tm86Z7H6mGi056BhWrq2=+_69N3Xcn3HUCa_hQuB_Wqg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org

#4 lore raw
Quoted 5 lines

This is ridiculous. If such trivial bugfixes need to be reposted so many times, what does it say about the maintainer? Can we have a real one?

This isn't a trivial bugfix though, if it was I'd have just merged it

When mistakes like that happen, fixing them can sometimes end causing wierd regressions, so don't think just because it one semicolon that it has only a trivial effect or needs no testing.

Dave.