Skip to contentSkip to conversation

mfd: trivially fix build warning in sta2x11-mfd

PATCH Applied Alessandro Rubini 3 participants 3 messages Feb 22, 2013 – Apr 8, 2013 Multifunction devices (MFD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd: trivially fix build warning in sta2x11-mfd

This driver cannot be a module, so "remove" is never called. The mishap is mine, and back then there was no warning due to __devexit().

---
 drivers/mfd/sta2x11-mfd.c |   11 -----------
 1 files changed, 0 insertions(+), 11 deletions(-)
drivers/mfd/sta2x11-mfd.c +0 -11
index 9bd3316..d70a3430 100644
@@ -98,17 +98,6 @@ static int sta2x11_mfd_add(struct pci_dev *pdev, gfp_t flags)
 	return 0;
 }
 
-static int mfd_remove(struct pci_dev *pdev)
-{
-	struct sta2x11_mfd *mfd = sta2x11_mfd_find(pdev);
-
-	if (!mfd)
-		return -ENODEV;
-	list_del(&mfd->list);
-	kfree(mfd);
-	return 0;
-}
-
 /* This function is exported and is not expected to fail */
 u32 __sta2x11_mfd_mask(struct pci_dev *pdev, u32 reg, u32 mask, u32 val,
 		       enum sta2x11_mfd_plat_dev index)
Signature · 1 line
1.7.7.2
Applied
#2 lore raw
In reply to Alessandro Rubini

Hi Alessandro,

Quoted 8 lines · Alessandro Rubini

This driver cannot be a module, so "remove" is never called. The mishap is mine, and back then there was no warning due to __devexit().

---
 drivers/mfd/sta2x11-mfd.c |   11 -----------
 1 files changed, 0 insertions(+), 11 deletions(-)

Applied, thanks.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/