Skip to contentSkip to conversation

mfd: tps65090: Fix enum in header file

PATCH Applied Rhyland Klein 2 participants 5 messages Mar 21, 2013 – Apr 10, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH v4 1/2 mfd: tps65090: Fix enum in header file

The enum is missing the definition for the first bit, which makes all the rest off by one. Add definition for the TPS65090_IRQ_INTERRUPT bit which at 0.

---
v4:
- no changes since v1

 include/linux/mfd/tps65090.h |    1 +
 1 file changed, 1 insertion(+)
include/linux/mfd/tps65090.h +1 -0
index 998628a..3f43069 100644
@@ -27,6 +27,7 @@
 
 /* TPS65090 IRQs */
 enum {
+	TPS65090_IRQ_INTERRUPT,
 	TPS65090_IRQ_VAC_STATUS_CHANGE,
 	TPS65090_IRQ_VSYS_STATUS_CHANGE,
 	TPS65090_IRQ_BAT_STATUS_CHANGE,
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v4 2/2 mfd: tps65090: Add resources for charger

Add irq resources to pass to the charger mfd sub dev so the charger can listen for interrupts.

---
v4:
- Added of_compatible string to resources for tps65090-charger
v3:
- no changes since v2
v2:
- no changes since v1

 drivers/mfd/tps65090.c |   11 +++++++++++
 1 file changed, 11 insertions(+)
drivers/mfd/tps65090.c +11 -0
index 98edb5be..fbd6ee6 100644
@@ -56,12 +56,23 @@
 #define TPS65090_INT2_MASK_OVERLOAD_FET6		6
 #define TPS65090_INT2_MASK_OVERLOAD_FET7		7
 
+static struct resource charger_resources[] = {
+	{
+		.start  = TPS65090_IRQ_VAC_STATUS_CHANGE,
+		.end    = TPS65090_IRQ_VAC_STATUS_CHANGE,
+		.flags  = IORESOURCE_IRQ,
+	}
+};
+
 static struct mfd_cell tps65090s[] = {
 	{
 		.name = "tps65090-pmic",
 	},
 	{
 		.name = "tps65090-charger",
+		.num_resources = ARRAY_SIZE(charger_resources),
+		.resources = &charger_resources[0],
+		.of_compatible = "ti,tps65090-charger",
 	},
 };
 
Signature · 1 line
1.7.9.5
Applied
#2 lore raw

Re: [Patch V4 2/2] mfd: tps65090: Add resources for charger

Hi Rhyland,

Quoted 12 lines · Rhyland Klein

Add irq resources to pass to the charger mfd sub dev so the charger can listen for interrupts.

---
v4:
- Added of_compatible string to resources for tps65090-charger
v3:
- no changes since v2
v2:
- no changes since v1

Quoted 2 lines
 drivers/mfd/tps65090.c |   11 +++++++++++
 1 file changed, 11 insertions(+)

Applied as well, thanks.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/
#3 lore raw

Re: [Patch V4 2/2] mfd: tps65090: Add resources for charger

Quoted 15 lines · Samuel Ortiz

Hi Rhyland,

Quoted 12 lines · Rhyland Klein

Add irq resources to pass to the charger mfd sub dev so the charger can listen for interrupts.

---
v4:
- Added of_compatible string to resources for tps65090-charger
v3:
- no changes since v2
v2:
- no changes since v1

Quoted 7 lines
Quoted 2 lines
 drivers/mfd/tps65090.c |   11 +++++++++++
 1 file changed, 11 insertions(+)

Applied as well, thanks.

Cheers,
Samuel.

It looks like the merged version was not V4 but an earlier one. V4 added in the of_compatible string for the charger subnode and I don't see that in the version in linux-next. I guess I'll post a new patch to add that separately.

-rhyland

Signature · 1 line
nvpublic
Applied
#4 lore raw
In reply to Rhyland Klein

Hi Rhyland,

Quoted 11 lines · Rhyland Klein

The enum is missing the definition for the first bit, which makes all the rest off by one. Add definition for the TPS65090_IRQ_INTERRUPT bit which at 0.

---
v4:
- no changes since v1

 include/linux/mfd/tps65090.h |    1 +
 1 file changed, 1 insertion(+)

Applied, thanks.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/