dfu:ext4:fix: Change ext4write command order of parameters
PATCH 1/2 dfu:ext4:fix: Change ext4write command order of parameters
Following commit:
"cmd_ext4: BREAK and correct ext4write parameter order" SHA1:0171d52c410cbaa9290b1b214e695697c835bfe5
introduced cleanup of ext4write semantics to be consistent with other filesystem's writing commands (e.g. fatwrite).
This commit provides correct ext4write command generation at DFU eMMC code.
--- drivers/dfu/dfu_mmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/dfu/dfu_mmc.c +2 -2
@@ -72,10 +72,10 @@ static int mmc_file_op(enum dfu_mmc_op op, struct dfu_entity *dfu, (unsigned int) buf, dfu->name, *len);break ;case DFU_FS_EXT4 : -sprintf (cmd_buf,"ext4%s mmc %d:%d /%s 0x%x %ld" , +sprintf (cmd_buf,"ext4%s mmc %d:%d 0x%x /%s %ld" , op ==DFU_OP_READ ?"load" :"write" , dfu->data.mmc.dev, dfu->data.mmc.part, - dfu->name, (unsigned int ) buf, *len); + (unsigned int ) buf, dfu->name, *len);break ;default : printf("%s: Layout (%s) not (yet) supported!\n", __func__,
Signature · 1 line
1.7.10.4
PATCH 2/2 dfu: Increase DFU buffer size from 4MiB to 8MiB
Increase size of DMA buffer from 4MiB to 8MiB. This is necessary due to uImage size increase.
--- include/dfu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/dfu.h +1 -1
@@ -59,7 +59,7 @@ static inline unsigned int get_mmc_blk_size(int dev)#define DFU_NAME_SIZE 32#define DFU_CMD_BUF_SIZE 128 -#define DFU_DATA_BUF_SIZE (1024*1024*4)/* 4 MiB */ +#define DFU_DATA_BUF_SIZE (1024*1024*8)/* 8 MiB */ struct dfu_entity {char name[DFU_NAME_SIZE ];
Signature · 1 line
1.7.10.4
PATCH 1/2 dfu:ext4:fix: Change ext4write command order of parameters
In reply to Lukasz MajewskiQuoted 11 lines · Lukasz Majewski
Following commit:
"cmd_ext4: BREAK and correct ext4write parameter order" SHA1:0171d52c410cbaa9290b1b214e695697c835bfe5introduced cleanup of ext4write semantics to be consistent with other filesystem's writing commands (e.g. fatwrite).
This commit provides correct ext4write command generation at DFU eMMC code.Signed-off-by Lukasz Majewski <[email protected]>Signed-off-by Kyungmin Park <[email protected]>
This along with 2/2 have been applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130408/aa061d65/attachment.pgp>