Skip to contentSkip to conversation

ARM: imx: remove configs ARCH_MX5 and ARCH_MX51

PATCH New Paul Bolle 2 participants 5 messages Apr 8, 2013 – Apr 9, 2013

Subsystems (3)
lore
Share & tools
lore

Paul Bolle

author
#0 lore raw

PATCH 1/1 ARM: imx: remove configs ARCH_MX5 and ARCH_MX51

The Kconfig symbols ARCH_MX5 and ARCH_MX51 are unused since v3.3. They can safely be removed.

---
Tested with "git grep" only.

 arch/arm/mach-imx/Kconfig | 10 ----------
 1 file changed, 10 deletions(-)
arch/arm/mach-imx/Kconfig +0 -10
index 6d9ae09..cbd6942 100644
@@ -92,12 +92,6 @@ config ARCH_MX25
 config MACH_MX27
 	bool
 
-config ARCH_MX5
-	bool
-
-config ARCH_MX51
-	bool
-
 config ARCH_MX53
 	bool
 
@@ -155,7 +149,6 @@ config SOC_IMX35
 config SOC_IMX5
 	bool
 	select ARCH_HAS_CPUFREQ
-	select ARCH_MX5
 	select ARCH_MXC_IOMUX_V3
 	select COMMON_CLK
 	select CPU_V7
@@ -163,8 +156,6 @@ config SOC_IMX5
 
 config	SOC_IMX51
 	bool
-	select ARCH_MX5
-	select ARCH_MX51
 	select PINCTRL
 	select PINCTRL_IMX51
 	select SOC_IMX5
@@ -787,7 +778,6 @@ comment "Device tree only"
 
 config	SOC_IMX53
 	bool "i.MX53 support"
-	select ARCH_MX5
 	select ARCH_MX53
 	select HAVE_CAN_FLEXCAN if CAN
 	select IMX_HAVE_PLATFORM_IMX2_WDT
Signature · 1 line
1.7.11.7
maintainer
#1 lore raw

PATCH 1/1 ARM i.MX53: remove platform ahci support

The i.MX53 ahci platform support is unused in mainline. To demotivate people using it just remove it from the tree.

---

Paul, with this one applied you could also remove config ARCH_MX53.

 arch/arm/plat-mxc/devices/Kconfig               |   4 -
 arch/arm/plat-mxc/devices/Makefile              |   1 -
 arch/arm/plat-mxc/devices/platform-ahci-imx.c   | 156 ------------------------
 arch/arm/plat-mxc/include/mach/devices-common.h |  10 --
 4 files changed, 171 deletions(-)
 delete mode 100644 arch/arm/plat-mxc/devices/platform-ahci-imx.c
arch/arm/plat-mxc/devices/Kconfig +0 -4
index a35d984..02404d0 100644
@@ -83,7 +83,3 @@ config IMX_HAVE_PLATFORM_SDHCI_ESDHC_IMX
 
 config IMX_HAVE_PLATFORM_SPI_IMX
 	bool
-
-config IMX_HAVE_PLATFORM_AHCI
-	bool
-	default y if ARCH_MX53
arch/arm/plat-mxc/devices/Makefile +0 -1
index 76f3195..cd8d572 100644
@@ -27,4 +27,3 @@ obj-$(CONFIG_IMX_HAVE_PLATFORM_MXC_RTC) += platform-mxc_rtc.o
 obj-$(CONFIG_IMX_HAVE_PLATFORM_MXC_W1) += platform-mxc_w1.o
 obj-$(CONFIG_IMX_HAVE_PLATFORM_SDHCI_ESDHC_IMX) += platform-sdhci-esdhc-imx.o
 obj-$(CONFIG_IMX_HAVE_PLATFORM_SPI_IMX) +=  platform-spi_imx.o
-obj-$(CONFIG_IMX_HAVE_PLATFORM_AHCI) +=  platform-ahci-imx.o
arch/arm/plat-mxc/devices/platform-ahci-imx.c deleted +0 -156

156 lines not on this page · raw message

arch/arm/plat-mxc/include/mach/devices-common.h +0 -10
index eaf79d2..ab5f88c 100644
@@ -329,13 +329,3 @@ struct platform_device *__init imx_add_spi_imx(
 struct platform_device *imx_add_imx_dma(void);
 struct platform_device *imx_add_imx_sdma(char *name,
 	resource_size_t iobase, int irq, struct sdma_platform_data *pdata);
-
-#include <linux/ahci_platform.h>
-struct imx_ahci_imx_data {
-	const char *devid;
-	resource_size_t iobase;
-	resource_size_t irq;
-};
-struct platform_device *__init imx_add_ahci_imx(
-		const struct imx_ahci_imx_data *data,
-		const struct ahci_platform_data *pdata);
Signature · 1 line
1.8.2.rc2
author
#2 lore raw

PATCH 1/1 ARM i.MX53: remove platform ahci support

Quoted 1 line · Sascha Hauer

Paul, with this one applied you could also remove config ARCH_MX53.

Unless I'm doing something wrong, this doesn't apply onto v3.9-rc6. I guess it requires some other branch. But, assuming I don't get fed up with cleaning up Kconfig cruft, I will notice ARCH_MX53 getting unused when your patch hits mainline anyway.

But is there a reason you can't just remove ARCH_MX53 yourself?

Paul Bolle

maintainer
#3 lore raw

PATCH 1/1 ARM i.MX53: remove platform ahci support

Quoted 7 lines · Paul Bolle
Quoted 1 line · Sascha Hauer

Paul, with this one applied you could also remove config ARCH_MX53.

Unless I'm doing something wrong, this doesn't apply onto v3.9-rc6. I guess it requires some other branch. But, assuming I don't get fed up with cleaning up Kconfig cruft, I will notice ARCH_MX53 getting unused when your patch hits mainline anyway.

I wanted to say that the patch could be extended with more cleanup.

Quoted 2 lines

But is there a reason you can't just remove ARCH_MX53 yourself?

Just did that.

Sascha

Signature · 4 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
author
#4 lore raw

PATCH 1/1 ARM i.MX53: remove platform ahci support

Quoted 1 line · Sascha Hauer

I wanted to say that the patch could be extended with more cleanup.

I see. But as long as long as I can't convince myself that, say, some Kconfig symbol really is unused, it's hard for me to actually suggest the related cleaning up. Especially when I'm touching code that I know nothing about (as I do in most of the cleanups I suggest).

Paul Bolle