Skip to contentSkip to conversation

mfd: drop "select PMIC_DA9055"

PATCH In review Paul Bolle 2 participants 2 messages Mar 9, 2013 – Apr 9, 2013 Multifunction devices (MFD)

lore
Share & tools
lore

Paul Bolle

author
#0 lore raw

PATCH 1/1 mfd: drop "select PMIC_DA9055"

The Kconfig entry for DA9055 PMIC Support selects PMIC_DA9055. That was probably inspired by the similar select statement in the entry for DA9052/53 PMIC with I2C. But the DA9055 PMIC only comes in an I2C variant and its driver doesn't need a separate Kconfig symbol for shared code. In any case, this select can be dropped as PMIC_DA9055 doesn't exist.

---
0) Tested with "git grep" only.

1) Note that the DA9052 and DA9055 drivers all have code for module support, but their Kconfig entries only allow them to be builtin. Can't these entries be made tristate? If not, shouldn't the code for module support be removed?

 drivers/mfd/Kconfig | 1 -
 1 file changed, 1 deletion(-)
drivers/mfd/Kconfig +0 -1
index 671f5b1..cdff6dd 100644
@@ -487,7 +487,6 @@ config MFD_DA9055
 	bool "Dialog Semiconductor DA9055 PMIC Support"
 	select REGMAP_I2C
 	select REGMAP_IRQ
-	select PMIC_DA9055
 	select MFD_CORE
 	depends on I2C=y && GENERIC_HARDIRQS
 	help
Signature · 1 line
1.7.11.7
#1 lore raw

Hi Paul,

Quoted 11 lines · Paul Bolle

The Kconfig entry for DA9055 PMIC Support selects PMIC_DA9055. That was probably inspired by the similar select statement in the entry for DA9052/53 PMIC with I2C. But the DA9055 PMIC only comes in an I2C variant and its driver doesn't need a separate Kconfig symbol for shared code. In any case, this select can be dropped as PMIC_DA9055 doesn't exist.

---
0) Tested with "git grep" only.

Quoted 7 lines

1) Note that the DA9052 and DA9055 drivers all have code for module support, but their Kconfig entries only allow them to be builtin. Can't these entries be made tristate? If not, shouldn't the code for module support be removed?

 drivers/mfd/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Patch applied to mfd-next, thanks.

Cheers,
Samuel.

Signature · 2 lines
Intel Open Source Technology Centre
http://oss.intel.com/