Reorganize R8A7779/Marzen USB code
v2 cover Reorganize R8A7779/Marzen USB code
Hello.
Here's the set of 9 patches against the Simon Horman's 'renesas.git' repo,
'renesas-next-20130405v2' tag. It was created to fix the shortcomings in the R8A7779/Marzen USB platform code and R8A7779 USB common PHY driver, and so spans both arch/arm/mach-shmobile/ and drivers/usb/ subtrees (some patches have to touch both subtrees). The patches were conceived with the complete bisectability goal in mind. The patches have been tested on the Marzen board.
[1/9] ARM: shmobile: Marzen: move USB EHCI, OHCI, and PHY devices to R8A7779 code [2/9] ehci-platform: add pre_setup() method to platform data
[3/9] ARM: shmobile: R8A7779: setup EHCI internal buffer
[4/9] rcar-phy: remove EHCI internal buffer setup
[5/9] ARM: shmobile: R8A7779: remove USB PHY 2nd memory resource [6/9] rcar-phy: correct base address
[7/9] rcar-phy: add platform data
[8/9] ARM: shmobile: Marzen: pass platform data to USB PHY device [9/9] rcar-phy: handle platform data
I'm not sure thru which tree this patchset should be merged, however it turns
out that it's too late now to push it thru Felipe Balbi's USB tree for 3.10 which would have been most convenient probably, so maybe the patchset can be merged thru Simon's tree with Felipe's and Alan Stern's ACKs. Or perhaps it now should be postponed for 3.11...
WBR, Sergei
v2 cover Reorganize R8A7779/Marzen USB code
Hi
Quoted 6 lines
Here's the set of 9 patches against the Simon Horman's 'renesas.git' repo,
'renesas-next-20130405v2' tag. It was created to fix the shortcomings in the R8A7779/Marzen USB platform code and R8A7779 USB common PHY driver, and so spans botharch/arm/mach-shmobile/anddrivers/usb/subtrees (some patches have to touch both subtrees). The patches were conceived with the complete bisectability goal in mind. The patches have been tested on the Marzen board.
Please add this "tested on xxx" comment on each patch's log area, not only on [0/x]. We need it on "git log"
Quoted 9 lines
[1/9] ARM: shmobile: Marzen: move USB EHCI, OHCI, and PHY devices to R8A7779 code [2/9] ehci-platform: add
pre_setup()method to platform data
[3/9] ARM: shmobile: R8A7779: setup EHCI internal buffer
[4/9] rcar-phy: remove EHCI internal buffer setup
[5/9] ARM: shmobile: R8A7779: remove USB PHY 2nd memory resource [6/9] rcar-phy: correct base address
[7/9] rcar-phy: add platform data
[8/9] ARM: shmobile: Marzen: pass platform data to USB PHY device [9/9] rcar-phy: handle platform data
I didn't get [7/9][9/9] patch somehow
Best regards
---
Kuninori Morimoto
v2 cover Reorganize R8A7779/Marzen USB code
Hello.
Quoted 9 lines · Kuninori Morimoto
Quoted 6 lines
Here's the set of 9 patches against the Simon Horman's 'renesas.git' repo,
'renesas-next-20130405v2' tag. It was created to fix the shortcomings in the R8A7779/Marzen USB platform code and R8A7779 USB common PHY driver, and so spans botharch/arm/mach-shmobile/anddrivers/usb/subtrees (some patches have to touch both subtrees). The patches were conceived with the complete bisectability goal in mind. The patches have been tested on the Marzen board.Please add this "tested on xxx" comment on each patch's log area, not only on [0/x]. We need it on "git log"
I'm going to post R8A7778/BOCK-W series following this one, and all the
patches in 1st series should additionally be tested on BOCK-W. Well, I probably can hold up posting version 3 until I have the second series verified.
BTW, about R8A7778/BOCK-W, R-Car M1A user manual talks about a ferrite
bead in 49.4.1 (3) Setting USB-PHY. Do you know for sure if it's used or not on BOCK-W board? PHY initialization seems to work with either settings...
Quoted 11 lines
Quoted 9 lines
[1/9] ARM: shmobile: Marzen: move USB EHCI, OHCI, and PHY devices to R8A7779 code [2/9] ehci-platform: add
pre_setup()method to platform data
[3/9] ARM: shmobile: R8A7779: setup EHCI internal buffer
[4/9] rcar-phy: remove EHCI internal buffer setup
[5/9] ARM: shmobile: R8A7779: remove USB PHY 2nd memory resource [6/9] rcar-phy: correct base address
[7/9] rcar-phy: add platform data
[8/9] ARM: shmobile: Marzen: pass platform data to USB PHY device [9/9] rcar-phy: handle platform dataI didn't get [7/9][9/9] patch somehow
Here they are in the archive:
http://marc.info/?l=linux-usb&m=136545680506170
http://marc.info/?l=linux-usb&m=136545698906257
WBR, Sergei
v2 cover Reorganize R8A7779/Marzen USB code
Hi Sergei
Quoted 9 lines
Quoted 2 lines
Please add this "tested on xxx" comment on each patch's log area, not only on [0/x]. We need it on "git log"
I'm going to post R8A7778/BOCK-W series following this one, and all the
patches in 1st series should additionally be tested on BOCK-W. Well, I probably can hold up posting version 3 until I have the second series verified.
BTW, about R8A7778/BOCK-W, R-Car M1A user manual talks about a ferrite
bead in 49.4.1 (3) Setting USB-PHY. Do you know for sure if it's used or not on BOCK-W board? PHY initialization seems to work with either settings...
I can ask it to HW team if you want me.
But our local BSP is using "No ferrite bead" settings...
Best regards
---
Kuninori Morimoto
v2 cover Reorganize R8A7779/Marzen USB code
Hello.
Quoted 11 lines · Kuninori Morimoto
Quoted 9 lines
Quoted 3 lines
Please add this "tested on xxx" comment on each patch's log area, not only on [0/x]. We need it on "git log"
I'm going to post R8A7778/BOCK-W series following this one, and all the
patches in 1st series should additionally be tested on BOCK-W. Well, I probably can hold up posting version 3 until I have the second series verified.
BTW, about R8A7778/BOCK-W, R-Car M1A user manual talks about a ferrite
bead in 49.4.1 (3) Setting USB-PHY. Do you know for sure if it's used or not on BOCK-W board? PHY initialization seems to work with either settings...I can ask it to HW team if you want me.
But our local BSP is using "No ferrite bead" settings...
I've rummaged thru the BSP I have and found not traces of a ferrite bead
(and rcar-phy driver as well) in the patches...
Quoted 3 lines
Best regards
---
Kuninori Morimoto
WBR, Sergei
v2 cover Reorganize R8A7779/Marzen USB code
Quoted 16 lines · On 04/13/2013 03:07 AM, I wrote:
Quoted 16 lines
Quoted 16 lines
Quoted 5 lines
Please add this "tested on xxx" comment on each patch's log area, not only on [0/x].
We need it on "git log"I'm going to post R8A7778/BOCK-W series following this one, and
all the
patches in 1st series should additionally be tested on BOCK-W. Well, I probably can hold up posting version 3 until I have the second series verified.
BTW, about R8A7778/BOCK-W, R-Car M1A user manual talks about a
ferrite
bead in 49.4.1 (3) Setting USB-PHY. Do you know for sure if it's used or not
on BOCK-W board? PHY initialization seems to work with either settings...
Quoted 1 line
Quoted 1 line
I can ask it to HW team if you want me.
Yes, ask them please.
WBR, Sergei
v2 cover Reorganize R8A7779/Marzen USB code
Hi Sergei
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
I'm going to post R8A7778/BOCK-W series following this one, and
all the
patches in 1st series should additionally be tested on BOCK-W. Well, I probably can hold up posting version 3 until I have the second series verified.
BTW, about R8A7778/BOCK-W, R-Car M1A user manual talks about a
ferrite
bead in 49.4.1 (3) Setting USB-PHY. Do you know for sure if it's used or not
on BOCK-W board? PHY initialization seems to work with either settings...
Quoted 3 lines
Quoted 1 line
Quoted 1 line
I can ask it to HW team if you want me.
Yes, ask them please.
Now, I'm asking it to HW team
Please wait
Best regards
---
Kuninori Morimoto
v2 cover Reorganize R8A7779/Marzen USB code
Hi Sergei
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
I'm going to post R8A7778/BOCK-W series following this one, and
all the
patches in 1st series should additionally be tested on BOCK-W. Well, I probably can hold up posting version 3 until I have the second series verified.
BTW, about R8A7778/BOCK-W, R-Car M1A user manual talks about a
ferrite
bead in 49.4.1 (3) Setting USB-PHY. Do you know for sure if it's used or not
on BOCK-W board? PHY initialization seems to work with either settings...
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Quoted 1 line
I can ask it to HW team if you want me.
Yes, ask them please.
Now, I'm asking it to HW team
Please wait
According to HW team,
this setting is for some kind of USB compliance test (?). So, in general, we can use "No ferrite bead".
Best regards
---
Kuninori Morimoto
v2 cover Reorganize R8A7779/Marzen USB code
Hello.
Quoted 11 lines · Kuninori Morimoto
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
Quoted 11 lines
I'm going to post R8A7778/BOCK-W series following this one, and
all the
patches in 1st series should additionally be tested on BOCK-W. Well, I probably can hold up posting version 3 until I have the second series verified.
BTW, about R8A7778/BOCK-W, R-Car M1A user manual talks about a
ferrite
bead in 49.4.1 (3) Setting USB-PHY. Do you know for sure if it's used or not
on BOCK-W board? PHY initialization seems to work with either settings...
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Quoted 1 line
Quoted 1 line
I can ask it to HW team if you want me.
Yes, ask them please.
Now, I'm asking it to HW team
Please waitAccording to HW team,
this setting is for some kind of USB compliance test (?). So, in general, we can use "No ferrite bead".
Thanks, I'll change it.
WBR, Sergei
v2 cover Reorganize R8A7779/Marzen USB code
In reply to Sergei ShtylyovQuoted 19 lines · Sergei Shtylyov
Hello.
Here's the set of 9 patches against the Simon Horman's 'renesas.git' repo,
'renesas-next-20130405v2' tag. It was created to fix the shortcomings in the R8A7779/Marzen USB platform code and R8A7779 USB common PHY driver, and so spans botharch/arm/mach-shmobile/anddrivers/usb/subtrees (some patches have to touch both subtrees). The patches were conceived with the complete bisectability goal in mind. The patches have been tested on the Marzen board.[1/9] ARM: shmobile: Marzen: move USB EHCI, OHCI, and PHY devices to R8A7779 code [2/9] ehci-platform: add
pre_setup()method to platform data
[3/9] ARM: shmobile: R8A7779: setup EHCI internal buffer
[4/9] rcar-phy: remove EHCI internal buffer setup
[5/9] ARM: shmobile: R8A7779: remove USB PHY 2nd memory resource [6/9] rcar-phy: correct base address
[7/9] rcar-phy: add platform data
[8/9] ARM: shmobile: Marzen: pass platform data to USB PHY device [9/9] rcar-phy: handle platform data
Quoted 5 lines
I'm not sure thru which tree this patchset should be merged, however it turns
out that it's too late now to push it thru Felipe Balbi's USB tree for 3.10 which would have been most convenient probably, so maybe the patchset can be merged thru Simon's tree with Felipe's and Alan Stern's ACKs. Or perhaps it now should be postponed for 3.11...
I feel that it is also too late for v3.10 for my tree.
I am happy to take them through my tree with appropriate acks. Or, follow acks from Morimoto-san to allow the shmobile portions to go through a different tree.