Skip to contentSkip to conversation

ARM: shmobile: Include all 2 GiB of memory on APE6EVM

PATCH New Magnus Damm 2 participants 7 messages Apr 8, 2013 – Apr 10, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: shmobile: Include all 2 GiB of memory on APE6EVM

From: Takashi Yoshii <[email protected]>

Add 1GiB of DRAM at 0x2_0000_0000

---

This patch simply updates the DTS to describe the actual board hardware. If we want to make use of the memory we also need to enable LPAE in the kernel configuration, but that is seen as a separate step.

 arch/arm/boot/dts/r8a73a4-ape6evm.dts |    5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/r8a73a4-ape6evm.dts +5 -0
@@ -24,6 +24,11 @@
 		reg = <0 0x40000000 0 0x40000000>;
 	};
 
+	memory at 200000000 {
+		device_type = "memory";
+		reg = <2 0x00000000 0 0x40000000>;
+	};
+
 	ape6evm_fixed_3v3: fixedregulator at 0 {
 		compatible = "regulator-fixed";
 		regulator-name = "3V3";
#1 lore raw

PATCH 1/1 ARM: shmobile: Include all 2 GiB of memory on APE6EVM

Quoted 6 lines · Magnus Damm

From: Takashi Yoshii <[email protected]>

Add 1GiB of DRAM at 0x2_0000_0000

Thanks, queued up in the boards-ape6evm branch.

Quoted 25 lines

---

This patch simply updates the DTS to describe the actual board hardware. If we want to make use of the memory we also need to enable LPAE in the kernel configuration, but that is seen as a separate step.

 arch/arm/boot/dts/r8a73a4-ape6evm.dts |    5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/r8a73a4-ape6evm.dts +5 -0
@@ -24,6 +24,11 @@
 		reg = <0 0x40000000 0 0x40000000>;
 	};
 
+	memory at 200000000 {
+		device_type = "memory";
+		reg = <2 0x00000000 0 0x40000000>;
+	};
+
 	ape6evm_fixed_3v3: fixedregulator at 0 {
 		compatible = "regulator-fixed";
 		regulator-name = "3V3";
#2 lore raw

PATCH 1/1 ARM: shmobile: Include all 2 GiB of memory on APE6EVM

Quoted 9 lines · Simon Horman
Quoted 6 lines · Magnus Damm

From: Takashi Yoshii <[email protected]>

Add 1GiB of DRAM at 0x2_0000_0000

Thanks, queued up in the boards-ape6evm branch.

I have dropped this patch as it appears to prevent the board from booting.

Quoted 31 lines
Quoted 16 lines

---

This patch simply updates the DTS to describe the actual board hardware. If we want to make use of the memory we also need to enable LPAE in the kernel configuration, but that is seen as a separate step.

 arch/arm/boot/dts/r8a73a4-ape6evm.dts |    5 +++++
 1 file changed, 5 insertions(+)
arch/arm/boot/dts/r8a73a4-ape6evm.dts +0 -0
@@ -24,6 +24,11 @@
 		reg = <0 0x40000000 0 0x40000000>;

arch/arm/boot/dts/r8a73a4-ape6evm.dts line 34

Quoted 10 lines
arch/arm/boot/dts/r8a73a4-ape6evm.dts +5 -0
 	};
 
+	memory at 200000000 {
+		device_type = "memory";
+		reg = <2 0x00000000 0 0x40000000>;
+	};
+
 	ape6evm_fixed_3v3: fixedregulator at 0 {
 		compatible = "regulator-fixed";
 		regulator-name = "3V3";

--
To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw

PATCH 1/1 ARM: shmobile: Include all 2 GiB of memory on APE6EVM

Hi Simon,

Quoted 6 lines · Simon Horman
Quoted 5 lines · Simon Horman
Quoted 4 lines · Magnus Damm

From: Takashi Yoshii <[email protected]>

Add 1GiB of DRAM at 0x2_0000_0000

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

Thanks, queued up in the boards-ape6evm branch.

I have dropped this patch as it appears to prevent the board from booting.

Is it possible that LPAE=n and HIGHMEM=y in your particular kernel configuration?

Quoted 1 line

From what I can tell HIGHMEM is broken in cases of large amounts of

memory. Try disabling that as a short-term workaround. Then of course someone needs to track down why the generic code doesn't work as expected.

Thanks,

/ magnus

#4 lore raw

PATCH 1/1 ARM: shmobile: Include all 2 GiB of memory on APE6EVM

Quoted 12 lines · Magnus Damm

Hi Simon,

Quoted 9 lines · Simon Horman
Quoted 8 lines · Simon Horman
Quoted 6 lines · Magnus Damm

From: Takashi Yoshii <[email protected]>

Add 1GiB of DRAM at 0x2_0000_0000

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Thanks, queued up in the boards-ape6evm branch.

I have dropped this patch as it appears to prevent the board from booting.

Is it possible that LPAE=n and HIGHMEM=y in your particular kernel configuration?

Yes, I have confirmed that is what using the ape6evm_defconfig results in.

Quoted 4 lines
Quoted 1 line

From what I can tell HIGHMEM is broken in cases of large amounts of

memory. Try disabling that as a short-term workaround. Then of course someone needs to track down why the generic code doesn't work as expected.

I have confirmed that disabling HIGHMEM allows the board to boot with this patch applied.

Should I prepare a patch to the defconfig to accompany this patch?

#5 lore raw

PATCH 1/1 ARM: shmobile: Include all 2 GiB of memory on APE6EVM

Hi Simon, Arnd,

Quoted 23 lines · Simon Horman
Quoted 12 lines · Magnus Damm

Hi Simon,

Quoted 9 lines · Simon Horman
Quoted 8 lines · Simon Horman
Quoted 6 lines · Magnus Damm

From: Takashi Yoshii <[email protected]>

Add 1GiB of DRAM at 0x2_0000_0000

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Thanks, queued up in the boards-ape6evm branch.

I have dropped this patch as it appears to prevent the board from booting.

Is it possible that LPAE=n and HIGHMEM=y in your particular kernel configuration?

Yes, I have confirmed that is what using the ape6evm_defconfig results in.

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

From what I can tell HIGHMEM is broken in cases of large amounts of

memory. Try disabling that as a short-term workaround. Then of course someone needs to track down why the generic code doesn't work as expected.

I have confirmed that disabling HIGHMEM allows the board to boot with this patch applied.

Thanks for checking.

So HIGHMEM without LPAE seems busted on boards using more than 32-bits for memory.

I'd like to help out fixing this issue, but I'd like to make sure that no one else is working on this.

Arnd, are you aware on any work related to making HIGHMEM work without LPAE?

Quoted 1 line

Should I prepare a patch to the defconfig to accompany this patch?

I believe that would affect a bunch of boards so I don't think that is necessary at this point. Thanks anyway.

Would it be possible for you to queue up this change in a APE6EVM topic branch?

Thanks,

/ magnus

#6 lore raw

PATCH 1/1 ARM: shmobile: Include all 2 GiB of memory on APE6EVM

Quoted 25 lines · Magnus Damm

Hi Simon, Arnd,

Quoted 22 lines · Simon Horman
Quoted 12 lines · Magnus Damm

Hi Simon,

Quoted 9 lines · Simon Horman
Quoted 8 lines · Simon Horman
Quoted 6 lines · Magnus Damm

From: Takashi Yoshii <[email protected]>

Add 1GiB of DRAM at 0x2_0000_0000

Quoted 7 lines
Quoted 4 lines
Quoted 1 line

Thanks, queued up in the boards-ape6evm branch.

I have dropped this patch as it appears to prevent the board from booting.

Is it possible that LPAE=n and HIGHMEM=y in your particular kernel configuration?

Yes, I have confirmed that is what using the ape6evm_defconfig results in.

oup >

Quoted 16 lines
Quoted 7 lines
Quoted 4 lines
Quoted 1 line

From what I can tell HIGHMEM is broken in cases of large amounts of

memory. Try disabling that as a short-term workaround. Then of course someone needs to track down why the generic code doesn't work as expected.

I have confirmed that disabling HIGHMEM allows the board to boot with this patch applied.

Thanks for checking.

So HIGHMEM without LPAE seems busted on boards using more than 32-bits for memory.

I'd like to help out fixing this issue, but I'd like to make sure that no one else is working on this.

Quoted 8 lines

Arnd, are you aware on any work related to making HIGHMEM work without LPAE?

Quoted 1 line

Should I prepare a patch to the defconfig to accompany this patch?

I believe that would affect a bunch of boards so I don't think that is necessary at this point. Thanks anyway.

Would it be possible for you to queue up this change in a APE6EVM topic branch?

Sure, I have pushed topic/ape6evm-2gb.

I also plan to push topic/ape6evm-2gb+renesas-next-20130410v2 once I have finalised renesas-next-20130410v2.