Skip to contentSkip to conversation

perf --version inconsistency

DISCUSSION Sukadev Bhattiprolu 1 participant 1 message Apr 9, 2013

lore
Share & tools
lore
#0 lore raw

Following commit replaced 'git describe' with 'git tag -l | tail -1' to speed up the build:

commit acddedfba0df1e47fa99035a04661082b679ee9c
Author: Ingo Molnar <[email protected]>
Date: Tue Oct 30 09:46:00 2012 +0100

perf tools: Speed up the perf build time by simplifying the perf --version string generation

If we checkout an older commit and build perf, the version reported by 'perf' ends up being inconsistent:

	$ git describe
	v3.8-rc7
	$ git show --pretty=short 
	commit 836dc9e3fbbab0c30aa6e664417225f5c1fb1c39
	Author: Linus Torvalds <[email protected]>
	    Linux 3.8-rc7

	$ git tag -l | tail -1
	v3.9-rc4

	$ cd tools/perf; make perf

	$ ./perf --version
	perf version 3.9.rc4.g836dc9e

where commit id '836dc9e' corresponds to 'v3.8-rc7' rather than '3.9.rc4'.

Is the tag reported by 'perf --version' meant to be approximate ?

Wonder if we can do anything on the 'git' side to cache the tag associated with HEAD and update the cache at each 'git checkout'. That could slow down 'git checkout' though.

Sukadev