Skip to contentSkip to conversation

Too man programs calls nfsiostat.

DISCUSSION NeilBrown 4 participants 13 messages Apr 9, 2013 – Jan 25, 2014

Subsystems (2)
NFS client NFS server
lore
Share & tools
lore

NeilBrown

author
#0 lore raw

Hi all,
it seems that in 2010, a program called nfsiostat was added to the sysstat package (http://sebastien.godard.pagesperso-orange.fr/)

This is unfortunate because in 2008 a program called nfsiostat was added to the nfs-utils package.

    (https://www.kernel.org/pub/linux/utils/nfs-utils/1.2.7/)

The default install locations seem to be different (/usr/bin vs /usr/sbin), so packagers would not immediately notice.

This seems like something that should be "fixed".

Any suggestions what a good "fix" should look like?

NeilBrown

author
#1 lore raw

Re: Too many programs calls nfsiostat.

Not quite a year ago I wrote:

Quoted 9 lines · On Wed, 10 Apr 2013 09:46:39 +1000 NeilBrown <[email protected]> wrote:

Hi all,
it seems that in 2010, a program called nfsiostat was added to the sysstat package (http://sebastien.godard.pagesperso-orange.fr/)

This is unfortunate because in 2008 a program called nfsiostat was added to the nfs-utils package.

    (https://www.kernel.org/pub/linux/utils/nfs-utils/1.2.7/)
Quoted 8 lines

The default install locations seem to be different (/usr/bin vs /usr/sbin), so packagers would not immediately notice.

This seems like something that should be "fixed".

Any suggestions what a good "fix" should look like?

NeilBrown

No suggestions were forthcoming.
So I have a suggestion.
I propose we rename the "nfsiostat" in the "sysstat" package to "nfsio-sysstat" and the "nfsiostat" in "nfs-utils" to "nfs-utils-iostat".

Does anyone object? If not I'll send off patches shortly :-)

NeilBrown

author
#2 lore raw

Re: Too many programs calls nfsiostat.

In reply to NeilBrown

(This time without the typo in Chuck's address - sorry).

Not quite a year ago I wrote:

Quoted 9 lines · On Wed, 10 Apr 2013 09:46:39 +1000 NeilBrown <[email protected]> wrote:

Hi all,
it seems that in 2010, a program called nfsiostat was added to the sysstat package (http://sebastien.godard.pagesperso-orange.fr/)

This is unfortunate because in 2008 a program called nfsiostat was added to the nfs-utils package.

    (https://www.kernel.org/pub/linux/utils/nfs-utils/1.2.7/)
Quoted 8 lines

The default install locations seem to be different (/usr/bin vs /usr/sbin), so packagers would not immediately notice.

This seems like something that should be "fixed".

Any suggestions what a good "fix" should look like?

NeilBrown

No suggestions were forthcoming.
So I have a suggestion.
I propose we rename the "nfsiostat" in the "sysstat" package to "nfsio-sysstat" and the "nfsiostat" in "nfs-utils" to "nfs-utils-iostat".

Does anyone object? If not I'll send off patches shortly :-)

NeilBrown

#3 lore raw

Re: Too many programs calls nfsiostat.

Quoted 26 lines · NeilBrown

(This time without the typo in Chuck's address - sorry).

Not quite a year ago I wrote:

Quoted 9 lines · On Wed, 10 Apr 2013 09:46:39 +1000 NeilBrown <[email protected]> wrote:

Hi all,
it seems that in 2010, a program called nfsiostat was added to the sysstat package (http://sebastien.godard.pagesperso-orange.fr/)

This is unfortunate because in 2008 a program called nfsiostat was added to the nfs-utils package.
(https://www.kernel.org/pub/linux/utils/nfs-utils/1.2.7/)

Quoted 8 lines

The default install locations seem to be different (/usr/bin vs /usr/sbin), so packagers would not immediately notice.

This seems like something that should be "fixed".

Any suggestions what a good "fix" should look like?

NeilBrown

Quoted 7 lines

No suggestions were forthcoming.
So I have a suggestion.
I propose we rename the "nfsiostat" in the "sysstat" package to "nfsio-sysstat" and the "nfsiostat" in "nfs-utils" to "nfs-utils-iostat".

Does anyone object? If not I'll send off patches shortly :-)

What does the sysstat version do? do we need two programs, or can they be merged? Or can one be dropped?

--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com

author
#4 lore raw

Re: Too many programs called nfsiostat.

Quoted 35 lines · On Tue, 21 Jan 2014 10:40:01 -0500 Chuck Lever <[email protected]> wrote:
Quoted 32 lines · NeilBrown

(This time without the typo in Chuck's address - sorry).

Not quite a year ago I wrote:

Quoted 9 lines · On Wed, 10 Apr 2013 09:46:39 +1000 NeilBrown <[email protected]> wrote:

Hi all,
it seems that in 2010, a program called nfsiostat was added to the sysstat package (http://sebastien.godard.pagesperso-orange.fr/)

This is unfortunate because in 2008 a program called nfsiostat was added to the nfs-utils package.
(https://www.kernel.org/pub/linux/utils/nfs-utils/1.2.7/)

Quoted 8 lines

The default install locations seem to be different (/usr/bin vs /usr/sbin), so packagers would not immediately notice.

This seems like something that should be "fixed".

Any suggestions what a good "fix" should look like?

NeilBrown

No suggestions were forthcoming.
So I have a suggestion.
I propose we rename the "nfsiostat" in the "sysstat" package to "nfsio-sysstat" and the "nfsiostat" in "nfs-utils" to "nfs-utils-iostat".

Quoted 4 lines
Quoted 1 line

Does anyone object? If not I'll send off patches shortly :-)

What does the sysstat version do? do we need two programs, or can they be merged? Or can one be dropped?

It reads /proc/self/mountstats and reports some numbers, not unlike the nfs-utils version.

$ /usr/sbin/nfsiostat

eli:/home mounted on /mnt:

op/s rpc bklog
3.55 0.00
read: ops/s kB/s kB/op retrans avg RTT (ms) avg exe (ms)

		  0.000	  0.000	  0.000       0 (0.0%)	  0.000	  0.000
write:           ops/s		   kB/s		  kB/op		retrans		avg RTT (ms)	avg exe (ms)
		  0.000	  0.000	  0.000       0 (0.0%)	  0.000	  0.000
$ /usr/bin/nfsiostat 
Linux 3.11.6-4-desktop (notabene.brown) 	01/22/2014 	_x86_64_	(8 CPU)

Filesystem: rkB_nor/s wkB_nor/s rkB_dir/s wkB_dir/s rkB_svr/s wkB_svr/s ops/s rops/s wops/s
eli:/home 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00

The man page for the sysstat version is:

http://www.makelinux.com/man/1/N/nfsiostat

while man page for nfs-utils version is:

http://linux.die.net/man/8/nfsiostat

NeilBrown

#5 lore raw

Re: Too many programs called nfsiostat.

Quoted 58 lines · NeilBrown
Quoted 35 lines · On Tue, 21 Jan 2014 10:40:01 -0500 Chuck Lever <[email protected]> wrote:
Quoted 32 lines · NeilBrown

(This time without the typo in Chuck's address - sorry).

Not quite a year ago I wrote:

Quoted 9 lines · On Wed, 10 Apr 2013 09:46:39 +1000 NeilBrown <[email protected]> wrote:

Hi all,
it seems that in 2010, a program called nfsiostat was added to the sysstat package (http://sebastien.godard.pagesperso-orange.fr/)

This is unfortunate because in 2008 a program called nfsiostat was added to the nfs-utils package.
(https://www.kernel.org/pub/linux/utils/nfs-utils/1.2.7/)

Quoted 8 lines

The default install locations seem to be different (/usr/bin vs /usr/sbin), so packagers would not immediately notice.

This seems like something that should be "fixed".

Any suggestions what a good "fix" should look like?

NeilBrown

No suggestions were forthcoming.
So I have a suggestion.
I propose we rename the "nfsiostat" in the "sysstat" package to "nfsio-sysstat" and the "nfsiostat" in "nfs-utils" to "nfs-utils-iostat".

Quoted 4 lines
Quoted 1 line

Does anyone object? If not I'll send off patches shortly :-)

What does the sysstat version do? do we need two programs, or can they be merged? Or can one be dropped?

It reads /proc/self/mountstats and reports some numbers, not unlike the nfs-utils version.

$ /usr/sbin/nfsiostat

eli:/home mounted on /mnt:

op/s rpc bklog
3.55 0.00
read: ops/s kB/s kB/op retrans avg RTT (ms) avg exe (ms)

		  0.000	  0.000	  0.000       0 (0.0%)	  0.000	  0.000
write:           ops/s		   kB/s		  kB/op		retrans		avg RTT (ms)	avg exe (ms)
		  0.000	  0.000	  0.000       0 (0.0%)	  0.000	  0.000
$ /usr/bin/nfsiostat 
Linux 3.11.6-4-desktop (notabene.brown) 	01/22/2014 	_x86_64_	(8 CPU)
Quoted 7 lines

Filesystem: rkB_nor/s wkB_nor/s rkB_dir/s wkB_dir/s rkB_svr/s wkB_svr/s ops/s rops/s wops/s
eli:/home 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00

The man page for the sysstat version is:

http://www.makelinux.com/man/1/N/nfsiostat

Is this version still actively being maintain?

steved.

Quoted 7 lines

while man page for nfs-utils version is:

http://linux.die.net/man/8/nfsiostat

NeilBrown

#6 lore raw

Re: Too many programs called nfsiostat.

Quoted 58 lines · Steve Dickson
Quoted 56 lines · NeilBrown
Quoted 25 lines · On Tue, 21 Jan 2014 10:40:01 -0500 Chuck Lever <[email protected]> wrote:
Quoted 23 lines · NeilBrown

(This time without the typo in Chuck's address - sorry).

Not quite a year ago I wrote:

Quoted 16 lines · On Wed, 10 Apr 2013 09:46:39 +1000 NeilBrown <[email protected]> wrote:

Hi all,
it seems that in 2010, a program called nfsiostat was added to the sysstat package (http://sebastien.godard.pagesperso-orange.fr/)

This is unfortunate because in 2008 a program called nfsiostat was added to the nfs-utils package.

    (https://www.kernel.org/pub/linux/utils/nfs-utils/1.2.7/)

The default install locations seem to be different (/usr/bin vs /usr/sbin), so packagers would not immediately notice.

This seems like something that should be "fixed".

Any suggestions what a good "fix" should look like?

NeilBrown

Quoted 9 lines
Quoted 7 lines

No suggestions were forthcoming.
So I have a suggestion.
I propose we rename the "nfsiostat" in the "sysstat" package to "nfsio-sysstat" and the "nfsiostat" in "nfs-utils" to "nfs-utils-iostat".

Does anyone object? If not I'll send off patches shortly :-)

What does the sysstat version do? do we need two programs, or can they be merged? Or can one be dropped?

It reads /proc/self/mountstats and reports some numbers, not unlike the nfs-utils version.

$ /usr/sbin/nfsiostat

eli:/home mounted on /mnt:

op/s rpc bklog
3.55 0.00
read: ops/s kB/s kB/op retrans avg RTT (ms) avg exe (ms)

		  0.000	  0.000	  0.000       0 (0.0%)	  0.000	  0.000
write:           ops/s		   kB/s		  kB/op		retrans		avg RTT (ms)	avg exe (ms)
		  0.000	  0.000	  0.000       0 (0.0%)	  0.000	  0.000
$ /usr/bin/nfsiostat
Linux 3.11.6-4-desktop (notabene.brown) 	01/22/2014 	_x86_64_	(8 CPU)

Filesystem: rkB_nor/s wkB_nor/s rkB_dir/s wkB_dir/s rkB_svr/s wkB_svr/s ops/s rops/s wops/s
eli:/home 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00

Quoted 14 lines
Quoted 3 lines

The man page for the sysstat version is:

http://www.makelinux.com/man/1/N/nfsiostat

Is this version still actively being maintain?

steved.

Quoted 6 lines

while man page for nfs-utils version is:

http://linux.die.net/man/8/nfsiostat

NeilBrown

The nfsiostat command from the sysstat package is actually no longer actively being maintained. So I think that it can be merged with that from nfs-utils package.

Regards,

Signature · 2 lines
Sebastien GODARD <sysstat [at] orange.fr>
http://sebastien.godard.pagesperso-orange.fr/
author
#7 lore raw

Re: Too many programs called nfsiostat.

In reply to Steve Dickson
Quoted 61 lines · On Wed, 22 Jan 2014 08:12:35 -0500 Steve Dickson <[email protected]> wrote:
Quoted 58 lines · NeilBrown
Quoted 35 lines · On Tue, 21 Jan 2014 10:40:01 -0500 Chuck Lever <[email protected]> wrote:
Quoted 32 lines · NeilBrown

(This time without the typo in Chuck's address - sorry).

Not quite a year ago I wrote:

Quoted 9 lines · On Wed, 10 Apr 2013 09:46:39 +1000 NeilBrown <[email protected]> wrote:

Hi all,
it seems that in 2010, a program called nfsiostat was added to the sysstat package (http://sebastien.godard.pagesperso-orange.fr/)

This is unfortunate because in 2008 a program called nfsiostat was added to the nfs-utils package.
(https://www.kernel.org/pub/linux/utils/nfs-utils/1.2.7/)

Quoted 8 lines

The default install locations seem to be different (/usr/bin vs /usr/sbin), so packagers would not immediately notice.

This seems like something that should be "fixed".

Any suggestions what a good "fix" should look like?

NeilBrown

No suggestions were forthcoming.
So I have a suggestion.
I propose we rename the "nfsiostat" in the "sysstat" package to "nfsio-sysstat" and the "nfsiostat" in "nfs-utils" to "nfs-utils-iostat".

Quoted 4 lines
Quoted 1 line

Does anyone object? If not I'll send off patches shortly :-)

What does the sysstat version do? do we need two programs, or can they be merged? Or can one be dropped?

It reads /proc/self/mountstats and reports some numbers, not unlike the nfs-utils version.

$ /usr/sbin/nfsiostat

eli:/home mounted on /mnt:

op/s rpc bklog
3.55 0.00
read: ops/s kB/s kB/op retrans avg RTT (ms) avg exe (ms)

		  0.000	  0.000	  0.000       0 (0.0%)	  0.000	  0.000
write:           ops/s		   kB/s		  kB/op		retrans		avg RTT (ms)	avg exe (ms)
		  0.000	  0.000	  0.000       0 (0.0%)	  0.000	  0.000
$ /usr/bin/nfsiostat 
Linux 3.11.6-4-desktop (notabene.brown) 	01/22/2014 	_x86_64_	(8 CPU)
Quoted 8 lines
Quoted 7 lines

Filesystem: rkB_nor/s wkB_nor/s rkB_dir/s wkB_dir/s rkB_svr/s wkB_svr/s ops/s rops/s wops/s
eli:/home 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00

The man page for the sysstat version is:

http://www.makelinux.com/man/1/N/nfsiostat

Is this version still actively being maintain?

Last change was 5 days ago.

https://github.com/sysstat/sysstat/commits/master/nfsiostat.c

NeilBrown

Quoted 10 lines

steved.

Quoted 7 lines

while man page for nfs-utils version is:

http://linux.die.net/man/8/nfsiostat

NeilBrown

#8 lore raw

Re: Too many programs called nfsiostat.

Quoted 67 lines · NeilBrown
Quoted 65 lines · On Wed, 22 Jan 2014 08:12:35 -0500 Steve Dickson <[email protected]> wrote:
Quoted 62 lines · NeilBrown
Quoted 35 lines · On Tue, 21 Jan 2014 10:40:01 -0500 Chuck Lever <[email protected]> wrote:
Quoted 32 lines · NeilBrown

(This time without the typo in Chuck's address - sorry).

Not quite a year ago I wrote:

Quoted 9 lines · On Wed, 10 Apr 2013 09:46:39 +1000 NeilBrown <[email protected]> wrote:

Hi all,
it seems that in 2010, a program called nfsiostat was added to the sysstat package (http://sebastien.godard.pagesperso-orange.fr/)

This is unfortunate because in 2008 a program called nfsiostat was added to the nfs-utils package.
(https://www.kernel.org/pub/linux/utils/nfs-utils/1.2.7/)

Quoted 8 lines

The default install locations seem to be different (/usr/bin vs /usr/sbin), so packagers would not immediately notice.

This seems like something that should be "fixed".

Any suggestions what a good "fix" should look like?

NeilBrown

No suggestions were forthcoming.
So I have a suggestion.
I propose we rename the "nfsiostat" in the "sysstat" package to "nfsio-sysstat" and the "nfsiostat" in "nfs-utils" to "nfs-utils-iostat".

Quoted 4 lines
Quoted 1 line

Does anyone object? If not I'll send off patches shortly :-)

What does the sysstat version do? do we need two programs, or can they be merged? Or can one be dropped?

It reads /proc/self/mountstats and reports some numbers, not unlike the nfs-utils version.

$ /usr/sbin/nfsiostat

eli:/home mounted on /mnt:

op/s rpc bklog
3.55 0.00
read: ops/s kB/s kB/op retrans avg RTT (ms) avg exe (ms)

		  0.000	  0.000	  0.000       0 (0.0%)	  0.000	  0.000
write:           ops/s		   kB/s		  kB/op		retrans		avg RTT (ms)	avg exe (ms)
		  0.000	  0.000	  0.000       0 (0.0%)	  0.000	  0.000
$ /usr/bin/nfsiostat 
Linux 3.11.6-4-desktop (notabene.brown) 	01/22/2014 	_x86_64_	(8 CPU)

Filesystem: rkB_nor/s wkB_nor/s rkB_dir/s wkB_dir/s rkB_svr/s wkB_svr/s ops/s rops/s wops/s
eli:/home 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00 0.00

Quoted 8 lines
Quoted 4 lines
Quoted 3 lines

The man page for the sysstat version is:

http://www.makelinux.com/man/1/N/nfsiostat

Is this version still actively being maintain?

Last change was 5 days ago.

https://github.com/sysstat/sysstat/commits/master/nfsiostat.c

I guess the question now is do they want to continue maintaining it or just merge the functionality into the nfs-utils version...

steved.

Quoted 15 lines

NeilBrown

Quoted 10 lines

steved.

Quoted 7 lines

while man page for nfs-utils version is:

http://linux.die.net/man/8/nfsiostat

NeilBrown

#9 lore raw

Re: Too many programs called nfsiostat.

Quoted 5 lines · Steve Dickson
Quoted 3 lines · NeilBrown
Quoted 1 line · On Wed, 22 Jan 2014 08:12:35 -0500 Steve Dickson <[email protected]> wrote:
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines · NeilBrown

Is this version still actively being maintain?

Last change was 5 days ago.

https://github.com/sysstat/sysstat/commits/master/nfsiostat.c

I guess the question now is do they want to continue maintaining it or just merge the functionality into the nfs-utils version...

This is no longer a question as I already answered it. Please *read* my previous mail.

Regards,

Signature · 2 lines
Sebastien GODARD <sysstat [at] orange.fr>
http://sebastien.godard.pagesperso-orange.fr/
#10 lore raw

Re: Too many programs called nfsiostat.

Quoted 8 lines · Sebastien Godard
Quoted 7 lines · Steve Dickson
Quoted 5 lines · NeilBrown
Quoted 3 lines · On Wed, 22 Jan 2014 08:12:35 -0500 Steve Dickson <[email protected]> wrote:

On 21/01/14 19:24, NeilBrown wrote:
Is this version still actively being maintain?

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

Last change was 5 days ago.

https://github.com/sysstat/sysstat/commits/master/nfsiostat.c

I guess the question now is do they want to continue maintaining it or just merge the functionality into the nfs-utils version...

This is no longer a question as I already answered it. Please *read* my previous mail.

I did... but thought Neil's mail was pointing out that some type of maintenance was happening... But if you say it's "no longer actively being maintained" I'll believe you... :-)

So what is the next step to deprecate the nfsiostat in sysstat?

steved.

Quoted 3 lines

Regards,

#11 lore raw

Re: Too many programs called nfsiostat.

Quoted 14 lines · Steve Dickson
Quoted 12 lines · Sebastien Godard
Quoted 11 lines · Steve Dickson
Quoted 7 lines · NeilBrown
Quoted 2 lines · On Wed, 22 Jan 2014 08:12:35 -0500 Steve Dickson <[email protected]> wrote:

On 21/01/14 19:24, NeilBrown wrote:
Is this version still actively being maintain?

Last change was 5 days ago.

https://github.com/sysstat/sysstat/commits/master/nfsiostat.c

I guess the question now is do they want to continue maintaining it or just merge the functionality into the nfs-utils version...

Quoted 7 lines
Quoted 1 line

This is no longer a question as I already answered it. Please *read* my previous mail.

I did... but thought Neil's mail was pointing out that some type of maintenance was happening... But if you say it's "no longer actively being maintained" I'll believe you... :-)

So what is the next step to deprecate the nfsiostat in sysstat?

In fact, the various patches applied to nfsiostat over the last few years were mainly cosmetic ones (changes in sysstat APIs, etc.)
So I propose now to simply remove nfsiostat code from sysstat: Next sysstat version will rename nfsiostat (eg. to nfsiostat-sysstat) and the man page will indicate it is now obsolete and point to the version from nfs-utils. Then nfsiostat will be definitively removed sometime before the end of this year.

Regards,

Signature · 2 lines
Sebastien GODARD <sysstat [at] orange.fr>
http://sebastien.godard.pagesperso-orange.fr/
author
#12 lore raw

Re: Too many programs called nfsiostat.

Quoted 31 lines · On Sat, 25 Jan 2014 16:45:48 +0100 Sebastien Godard <[email protected]> wrote:
Quoted 14 lines · Steve Dickson
Quoted 12 lines · Sebastien Godard
Quoted 11 lines · Steve Dickson
Quoted 7 lines · NeilBrown
Quoted 2 lines · On Wed, 22 Jan 2014 08:12:35 -0500 Steve Dickson <[email protected]> wrote:

On 21/01/14 19:24, NeilBrown wrote:
Is this version still actively being maintain?

Last change was 5 days ago.

https://github.com/sysstat/sysstat/commits/master/nfsiostat.c

I guess the question now is do they want to continue maintaining it or just merge the functionality into the nfs-utils version...

Quoted 7 lines
Quoted 1 line

This is no longer a question as I already answered it. Please *read* my previous mail.

I did... but thought Neil's mail was pointing out that some type of maintenance was happening... But if you say it's "no longer actively being maintained" I'll believe you... :-)

So what is the next step to deprecate the nfsiostat in sysstat?

In fact, the various patches applied to nfsiostat over the last few years were mainly cosmetic ones (changes in sysstat APIs, etc.) So I propose now to simply remove nfsiostat code from sysstat: Next sysstat version will rename nfsiostat (eg. to nfsiostat-sysstat) and the man page will indicate it is now obsolete and point to the version from nfs-utils. Then nfsiostat will be definitively removed sometime before the end of this year.

Quoted 2 lines

Regards,

Fantastic - a nice clear resolution, just what I was hoping for. Thanks a lot!

NeilBrown