ARM: hw_breakpoint: Do not use __cpuinitdata for dbg_cpu_pm_nb
Subsystems (3)
PATCH 1/1 ARM: hw_breakpoint: Do not use __cpuinitdata for dbg_cpu_pm_nb
We must not declare dbg_cpu_pm_nb as __cpuinitdata as we need it after system initialization for Suspend and CPUIdle.
This was done in commit 9a6eb310eaa5336b89a27a0bbb78da4bba35f6f1
ARM: hw_breakpoint: Debug powerdown support for self-hosted debug
---
Hi,
I've experienced a kernel oops while working on Suspend-To-Ram and CPUIdle on the Armadillo800EVA from Renesas. After echo mem >/sys/power/state I get:
Unable to handle kernel paging request at virtual address e7fddef0
PC is at 0xe7fddef0
LR is at notifier_call_chain+0x40/0x70
I've bisected the kernel to the commit 9a6eb310eaa5336b89a27a0bbb78da4bba35f6f1
ARM: hw_breakpoint: Debug powerdown support for self-hosted debug
and succeeded to fix it by removing the __cpuinitdata tag.
Cheers,
Bastian
arch/arm/kernel/hw_breakpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/kernel/hw_breakpoint.c +1 -1
@@ -1043,7 +1043,7 @@ static int dbg_cpu_pm_notify(struct notifier_block *self, unsigned long action,return NOTIFY_OK ; } -static struct notifier_block __cpuinitdata dbg_cpu_pm_nb = { +static struct notifier_block dbg_cpu_pm_nb = { .notifier_call = dbg_cpu_pm_notify, };
Signature · 1 line
1.7.9.5
PATCH 1/1 ARM: hw_breakpoint: Do not use __cpuinitdata for dbg_cpu_pm_nb
Quoted 7 lines · Bastian Hecht
We must not declare
dbg_cpu_pm_nbas__cpuinitdataas we need it after system initialization for Suspend and CPUIdle.This was done in commit
9a6eb310eaa5336b89a27a0bbb78da4bba35f6f1
ARM:hw_breakpoint: Debug powerdown support for self-hosted debugSigned-off-by Bastian Hecht <[email protected]>
Thanks Bastian, I'll take this into my tree.
Will
PATCH 1/1 ARM: hw_breakpoint: Do not use __cpuinitdata for dbg_cpu_pm_nb
2013/4/10 Will Deacon <[email protected]>:
Quoted 12 lines · Bastian Hecht
Quoted 7 lines
We must not declare
dbg_cpu_pm_nbas__cpuinitdataas we need it after system initialization for Suspend and CPUIdle.This was done in commit
9a6eb310eaa5336b89a27a0bbb78da4bba35f6f1
ARM:hw_breakpoint: Debug powerdown support for self-hosted debugSigned-off-by Bastian Hecht <[email protected]>Thanks Bastian, I'll take this into my tree.
Will
Nice, thanks!
PATCH 1/1 ARM: hw_breakpoint: Do not use __cpuinitdata for dbg_cpu_pm_nb
Quoted 8 lines · Bastian Hecht
2013/4/10 Will Deacon <[email protected]>:
Quoted 7 lines · Bastian Hecht
Quoted 6 lines
We must not declare
dbg_cpu_pm_nbas__cpuinitdataas we need it after system initialization for Suspend and CPUIdle.This was done in commit
9a6eb310eaa5336b89a27a0bbb78da4bba35f6f1
ARM:hw_breakpoint: Debug powerdown support for self-hosted debug
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Bastian Hecht <[email protected]>Thanks Bastian, I'll take this into my tree.
Will
Nice, thanks!
Hi Bastian,
thanks for catching this. Is my assumption right that you used an UP kernel?
I didn't catch this error during my Suspend-To-Ram/CPUidle tests because I tested only on SMP kernels where 'dbg_cpu_pm_nb' is placed into the .data and not in the .init.data section.
Will, we have the same issue in arch/arm/kernel/perf_event_cpu.c. Lorenzo is currently working on an appropriate patch.
-- Dietmar
-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
PATCH 1/1 ARM: hw_breakpoint: Do not use __cpuinitdata for dbg_cpu_pm_nb
Hi Dietmar,
2013/4/10 Dietmar Eggemann <[email protected]>:
Quoted 20 lines · Bastian Hecht
Quoted 19 lines
2013/4/10 Will Deacon <[email protected]>:
Quoted 15 lines · Bastian Hecht
Quoted 8 lines
We must not declare
dbg_cpu_pm_nbas__cpuinitdataas we need it after system initialization for Suspend and CPUIdle.This was done in commit
9a6eb310eaa5336b89a27a0bbb78da4bba35f6f1
ARM:hw_breakpoint: Debug powerdown support for self-hosted debugSigned-off-by Bastian Hecht <[email protected]>Thanks Bastian, I'll take this into my tree.
Will
Quoted 6 lines
Quoted 2 lines
Nice, thanks!
Hi Bastian,
thanks for catching this. Is my assumption right that you used an UP kernel?
Yes exactly, it's for a Cortex A9 UP core, so a UP kernel. Glad I could help.
Quoted 16 lines
I didn't catch this error during my Suspend-To-Ram/CPUidle tests because I tested only on SMP kernels where '
dbg_cpu_pm_nb' is placed into the .data and not in the .init.data section.Will, we have the same issue in
arch/arm/kernel/perf_event_cpu.c. Lorenzo is currently working on an appropriate patch.-- Dietmar
-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
PATCH 1/1 ARM: hw_breakpoint: Do not use __cpuinitdata for dbg_cpu_pm_nb
Quoted 2 lines · Bastian Hecht
Quoted 2 lines
Will, we have the same issue in
arch/arm/kernel/perf_event_cpu.c. Lorenzo is currently working on an appropriate patch.
I don't think we do. The __cpuinitdata annotation there is only used on a hotplug notifier, which should be fine.
Will
PATCH 1/1 ARM: hw_breakpoint: Do not use __cpuinitdata for dbg_cpu_pm_nb
Quoted 6 lines · Will Deacon
Quoted 2 lines · Bastian Hecht
Quoted 2 lines
Will, we have the same issue in
arch/arm/kernel/perf_event_cpu.c. Lorenzo is currently working on an appropriate patch.I don't think we do. The
__cpuinitdataannotation there is only used on a hotplug notifier, which should be fine.
You right, I got confused about what is already upstream.
-- Dietmar
Quoted 3 lines
Will
-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.