Skip to contentSkip to conversation

perf: Enable function tracing for perf core

PATCH In review Andi Kleen 3 participants 4 messages Mar 8, 2013 – Apr 10, 2013

Subsystems (2)
lore
Share & tools
lore

Andi Kleen

author
#0 lore raw

PATCH 1/1 perf: Enable function tracing for perf core

From: Andi Kleen <[email protected]>

According to Steven R. there is no reason left to not support function tracing for the perf core. This makes it easier to debug perf.

Don't remove -pg for the x86 and generic perf core.

---
 arch/x86/kernel/cpu/Makefile |    1 -
 kernel/events/Makefile       |    4 ----
 2 files changed, 0 insertions(+), 5 deletions(-)
arch/x86/kernel/cpu/Makefile +0 -1
index a0e067d..8eb5d28 100644
@@ -5,7 +5,6 @@
 # Don't trace early stages of a secondary CPU boot
 ifdef CONFIG_FUNCTION_TRACER
 CFLAGS_REMOVE_common.o = -pg
-CFLAGS_REMOVE_perf_event.o = -pg
 endif
 
 # Make sure load_percpu_segment has no stackprotector
kernel/events/Makefile +0 -4
index 103f5d1..a630994 100644
@@ -1,7 +1,3 @@
-ifdef CONFIG_FUNCTION_TRACER
-CFLAGS_REMOVE_core.o = -pg
-endif
-
 obj-y := core.o ring_buffer.o callchain.o
 
 obj-$(CONFIG_HAVE_HW_BREAKPOINT) += hw_breakpoint.o
Signature · 1 line
1.7.7.6
author
#1 lore raw
Quoted 7 lines · Andi Kleen

From: Andi Kleen <[email protected]>

According to Steven R. there is no reason left to not support function tracing for the perf core. This makes it easier to debug perf.

Don't remove -pg for the x86 and generic perf core.

Ping! patch is missing review.

Quoted 32 lines
---
 arch/x86/kernel/cpu/Makefile |    1 -
 kernel/events/Makefile       |    4 ----
 2 files changed, 0 insertions(+), 5 deletions(-)
arch/x86/kernel/cpu/Makefile +0 -1
index a0e067d..8eb5d28 100644
@@ -5,7 +5,6 @@
 # Don't trace early stages of a secondary CPU boot
 ifdef CONFIG_FUNCTION_TRACER
 CFLAGS_REMOVE_common.o = -pg
-CFLAGS_REMOVE_perf_event.o = -pg
 endif
 
 # Make sure load_percpu_segment has no stackprotector
kernel/events/Makefile +0 -4
index 103f5d1..a630994 100644
@@ -1,7 +1,3 @@
-ifdef CONFIG_FUNCTION_TRACER
-CFLAGS_REMOVE_core.o = -pg
-endif
-
 obj-y := core.o ring_buffer.o callchain.o
 
 obj-$(CONFIG_HAVE_HW_BREAKPOINT) += hw_breakpoint.o
Signature · 1 line
[email protected] -- Speaking for myself only
#2 lore raw
Quoted 4 lines · Andi Kleen
Quoted 2 lines · Andi Kleen

From: Andi Kleen <[email protected]>

Quoted 8 lines
Quoted 5 lines

According to Steven R. there is no reason left to not support function tracing for the perf core. This makes it easier to debug perf.

Don't remove -pg for the x86 and generic perf core.

Ping! patch is missing review.

This needs an acked-by from either Peter or Frederic.

-- Steve

Quoted 34 lines
Quoted 33 lines
---
 arch/x86/kernel/cpu/Makefile |    1 -
 kernel/events/Makefile       |    4 ----
 2 files changed, 0 insertions(+), 5 deletions(-)
arch/x86/kernel/cpu/Makefile +0 -1
index a0e067d..8eb5d28 100644
@@ -5,7 +5,6 @@
 # Don't trace early stages of a secondary CPU boot
 ifdef CONFIG_FUNCTION_TRACER
 CFLAGS_REMOVE_common.o = -pg
-CFLAGS_REMOVE_perf_event.o = -pg
 endif
 
 # Make sure load_percpu_segment has no stackprotector
kernel/events/Makefile +0 -4
index 103f5d1..a630994 100644
@@ -1,7 +1,3 @@
-ifdef CONFIG_FUNCTION_TRACER
-CFLAGS_REMOVE_core.o = -pg
-endif
-
 obj-y := core.o ring_buffer.o callchain.o
 
 obj-$(CONFIG_HAVE_HW_BREAKPOINT) += hw_breakpoint.o
#3 lore raw
Quoted 9 lines · Steven Rostedt
Quoted 8 lines · Andi Kleen
Quoted 6 lines · Andi Kleen

From: Andi Kleen <[email protected]>

According to Steven R. there is no reason left to not support function tracing for the perf core. This makes it easier to debug perf.

Quoted 6 lines
Quoted 4 lines
Quoted 1 line

Don't remove -pg for the x86 and generic perf core.

Ping! patch is missing review.

This needs an acked-by from either Peter or Frederic.

I think this was mentioned before: there was measurable overhead due to this, so that has to be re-measured.

Thanks,

Ingo