Skip to contentSkip to conversation

cloud9: add EnvironmentFile

PATCH In review Jason Kridner 3 participants 4 messages Apr 8, 2013 – Apr 10, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cloud9: add EnvironmentFile

* Allows specification of NODE_PATH

---
 .../recipes-devtools/cloud9/cloud9/cloud9.service  |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
meta-systemd/meta-oe/recipes-devtools/cloud9/cloud9/cloud9.service +1 -0
index 714b465..54a9db0 100644
@@ -3,6 +3,7 @@ Description=Cloud9 IDE
 ConditionPathExists=|/var/lib/cloud9
 
 [Service]
+EnvironmentFile=-/etc/conf.d/node
 ExecStart=/usr/bin/node4 /usr/share/cloud9/bin/cloud9.js -l 0.0.0.0 -w /var/lib/cloud9 -p 3000
 
 [Install]
Signature · 1 line
1.7.8.6
#1 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 08-04-13 09:57, Jason Kridner schreef:

Quoted 14 lines

* Allows specification of NODE_PATH

.../recipes-devtools/cloud9/cloud9/cloud9.service | 1 + 1 files
changed, 1 insertions(+), 0 deletions(-)

diff --git a/meta-systemd/meta-oe/recipes-devtools/cloud9/cloud9/cloud9.service b/meta-systemd/meta-oe/recipes-devtools/cloud9/cloud9/cloud9.service index 714b465..54a9db0 100644 --- a/meta-systemd/meta-oe/recipes-devtools/cloud9/cloud9/cloud9.service +++ b/meta-systemd/meta-oe/recipes-devtools/cloud9/cloud9/cloud9.service @@ -3,6 +3,7 @@ Description=Cloud9 IDE ConditionPathExists=|/var/lib/cloud9

Quoted 5 lines

[Service] +EnvironmentFile=-/etc/conf.d/node ExecStart=/usr/bin/node4 /usr/share/cloud9/bin/cloud9.js -l 0.0.0.0 -w /var/lib/cloud9 -p 3000

[Install]

It's a bit late now, but this shouldn't go in, it introduces a gentoo-ism (/etc/conf.d) that we don't want.

Martin, can you revert it please?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFRZY5fMkyGM64RGpERAsUrAKCpirNbZj9g6fdigv2+GZUqSksGVQCeJths zlp4sG6jcgBF1RjzikHwksw=
=6TFx
-----END PGP SIGNATURE-----

#2 lore raw
Quoted 21 lines · Koen Kooi

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 08-04-13 09:57, Jason Kridner schreef:

Quoted 17 lines

* Allows specification of NODE_PATH

.../recipes-devtools/cloud9/cloud9/cloud9.service | 1 + 1 files
changed, 1 insertions(+), 0 deletions(-)

diff --git a/meta-systemd/meta-oe/recipes-devtools/cloud9/cloud9/cloud9.service b/meta-systemd/meta-oe/recipes-devtools/cloud9/cloud9/cloud9.service index 714b465..54a9db0 100644 --- a/meta-systemd/meta-oe/recipes-devtools/cloud9/cloud9/cloud9.service +++ b/meta-systemd/meta-oe/recipes-devtools/cloud9/cloud9/cloud9.service @@ -3,6 +3,7 @@ Description=Cloud9 IDE ConditionPathExists=|/var/lib/cloud9

[Service] +EnvironmentFile=-/etc/conf.d/node ExecStart=/usr/bin/node4 /usr/share/cloud9/bin/cloud9.js -l 0.0.0.0 -w /var/lib/cloud9 -p 3000

Quoted 6 lines
Quoted 2 lines

[Install]

It's a bit late now, but this shouldn't go in, it introduces a gentoo-ism (/etc/conf.d) that we don't want.

Ah, sorry about that.

Quoted 1 line

Martin, can you revert it please?

Sure

Quoted 14 lines

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFRZY5fMkyGM64RGpERAsUrAKCpirNbZj9g6fdigv2+GZUqSksGVQCeJths zlp4sG6jcgBF1RjzikHwksw=
=6TFx
-----END PGP SIGNATURE-----

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#3 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 10-04-13 18:17, Martin Jansa schreef:

Quoted 4 lines

On Wed, Apr 10, 2013 at 06:07:59PM +0200, Koen Kooi wrote: Op 08-04-13 09:57, Jason Kridner schreef:

Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

* Allows specification of NODE_PATH

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines

.../recipes-devtools/cloud9/cloud9/cloud9.service | 1 + 1
files changed, 1 insertions(+), 0 deletions(-)

(quoted diff) +0 -0

a/meta-systemd/meta-oe/recipes-devtools/cloud9/cloud9/cloud9.service

b/meta-systemd/meta-oe/recipes-devtools/cloud9/cloud9/cloud9.service

Quoted 18 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines

index 714b465..54a9db0 100644 --- a/meta-systemd/meta-oe/recipes-devtools/cloud9/cloud9/cloud9.service
+++
b/meta-systemd/meta-oe/recipes-devtools/cloud9/cloud9/cloud9.service

(quoted diff) +0 -0
@@ -3,6 +3,7 @@ Description=Cloud9 IDE

ConditionPathExists=|/var/lib/cloud9

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

[Service] +EnvironmentFile=-/etc/conf.d/node ExecStart=/usr/bin/node4 /usr/share/cloud9/bin/cloud9.js -l 0.0.0.0 -w /var/lib/cloud9 -p 3000

[Install]

It's a bit late now, but this shouldn't go in, it introduces a gentoo-ism (/etc/conf.d) that we don't want.

Quoted 3 lines
Quoted 1 line

Ah, sorry about that.

Martin, can you revert it please?

Or have a look at the 8 patches I sent, the revert is part of that :) -----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFRZZIZMkyGM64RGpERAjvsAJ9IyCRx7u+PHUOFMxCtOpilopAynwCffAIL 8njlZ3JTh//ARcoaPaJIdpQ=
=j6Do
-----END PGP SIGNATURE-----