Skip to contentSkip to conversation

ARM: pci: create pci_common_init_dev()

PATCH New Andrew Murray 1 participant 1 message Apr 15, 2013 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH v4 1/1 ARM: pci: create pci_common_init_dev()

Quoted 28 lines · Linus Walleij

When working with device tree support for PCI on ARM you run into a problem when mapping IRQs from the device tree irqmaps:
doing this the code in drivers/of/of_pci_irq.c will try to find the OF node on the root bridge and this fails, because bus->dev.of_node is NULL, and that in turn boils down to the fact that pci_set_bus_of_node() has called pcibios_get_phb_of_node() from drivers/pci/of.c to obtain the OF node of the bridge or its parent and none is set and thus NULL is returned.

Fix this by adding an additional parent argument API for registering PCI bridges on the ARM architecture called pci_common_init_dev(), and pass along this parent to pci_scan_root_bus() called from pcibios_init_hw() in bios32.c and voila: the IRQ mappings start working:
the OF node can be retrieved from the parent.

Create the old pci_common_init() as a wrapper around the new call.

Cc Mike Rapoport <[email protected]>
Cc Russell King <[email protected]>
Cc Ralf Baechle <[email protected]>
Cc Andrew Murray <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Benjamin Herrenschmitt <[email protected]>
Quoted 5 lines

---
ChangeLog v3->v4:
- Put opening bracket on its own line.
- Use the proper rmk+kernel address for Russells CC.
---