drivers:acpi: Fix wrong parameter passed to memblock_reserve
PATCH 1/1 drivers:acpi: Fix wrong parameter passed to memblock_reserve
The parameter of memblock_reserve is start address, and size, not address range.
--- drivers/acpi/osl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/osl.c +1 -1
@@ -641,7 +641,7 @@ void __init acpi_initrd_override(void *data, size_t size)* Both memblock_reserve and e820_add_region (via arch_reserve_mem_area) * works fine. */ -memblock_reserve (acpi_tables_addr, acpi_tables_addr + all_tables_size); +memblock_reserve (acpi_tables_addr, all_tables_size);arch_reserve_mem_area (acpi_tables_addr, all_tables_size); p =early_ioremap (acpi_tables_addr, all_tables_size);
Signature · 1 line
1.7.12.4.dirty
Quoted 14 lines · Wang YanQing
The parameter of
memblock_reserveis start address, and size, not address range.Signed-off-by Wang YanQing <[email protected]>--- drivers/acpi/osl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/acpi/osl.c +0
-0
drivers/acpi/osl.c void __init acpi_initrd_override(void *data, size_t size) · line 645
Quoted 6 lines
drivers/acpi/osl.c +1
-1@@ -641,7 +641,7 @@ void __init acpi_initrd_override(void *data, size_t size)* Both memblock_reserve and e820_add_region (via arch_reserve_mem_area) * works fine. */ -memblock_reserve (acpi_tables_addr, acpi_tables_addr + all_tables_size); +memblock_reserve (acpi_tables_addr, all_tables_size);arch_reserve_mem_area (acpi_tables_addr, all_tables_size);
And it should go to stable for v3.8
Quoted 24 lines · Yinghai Lu
Quoted 14 lines · Wang YanQing
The parameter of
memblock_reserveis start address, and size, not address range.Signed-off-by Wang YanQing <[email protected]>--- drivers/acpi/osl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/acpi/osl.c +0
-0drivers/acpi/osl.c void __init acpi_initrd_override(void *data, size_t size) · line 645
Quoted 6 lines
drivers/acpi/osl.c +1
-1@@ -641,7 +641,7 @@ void __init acpi_initrd_override(void *data, size_t size)* Both memblock_reserve and e820_add_region (via arch_reserve_mem_area) * works fine. */ -memblock_reserve (acpi_tables_addr, acpi_tables_addr + all_tables_size); +memblock_reserve (acpi_tables_addr, all_tables_size);arch_reserve_mem_area (acpi_tables_addr, all_tables_size);Acked-by Yinghai Lu <[email protected]>
Quoted 1 line
And it should go to stable for v3.8
Hi all, I think this fix should be merged before 3.9 is out, it make no much sense to backport it for 3.9 later, but we don't have much time before 3.9 is out, so...
Thanks.
Rafael J. Wysocki
AppliedQuoted 25 lines · Wang YanQing
Quoted 24 lines · Yinghai Lu
Quoted 14 lines · Wang YanQing
The parameter of
memblock_reserveis start address, and size, not address range.Signed-off-by Wang YanQing <[email protected]>--- drivers/acpi/osl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/acpi/osl.c +0
-0drivers/acpi/osl.c void __init acpi_initrd_override(void *data, size_t size) · line 645
Quoted 6 lines
drivers/acpi/osl.c +1
-1@@ -641,7 +641,7 @@ void __init acpi_initrd_override(void *data, size_t size)* Both memblock_reserve and e820_add_region (via arch_reserve_mem_area) * works fine. */ -memblock_reserve (acpi_tables_addr, acpi_tables_addr + all_tables_size); +memblock_reserve (acpi_tables_addr, all_tables_size);arch_reserve_mem_area (acpi_tables_addr, all_tables_size);Acked-by Yinghai Lu <[email protected]>
Quoted 7 lines
Quoted 1 line
And it should go to stable for v3.8
Hi all, I think this fix should be merged before 3.9 is out, it make no much sense to backport it for 3.9 later, but we don't have much time before 3.9 is out, so...
Thanks.
Applied, but please send ACPI patches (and especially urgent fixes) to [email protected] in the future.
Thanks,
Rafael
Signature · 2 lines
I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.