megaraid_sas: release lock on error path
Subsystems (3)
PATCH 1/1 megaraid_sas: release lock on error path
We should unlock here before returning.
Signed-off-by Dan Carpenter <[email protected]>
drivers/scsi/megaraid/megaraid_sas_base.c +2 -1
@@ -4931,11 +4931,12 @@ static int megasas_mgmt_ioctl_fw(struct file *file, unsigned long arg)printk (KERN_ERR "megaraid_sas: timed out while" "waiting for HBA to recover\n" ); error = -ENODEV ; - goto out_kfree_ioc; + goto out_up; }spin_unlock_irqrestore (&instance->hba_lock, flags); error =megasas_mgmt_fw_ioctl (instance, user_ioc, ioc); + out_up:up (&instance->ioctl_sem); out_kfree_ioc:
Quoted 23 lines · Dan Carpenter
We should unlock here before returning.
Signed-off-by Dan Carpenter <[email protected]>drivers/scsi/megaraid/megaraid_sas_base.c +2
-2@@ -4931,11 +4931,12 @@ static int megasas_mgmt_ioctl_fw(struct file *file, unsigned long arg)printk (KERN_ERR "megaraid_sas: timed out while" "waiting for HBA to recover\n" ); error = -ENODEV ; - goto out_kfree_ioc; + goto out_up; }spin_unlock_irqrestore (&instance->hba_lock, flags); error =megasas_mgmt_fw_ioctl (instance, user_ioc, ioc); + out_up:up (&instance->ioctl_sem); out_kfree_ioc: --
Quoted 3 lines
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Thanks Dan, this looks good.
Acked-by Adam Radford <[email protected]>
-Adam