libserial: new package
PATCH 1/1 libserial: new package
From: Simon Dawson <[email protected]>
--- package/Config.in | 1 + package/libserial/Config.in | 11 ++++ .../libserial-0000-missing-includes.patch | 54 ++++++++++++++++++++ package/libserial/libserial.mk | 13 +++++ 4 files changed, 79 insertions(+) create mode 100644 package/libserial/Config.in create mode 100644 package/libserial/libserial-0000-missing-includes.patch create mode 100644 package/libserial/libserial.mk
package/Config.in +1 -0
@@ -463,6 +463,7 @@ source "package/libhid/Config.in" source "package/libiqrf/Config.in" source "package/libnfc/Config.in" source "package/libnfc-llcp/Config.in" +source "package/libserial/Config.in" source "package/libusb/Config.in" source "package/libusb-compat/Config.in" source "package/libv4l/Config.in"
package/libserial/Config.in new file +11 -0
@@ -0,0 +1,11 @@ +config BR2_PACKAGE_LIBSERIAL + bool "libserial" + depends on BR2_INSTALL_LIBSTDCPP + help + Simplified serial port programming in C++ under POSIX operating + systems. + + http://libserial.sourceforge.net/ + +comment "libserial requires a toolchain with C++ support enabled" + depends on !BR2_INSTALL_LIBSTDCPP
package/libserial/libserial-0000-missing-includes.patch new file +54 -0
54 lines not on this page · raw message
package/libserial/libserial.mk new file +13 -0
@@ -0,0 +1,13 @@ +############################################################# +# +# libserial +# +############################################################# + +LIBSERIAL_VERSION = 0.5.2 +LIBSERIAL_SITE = http://prdownloads.sourceforge.net/libserial +LIBSERIAL_INSTALL_STAGING = YES +LIBSERIAL_LICENSE = GPLv2+ +LIBSERIAL_LICENSE_FILES = COPYING + +$(eval $(autotools-package))
Signature · 1 line
1.7.10.4
PATCH 1/1 libserial: new package
Simon,
package/libserial/libserial.mk line 8
Quoted 2 lines · spdawson at gmail.com
package/libserial/libserial.mk new file +2
-0+LIBSERIAL_VERSION = 0.5.2 +LIBSERIAL_SITE = http://prdownloads.sourceforge.net/libserial
I think prdownloads.sourceforge.net is just one particular mirror of Sourceforge, and we now prefer to use http://downloads.sourceforge.net,
which automatically redirects to one available mirror. See all existing BR packages whose upstream tarball is hosted on Github.
Besides that, your patch is numbered 0000, while the other packages that we have typically have the patches numbered from 1. This is also what git format-patch does by default (numbering from 1). We don't have a strict policy with written rules about this, but the common practice apparently is to start the patches from 1.
Thanks!
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/1 libserial: new package
Hi Thomas, thanks for looking at this.
Quoted 4 lines · Thomas Petazzoni
I think prdownloads.sourceforge.net is just one particular mirror of Sourceforge, and we now prefer to use http://downloads.sourceforge.net,
which automatically redirects to one available mirror. See all existing BR packages whose upstream tarball is hosted on Github.
Okay; will fix this.
Quoted 2 lines
Besides that, your patch is numbered 0000, while the other packages that we have typically have the patches numbered from 1.
Okay, understood. I've actually just realised that the patch is unnecessary if we use upstream version 0.6.0rc1; so I'll remove the patch altogether in the next iteration.
Simon.