devcg: remove parent_cgroup.
Subsystems (2)
PATCH 1/1 devcg: remove parent_cgroup.
In devcgroup_css_alloc(), there is no longer need for parent_cgroup. bd2953ebbb("devcg: propagate local changes down the hierarchy") made the variable parent_cgroup redundant. This patch removes parent_cgroup from devcgroup_css_alloc().
--- security/device_cgroup.c | 2 -- 1 file changed, 2 deletions(-)
security/device_cgroup.c +0 -2
@@ -236,7 +236,6 @@ static void devcgroup_offline(struct cgroup *cgroup)static struct cgroup_subsys_state *devcgroup_css_alloc (struct cgroup *cgroup) {struct dev_cgroup *dev_cgroup; -struct cgroup *parent_cgroup; dev_cgroup =kzalloc (sizeof (*dev_cgroup),GFP_KERNEL );if (!dev_cgroup)
@@ -244,7 +243,6 @@ static struct cgroup_subsys_state *devcgroup_css_alloc(struct cgroup *cgroup)INIT_LIST_HEAD (&dev_cgroup->exceptions);INIT_LIST_HEAD (&dev_cgroup->propagate_pending); dev_cgroup->behavior =DEVCG_DEFAULT_NONE ; - parent_cgroup = cgroup->parent;return &dev_cgroup->css; }
Signature · 1 line
1.8.1.4
Quoted 23 lines · Rami Rosen
In
devcgroup_css_alloc(), there is no longer need forparent_cgroup.bd2953ebbb("devcg: propagate local changes down the hierarchy")made the variableparent_cgroupredundant. This patch removesparent_cgroupfromdevcgroup_css_alloc().Signed-off-by Rami Rosen <[email protected]>--- security/device_cgroup.c | 2 -- 1 file changed, 2 deletions(-)security/device_cgroup.c +0
-1@@ -236,7 +236,6 @@ static void devcgroup_offline(struct cgroup *cgroup)static struct cgroup_subsys_state *devcgroup_css_alloc (struct cgroup *cgroup) {struct dev_cgroup *dev_cgroup; -struct cgroup *parent_cgroup; dev_cgroup =kzalloc (sizeof (*dev_cgroup),GFP_KERNEL );if (!dev_cgroup)
security/device_cgroup.c static struct cgroup_subsys_state *devcgroup_css_alloc(struct cgroup *cgroup) · line 248
Quoted 7 lines
security/device_cgroup.c +0
-1@@ -244,7 +243,6 @@ static struct cgroup_subsys_state *devcgroup_css_alloc(struct cgroup *cgroup)INIT_LIST_HEAD (&dev_cgroup->exceptions);INIT_LIST_HEAD (&dev_cgroup->propagate_pending); dev_cgroup->behavior =DEVCG_DEFAULT_NONE ; - parent_cgroup = cgroup->parent;return &dev_cgroup->css; }
oops
ACK
Signature · 1 line
Aristeu
Serge Hallyn
Acked-byQuoted 29 lines · Aristeu Rozanski
Quoted 28 lines · Rami Rosen
In
devcgroup_css_alloc(), there is no longer need forparent_cgroup.bd2953ebbb("devcg: propagate local changes down the hierarchy")made the variableparent_cgroupredundant. This patch removesparent_cgroupfromdevcgroup_css_alloc().Signed-off-by Rami Rosen <[email protected]>--- security/device_cgroup.c | 2 -- 1 file changed, 2 deletions(-)security/device_cgroup.c +0
-2@@ -236,7 +236,6 @@ static void devcgroup_offline(struct cgroup *cgroup)static struct cgroup_subsys_state *devcgroup_css_alloc (struct cgroup *cgroup) {struct dev_cgroup *dev_cgroup; -struct cgroup *parent_cgroup; dev_cgroup =kzalloc (sizeof (*dev_cgroup),GFP_KERNEL );if (!dev_cgroup)@@ -244,7 +243,6 @@ static struct cgroup_subsys_state *devcgroup_css_alloc(struct cgroup *cgroup)INIT_LIST_HEAD (&dev_cgroup->exceptions);INIT_LIST_HEAD (&dev_cgroup->propagate_pending); dev_cgroup->behavior =DEVCG_DEFAULT_NONE ; - parent_cgroup = cgroup->parent;
Quoted 6 lines
security/device_cgroup.c static struct cgroup_subsys_state *devcgroup_css_alloc(struct cgroup *cgroup) · line 248
Quoted 2 lines
security/device_cgroup.c +0
-0return &dev_cgroup->css; }oops
ACK
Not seeing the patches this is based on in Linus' tree yet, but given the context above I don't see how it could not be right :)
Quoted 35 lines · Serge Hallyn
Quoted 34 lines · Aristeu Rozanski
Quoted 23 lines · Rami Rosen
In
devcgroup_css_alloc(), there is no longer need forparent_cgroup.bd2953ebbb("devcg: propagate local changes down the hierarchy")made the variableparent_cgroupredundant. This patch removesparent_cgroupfromdevcgroup_css_alloc().Signed-off-by Rami Rosen <[email protected]>--- security/device_cgroup.c | 2 -- 1 file changed, 2 deletions(-)security/device_cgroup.c +0
-1@@ -236,7 +236,6 @@ static void devcgroup_offline(struct cgroup *cgroup)static struct cgroup_subsys_state *devcgroup_css_alloc (struct cgroup *cgroup) {struct dev_cgroup *dev_cgroup; -struct cgroup *parent_cgroup; dev_cgroup =kzalloc (sizeof (*dev_cgroup),GFP_KERNEL );if (!dev_cgroup)security/device_cgroup.c static struct cgroup_subsys_state *devcgroup_css_alloc(struct cgroup *cgroup) · line 248
Quoted 7 lines
security/device_cgroup.c +0
-1@@ -244,7 +243,6 @@ static struct cgroup_subsys_state *devcgroup_css_alloc(struct cgroup *cgroup)INIT_LIST_HEAD (&dev_cgroup->exceptions);INIT_LIST_HEAD (&dev_cgroup->propagate_pending); dev_cgroup->behavior =DEVCG_DEFAULT_NONE ; - parent_cgroup = cgroup->parent;return &dev_cgroup->css; }oops
Quoted 4 lines
Quoted 1 line
ACK
Not seeing the patches this is based on in Linus' tree yet, but given the context above I don't see how it could not be right :)
they're on Tejun's tree
Signature · 1 line
Aristeu
Quoted 6 lines · Rami Rosen
In
devcgroup_css_alloc(), there is no longer need forparent_cgroup.bd2953ebbb("devcg: propagate local changes down the hierarchy")made the variableparent_cgroupredundant. This patch removesparent_cgroupfromdevcgroup_css_alloc().Signed-off-by Rami Rosen <[email protected]>
Applied to cgroup/for-3.10.
Thanks.
Signature · 1 line
tejun
A message that is not in the archive (sent off-list or not yet received): 1366143895-21535-1-git-send-email-ramirose-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Tejun Heo
AppliedQuoted 6 lines · Rami Rosen
In
devcgroup_css_alloc(), there is no longer need forparent_cgroup.bd2953ebbb("devcg: propagate local changes down the hierarchy")made the variableparent_cgroupredundant. This patch removesparent_cgroupfromdevcgroup_css_alloc().Signed-off-by Rami Rosen <[email protected]>
Applied to cgroup/for-3.10.
Thanks.
Signature · 1 line
tejun