kexec, i386, bzImage: Remove unnecessary symbol value get
Subsystems (2)
PATCH 1/1 kexec, i386, bzImage: Remove unnecessary symbol value get
From: Zhang Yanfei <[email protected]>
We needn't get the initial values for every regs in regs32 from symbol entry32_regs for we will manually initialize them one by one next:
/*
* Initialize the 32bit start information.
*/
regs32.eax = 0; /* unused */
regs32.ebx = 0; /* 0 == boot not AP processor start */
regs32.ecx = 0; /* unused */
regs32.edx = 0; /* unused */
regs32.esi = setup_base; /* kernel parameters */
regs32.edi = 0; /* unused */
regs32.esp = elf_rel_get_addr(&info->rhdr, "stack_end"); /* stack, unused */
regs32.ebp = 0; /* unused */
regs32.eip = kernel32_load_addr; /* kernel entry point */Signed-off-by Zhang Yanfei <[email protected]>
--- kexec/arch/i386/kexec-bzImage.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
kexec/arch/i386/kexec-bzImage.c +1 -2
@@ -310,9 +310,8 @@ int do_bzImage_load(struct kexec_info *info,if (real_mode_entry)elf_rel_get_symbol (&info->rhdr,"entry16_regs" , ®s16,sizeof (regs16)); -elf_rel_get_symbol (&info->rhdr,"entry32_regs" , ®s32,sizeof (regs32)); -/* +/* * Initialize the 32bit start information. */ regs32.eax =0 ;/* unused */
Signature · 7 lines
1.7.1 _______________________________________________ kexec mailing list [email protected] http://lists.infradead.org/mailman/listinfo/kexec
Quoted 19 lines · Zhang Yanfei
From: Zhang Yanfei <[email protected]>
We needn't get the initial values for every regs in regs32 from symbol
entry32_regsfor we will manually initialize them one by one next:/* * Initialize the 32bit start information. */ regs32.eax = 0; /* unused */ regs32.ebx = 0; /* 0 == boot not AP processor start */ regs32.ecx = 0; /* unused */ regs32.edx = 0; /* unused */ regs32.esi = setup_base; /* kernel parameters */ regs32.edi = 0; /* unused */ regs32.esp = elf_rel_get_addr(&info->rhdr, "stack_end"); /* stack, unused */ regs32.ebp = 0; /* unused */ regs32.eip = kernel32_load_addr; /* kernel entry point */
Quoted 1 line
Signed-off-by Zhang Yanfei <[email protected]>
Thanks, nice clean-up.
I have applied this patch.
Quoted 22 lines
--- kexec/arch/i386/kexec-bzImage.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)kexec/arch/i386/kexec-bzImage.c +1
-2@@ -310,9 +310,8 @@ int do_bzImage_load(struct kexec_info *info,if (real_mode_entry)elf_rel_get_symbol (&info->rhdr,"entry16_regs" , ®s16,sizeof (regs16)); -elf_rel_get_symbol (&info->rhdr,"entry32_regs" , ®s32,sizeof (regs32)); -/* +/* * Initialize the 32bit start information. */ regs32.eax =0 ;/* unused */ Signature · 1 line
1.7.1
_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec