Skip to contentSkip to conversation

dvb-frontends: lg2160: dubious one-bit signed bitfield

PATCH New Dan Carpenter 1 participant 1 message Apr 17, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dvb-frontends: lg2160: dubious one-bit signed bitfield

Sparse complains that these are "dubious one-bit signed bitfields" and the comment says it was intended to be 1 and 0 instead of -1 and 0.

drivers/media/dvb-frontends/lg2160.h +2 -2
index a5f0368..194a07a 100644
@@ -57,10 +57,10 @@ struct lg2160_config {
 	u16 if_khz;
 
 	/* disable i2c repeater - 0:repeater enabled 1:repeater disabled */
-	int deny_i2c_rptr:1;
+	unsigned int deny_i2c_rptr:1;
 
 	/* spectral inversion - 0:disabled 1:enabled */
-	int spectral_inversion:1;
+	unsigned int spectral_inversion:1;
 
 	unsigned int output_if;
 	enum lg2160_spi_clock spi_clock;