Skip to contentSkip to conversation

libosd: remover duplicate __bitwise annotation

PATCH In review Dan Carpenter 2 participants 2 messages Apr 17, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libosd: remover duplicate __bitwise annotation

__be32 is already a __bitwise type so we don't need the second __bitwise here. It causes a Sparse error:
include/scsi/osd_protocol.h:110:26: error: invalid modifier

include/scsi/osd_protocol.h +1 -1
index a6026da..25ac628 100644
@@ -107,7 +107,7 @@ enum osd_attributes_mode {
  *		int exponent: 04;
  *	}
  */
-typedef __be32 __bitwise osd_cdb_offset;
+typedef __be32 osd_cdb_offset;
 
 enum {
 	OSD_OFFSET_UNUSED = 0xFFFFFFFF,
#1 lore raw
Quoted 5 lines · Dan Carpenter

__be32 is already a __bitwise type so we don't need the second __bitwise here. It causes a Sparse error:
include/scsi/osd_protocol.h:110:26: error: invalid modifier

ACK

Quoted 19 lines
include/scsi/osd_protocol.h +1 -1
index a6026da..25ac628 100644
@@ -107,7 +107,7 @@ enum osd_attributes_mode {
  *		int exponent: 04;
  *	}
  */
-typedef __be32 __bitwise osd_cdb_offset;
+typedef __be32 osd_cdb_offset;
 
 enum {
 	OSD_OFFSET_UNUSED = 0xFFFFFFFF,

_______________________________________________
osd-dev mailing list
[email protected]
http://mailman.open-osd.org/mailman/listinfo/osd-dev