drivers/gpu/drm/nouveau/nouveau_acpi.c:420: undefined reference to `acpi_video_get_edid'
Subsystems (3)
Hi,
I'm guessing someone has already triggered this on latest Linus' tree and has a fix?
drivers/built-in.o: In function `nouveau_acpi_edid':
/w/kernel/linux/drivers/gpu/drm/nouveau/nouveau_acpi.c:420: undefined reference to `acpi_video_get_edid'
make: *** [vmlinux] Error 1
Btw, I got CONFIG_ACPI_VIDEO=m while CONFIG_DRM_NOUVEAU=y and this is probably the reason for the vmlinux link error.
Thanks.
Signature · 5 lines
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--PATCH 1/1 drm/nouveau: always select ACPI_VIDEO if ACPI is enabled.
Hey,
Op 04-02-13 16:23, Borislav Petkov schreef:
Quoted 5 lines
Hi,
I'm guessing someone has already triggered this on latest Linus' tree and has a fix?
Quoted 9 lines
drivers/built-in.o: In function `nouveau_acpi_edid':
/w/kernel/linux/drivers/gpu/drm/nouveau/nouveau_acpi.c:420: undefined reference to `acpi_video_get_edid'
make: *** [vmlinux] Error 1Btw, I got
CONFIG_ACPI_VIDEO=mwhileCONFIG_DRM_NOUVEAU=yand this is probably the reason for the vmlinux link error.Thanks.
Does this fix things?
-->8
Having nouveau builtin would still allow ACPI_VIDEO to be used as external module if some of the deps for acpi_video have not been met, which would result in a linking failure. Solve this by only requiring ACPI && X86 to select ACPI_VIDEO.
---
drivers/gpu/drm/nouveau/Kconfig +1 -1
@@ -10,7 +10,7 @@ config DRM_NOUVEAU select FB select FRAMEBUFFER_CONSOLE if !EXPERT select FB_BACKLIGHT if DRM_NOUVEAU_BACKLIGHT - select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL && INPUT + select ACPI_VIDEO if ACPI && X86 select ACPI_WMI if ACPI select MXM_WMI if ACPI select POWER_SUPPLY
Re: [PATCH] drm/nouveau: always select ACPI_VIDEO if ACPI is enabled.
Quoted 31 lines · Maarten Lankhorst
Hey,
Op 04-02-13 16:23, Borislav Petkov schreef:
Quoted 5 lines
Hi,
I'm guessing someone has already triggered this on latest Linus' tree and has a fix?
Quoted 9 lines
drivers/built-in.o: In function `nouveau_acpi_edid':
/w/kernel/linux/drivers/gpu/drm/nouveau/nouveau_acpi.c:420: undefined reference to `acpi_video_get_edid'
make: *** [vmlinux] Error 1Btw, I got
CONFIG_ACPI_VIDEO=mwhileCONFIG_DRM_NOUVEAU=yand this is probably the reason for the vmlinux link error.Thanks.
Does this fix things?
-->8
Having nouveau builtin would still allowACPI_VIDEOto be used as external module if some of the deps foracpi_videohave not been met, which would result in a linking failure. Solve this by only requiring ACPI && X86 to selectACPI_VIDEO.Signed-off-by Maarten Lankhorst <[email protected]>---
drivers/gpu/drm/nouveau/Kconfig +0
-0
drivers/gpu/drm/nouveau/Kconfig config DRM_NOUVEAU · line 16
Quoted 8 lines
drivers/gpu/drm/nouveau/Kconfig +1
-1@@ -10,7 +10,7 @@ config DRM_NOUVEAU select FB select FRAMEBUFFER_CONSOLE if !EXPERT select FB_BACKLIGHT if DRM_NOUVEAU_BACKLIGHT - select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL && INPUT + select ACPI_VIDEO if ACPI && X86 select ACPI_WMI if ACPI select MXM_WMI if ACPI select POWER_SUPPLY
Not really.
drivers/built-in.o: In function `acpi_video_bus_put_one_device':/root/kernel/linux/drivers/acpi/video.c:1407: undefined reference to thermal_cooling_device_unregister' drivers/built-in.o: In function acpi_video_device_find_cap':/root/kernel/linux/drivers/acpi/video.c:842: undefined reference to `thermal_cooling_device_register'
make: *** [vmlinux] Error 1
It is CONFIG_THERMAL=m this time.
Thanks.
Signature · 5 lines
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--PATCH v2 1/1 drm/nouveau: always select ACPI_VIDEO if ACPI is enabled.
Op 05-02-13 15:52, Borislav Petkov schreef:
Quoted 48 lines · Maarten Lankhorst
Quoted 31 lines
Hey,
Op 04-02-13 16:23, Borislav Petkov schreef:
Quoted 5 lines
Hi,
I'm guessing someone has already triggered this on latest Linus' tree and has a fix?
Quoted 9 lines
drivers/built-in.o: In function `nouveau_acpi_edid':
/w/kernel/linux/drivers/gpu/drm/nouveau/nouveau_acpi.c:420: undefined reference to `acpi_video_get_edid'
make: *** [vmlinux] Error 1Btw, I got
CONFIG_ACPI_VIDEO=mwhileCONFIG_DRM_NOUVEAU=yand this is probably the reason for the vmlinux link error.Thanks.
Does this fix things?
-->8
Having nouveau builtin would still allowACPI_VIDEOto be used as external module if some of the deps foracpi_videohave not been met, which would result in a linking failure. Solve this by only requiring ACPI && X86 to selectACPI_VIDEO.Signed-off-by Maarten Lankhorst <[email protected]>---
drivers/gpu/drm/nouveau/Kconfig +0
-0drivers/gpu/drm/nouveau/Kconfig config DRM_NOUVEAU · line 16
Quoted 8 lines
drivers/gpu/drm/nouveau/Kconfig +1
-1@@ -10,7 +10,7 @@ config DRM_NOUVEAU select FB select FRAMEBUFFER_CONSOLE if !EXPERT select FB_BACKLIGHT if DRM_NOUVEAU_BACKLIGHT - select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL && INPUT + select ACPI_VIDEO if ACPI && X86 select ACPI_WMI if ACPI select MXM_WMI if ACPI select POWER_SUPPLYNot really.
drivers/built-in.o: In function `acpi_video_bus_put_one_device':/root/kernel/linux/drivers/acpi/video.c:1407: undefined reference tothermal_cooling_device_unregister' drivers/built-in.o: In functionacpi_video_device_find_cap':/root/kernel/linux/drivers/acpi/video.c:842: undefined reference to `thermal_cooling_device_register'
make: *** [vmlinux] Error 1
Quoted 4 lines
It is
CONFIG_THERMAL=mthis time.Thanks.
Argh, next attempt, based on i915's Kconfig.
It seems that not only I have to select ACPI_VIDEO, I also have to select all the dependencies. Is this a Kconfig bug or working as intended? i915 seems to have a workaround, so I copied it from there. Except it's currently missing select THERMAL, so I guess it didn't get updated when that got added.
---->8
Having nouveau builtin would still allow ACPI_VIDEO to be used as external module if some of the deps for acpi_video have not been met, which would result in a linking failure. Solve this by selecting all dependencies as well.
---
drivers/gpu/drm/nouveau/Kconfig +7 -1
@@ -10,10 +10,16 @@ config DRM_NOUVEAU select FB select FRAMEBUFFER_CONSOLE if !EXPERT select FB_BACKLIGHT if DRM_NOUVEAU_BACKLIGHT - select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL && INPUT select ACPI_WMI if ACPI select MXM_WMI if ACPI select POWER_SUPPLY + # Similar to i915, we need to select ACPI_VIDEO and it's dependencies + select BACKLIGHT_LCD_SUPPORT if ACPI && X86 + select BACKLIGHT_CLASS_DEVICE if ACPI && X86 + select VIDEO_OUTPUT_CONTROL if ACPI && X86 + select INPUT if ACPI && X86 + select THERMAL if ACPI && X86 + select ACPI_VIDEO if ACPI && X86 help Choose this option for open-source nVidia support.
Re: [PATCH v2] drm/nouveau: always select ACPI_VIDEO if ACPI is enabled.
Quoted 7 lines · Maarten Lankhorst
Argh, next attempt, based on i915's
Kconfig.It seems that not only I have to select
ACPI_VIDEO, I also have to select all the dependencies. Is this aKconfigbug or working as intended? i915 seems to have a workaround, so I copied it from there. Except it's currently missing select THERMAL, so I guess it didn't get updated when that got added.
Quoted 6 lines
---->8
Having nouveau builtin would still allowACPI_VIDEOto be used as external module if some of the deps foracpi_videohave not been met, which would result in a linking failure. Solve this by selecting all dependencies as well.Signed-off-by Maarten Lankhorst <[email protected]>
Yep, this takes care of all deps,
Thanks.
Signature · 5 lines
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--Re: [PATCH v2] drm/nouveau: always select ACPI_VIDEO if ACPI is enabled.
Quoted 13 lines · Borislav Petkov
Quoted 12 lines · Maarten Lankhorst
Argh, next attempt, based on i915's
Kconfig.It seems that not only I have to select
ACPI_VIDEO, I also have to select all the dependencies. Is this aKconfigbug or working as intended? i915 seems to have a workaround, so I copied it from there. Except it's currently missing select THERMAL, so I guess it didn't get updated when that got added.---->8
Having nouveau builtin would still allowACPI_VIDEOto be used as external module if some of the deps foracpi_videohave not been met, which would result in a linking failure. Solve this by selecting all dependencies as well.
Quoted 5 lines
Quoted 1 line
Signed-off-by Maarten Lankhorst <[email protected]>Yep, this takes care of all deps,
Tested-by Borislav Petkov <[email protected]>
Just to check whether anyone has picked this already - it is triggering on 3.8 too so it most probably needs a stable tag too.
Thanks.
Signature · 5 lines
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--Borislav Petkov
Tested-byRe: [PATCH v2] drm/nouveau: always select ACPI_VIDEO if ACPI is enabled.
Quoted 14 lines · Borislav Petkov
Quoted 13 lines · Borislav Petkov
Quoted 12 lines · Maarten Lankhorst
Argh, next attempt, based on i915's
Kconfig.It seems that not only I have to select
ACPI_VIDEO, I also have to select all the dependencies. Is this aKconfigbug or working as intended? i915 seems to have a workaround, so I copied it from there. Except it's currently missing select THERMAL, so I guess it didn't get updated when that got added.---->8
Having nouveau builtin would still allowACPI_VIDEOto be used as external module if some of the deps foracpi_videohave not been met, which would result in a linking failure. Solve this by selecting all dependencies as well.
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Maarten Lankhorst <[email protected]>Yep, this takes care of all deps,
Tested-by Borislav Petkov <[email protected]>Just to check whether anyone has picked this already - it is triggering on 3.8 too so it most probably needs a stable tag too.
Ok,
this is not good.
So we have -rc7+, this patch has been out there for 2 months and still not in Linus' tree.
Linus,
the patch below fixes a build failure here with my custom config. I think this late in the game, we need some kind of a fix before 3.9 is released. I'm adding the patch here in case you want to pick it up yourself.
Thanks.
--
From: Maarten Lankhorst <[email protected]>
Date: Wed, 17 Apr 2013 12:04:09 +0200
Subject: [PATCH] drm/nouveau: always select ACPI_VIDEO if ACPI is enabled.
Having nouveau builtin would still allow ACPI_VIDEO to be used as external module if some of the deps for acpi_video have not been met, which would result in a linking failure. Solve this by selecting all dependencies as well.
--- drivers/gpu/drm/nouveau/Kconfig | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/gpu/drm/nouveau/Kconfig +7 -1
@@ -10,11 +10,17 @@ config DRM_NOUVEAU select FB select FRAMEBUFFER_CONSOLE if !EXPERT select FB_BACKLIGHT if DRM_NOUVEAU_BACKLIGHT - select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL && INPUT select X86_PLATFORM_DEVICES if ACPI && X86 select ACPI_WMI if ACPI && X86 select MXM_WMI if ACPI && X86 select POWER_SUPPLY + # Similar to i915, we need to select ACPI_VIDEO and it's dependencies + select BACKLIGHT_LCD_SUPPORT if ACPI && X86 + select BACKLIGHT_CLASS_DEVICE if ACPI && X86 + select VIDEO_OUTPUT_CONTROL if ACPI && X86 + select INPUT if ACPI && X86 + select THERMAL if ACPI && X86 + select ACPI_VIDEO if ACPI && X86 help Choose this option for open-source nVidia support.
Signature · 8 lines
1.8.2.135.g7b592fa
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
- -