Skip to contentSkip to conversation

ARM: EXYNOS: Add a platform bus notifier to set dma masks for Exynos5440

PATCH New Kukjin Kim 3 participants 4 messages Apr 4, 2013 – Jun 17, 2013

Subsystems (3)
lore
Share & tools
lore

Kukjin Kim

author
#0 lore raw

PATCH 1/2 ARM: EXYNOS: Add a platform bus notifier to set dma masks for Exynos5440

From: Thomas Abraham <[email protected]>

Use a platform bus notifier callback function to set the correct dma_mask and coherent_dma_mask for every device registered on Exynos5440 based machine.

---
 arch/arm/mach-exynos/mach-exynos5-dt.c |   23 +++++++++++++++++++++++
 1 files changed, 23 insertions(+), 0 deletions(-)
arch/arm/mach-exynos/mach-exynos5-dt.c +23 -0
index 753b94f..e47c2a5 100644
@@ -14,6 +14,7 @@
 #include <linux/memblock.h>
 #include <linux/io.h>
 #include <linux/clocksource.h>
+#include <linux/dma-mapping.h>
 
 #include <asm/mach/arch.h>
 #include <mach/regs-pmu.h>
@@ -23,11 +24,30 @@
 
 #include "common.h"
 
+static u64 dma_mask64 = DMA_BIT_MASK(64);
+
 static void __init exynos5_dt_map_io(void)
 {
 	exynos_init_io(NULL, 0);
 }
 
+static int exynos5440_platform_notifier(struct notifier_block *nb,
+				  unsigned long event, void *__dev)
+{
+	struct device *dev = __dev;
+
+	if (event != BUS_NOTIFY_ADD_DEVICE)
+		return NOTIFY_DONE;
+
+	dev->dma_mask = &dma_mask64;
+	dev->coherent_dma_mask = DMA_BIT_MASK(64);
+	return NOTIFY_OK;
+}
+
+static struct notifier_block exynos5440_platform_nb = {
+	.notifier_call = exynos5440_platform_notifier,
+};
+
 static void __init exynos5_dt_machine_init(void)
 {
 	struct device_node *i2c_np;
@@ -52,6 +72,9 @@ static void __init exynos5_dt_machine_init(void)
 		}
 	}
 
+	if (of_machine_is_compatible("samsung,exynos5440"))
+		bus_register_notifier(&platform_bus_type, &exynos5440_platform_nb);
+
 	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
 }
 
Signature · 1 line
1.7.4.4
author
#1 lore raw

PATCH 2/2 ARM: EXYNOS: force mac ip to 32bit dma

From: Girish K S <[email protected]>

The synopsys gigabit ethernet ip is compatible with only 32 bit buffers. so restrict the driver to use only 32 bit dma mapping.

---
 arch/arm/mach-exynos/mach-exynos5-dt.c |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)
arch/arm/mach-exynos/mach-exynos5-dt.c +5 -0
index e47c2a5..9596861 100644
@@ -25,6 +25,7 @@
 #include "common.h"
 
 static u64 dma_mask64 = DMA_BIT_MASK(64);
+static u64 dma_mask32 = DMA_BIT_MASK(32);
 
 static void __init exynos5_dt_map_io(void)
 {
@@ -41,6 +42,10 @@ static int exynos5440_platform_notifier(struct notifier_block *nb,
 
 	dev->dma_mask = &dma_mask64;
 	dev->coherent_dma_mask = DMA_BIT_MASK(64);
+
+	if (of_device_is_compatible(dev->of_node, "snps,dwmac-3.70a"))
+		dev->dma_mask = &dma_mask32;
+
 	return NOTIFY_OK;
 }
 
Signature · 1 line
1.7.4.4
#2 lore raw

PATCH 1/2 ARM: EXYNOS: Add a platform bus notifier to set dma masks for Exynos5440

In reply to Kukjin Kim
Quoted 1 line · Kukjin Kim

+static u64 dma_mask64 = DMA_BIT_MASK(64);

...

Review

Quoted 4 lines
(quoted diff) +4 -0
+	if (event != BUS_NOTIFY_ADD_DEVICE)
+		return NOTIFY_DONE;
+
+	dev->dma_mask = &dma_mask64;

Sharing the dma mask in this way is a potential issue should you have a device driver use dma_set_mask() - which can write to this value.

A better solution would be:

arch/arm/include/asm/device.h +1 -0
index dc662fc..51bb740 100644
@@ -22,6 +22,7 @@ struct dev_archdata {
 struct omap_device;
 
 struct pdev_archdata {
+	u64 dma_mask;
 #ifdef CONFIG_ARCH_OMAP
 	struct omap_device *od;
 #endif

and then in your function do:

	struct platform_device *pdev = to_platform_device(dev);
...
	pdev->dev.dma_mask = &pdev->arch_data.dma_mask;
	pdev->arch_data.dma_mask = DMA_BIT_MASK(64);

However... are all your devices really DMA capable? Normally on a SoC, it's only the DMA engine which is DMA capable and everything else is not, and in that case you really only want to set the DMA masks up for the DMA capable devices.

#3 lore raw

PATCH 1/2 ARM: EXYNOS: Add a platform bus notifier to set dma masks for Exynos5440

Quoted 10 lines · Russell King - ARM Linux
Quoted 1 line · Kukjin Kim

+static u64 dma_mask64 = DMA_BIT_MASK(64);

...

Review

Quoted 4 lines
(quoted diff) +4 -0
+     if (event != BUS_NOTIFY_ADD_DEVICE)
+             return NOTIFY_DONE;
+
+     dev->dma_mask = &dma_mask64;

Sharing the dma mask in this way is a potential issue should you have a device driver use dma_set_mask() - which can write to this value.

Hi Russell,

Okay, I missed this point.

Quoted 16 lines

A better solution would be:

arch/arm/include/asm/device.h +1 -0
index dc662fc..51bb740 100644
@@ -22,6 +22,7 @@ struct dev_archdata {
 struct omap_device;
 
 struct pdev_archdata {
+       u64 dma_mask;
 #ifdef CONFIG_ARCH_OMAP
        struct omap_device *od;
 #endif
Quoted 6 lines

and then in your function do:

        struct platform_device *pdev = to_platform_device(dev);
...
        pdev->dev.dma_mask = &pdev->arch_data.dma_mask;
        pdev->arch_data.dma_mask = DMA_BIT_MASK(64);

We could add a new u64 member into pdev_archdata structure, but that would use an additional u64 for all platform_device which do not need it. Adding a #ifdef around the u64 might not be ideal.

Quoted 5 lines

However... are all your devices really DMA capable? Normally on a SoC, it's only the DMA engine which is DMA capable and everything else is not, and in that case you really only want to set the DMA masks up for the DMA capable devices.

Yes, true. Not all devices in Exynos5440 are DMA capable and only the OHCI, EHCI and SATA controllers need 64-bit dma transfer capability.

I have reworked this patch based on your comments, would the following patch be acceptable? The u64 data is still in the machine file.

Sorry for the delay in replaying to your review comments.

Thanks,
Thomas.

(quoted diff) +0 -0

b/arch/arm/mach-exynos/mach-exynos5-dt.c
index 753b94f..8fdcd78 100644

arch/arm/mach-exynos/mach-exynos5-dt.c +32 -0
@@ -14,6 +14,7 @@
 #include <linux/memblock.h>
 #include <linux/io.h>
 #include <linux/clocksource.h>
+#include <linux/dma-mapping.h>
 
 #include <asm/mach/arch.h>
 #include <mach/regs-pmu.h>
@@ -23,11 +24,39 @@
 
 #include "common.h"
 
+static u64 dma_mask64 = DMA_BIT_MASK(64);
+static const struct of_device_id exynos5440_ctrl64bit_ids[] = {
+    { .compatible = "samsung,exynos5440-ohci", },
+    { .compatible = "samsung,exynos5440-ehci", },
+    { .compatible = "samsung,exynos5440-ahci", },
+};
+
 static void __init exynos5_dt_map_io(void)
 {
     exynos_init_io(NULL, 0);
 }
 
+static int exynos5440_platform_notifier(struct notifier_block *nb,
+  unsigned long event, void *__dev)
+{
+    struct device *dev = __dev;
+
+    if (event != BUS_NOTIFY_ADD_DEVICE)
+         return NOTIFY_DONE;
+
+    if (dev && dev->of_node &&
+         of_match_node(exynos5440_ctrl64bit_ids, dev->of_node)) {
+         dev->dma_mask = &dma_mask64;
+         dev->coherent_dma_mask = DMA_BIT_MASK(64);
+    }
+
+    return NOTIFY_OK;
+}
+
+static struct notifier_block exynos5440_platform_nb = {
+    .notifier_call = exynos5440_platform_notifier,
+};
+
 static void __init exynos5_dt_machine_init(void)
 {
  struct device_node *i2c_np;
@@ -52,6 +81,9 @@ static void __init exynos5_dt_machine_init(void)
  }
  }
 
+ if (of_machine_is_compatible("samsung,exynos5440"))
+     bus_register_notifier(&platform_bus_type, &exynos5440_platform_nb);
+
  of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
 }
 
Quoted 4 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html