r820t: precendence bug in r820t_xtal_check()

PATCH New Dan Carpenter 1 participant 1 message Apr 18, 2013

Subsystems (2)

Media (V4L/DVB) Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2013-04-18 19:20 UTC #0 lore raw

PATCH 1/2 r820t: precendence bug in r820t_xtal_check()

The test as written is always false. It looks like the intent was to test that the bit was not set.

Signed-off-by Dan Carpenter <[email protected]>

drivers/media/tuners/r820t.c +1 -1

index 905a106..ba033fd 100644
@@ -1378,7 +1378,7 @@ static int r820t_xtal_check(struct r820t_priv *priv)
 		rc = r820t_read(priv, 0x00, data, sizeof(data));
 		if (rc < 0)
 			return rc;
-		if ((!data[2]) & 0x40)
+		if (!(data[2] & 0x40))
 			continue;
 
 		val = data[2] & 0x3f;