drm: add a couple __user annotations

PATCH New Dan Carpenter 1 participant 1 message Apr 19, 2013

Subsystems (3)

DRM drivers DRM misc Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2013-04-19 07:07 UTC #0 lore raw

PATCH 1/1 drm: add a couple __user annotations

"list" and "request" are already declared as __user pointers, it's just this cast which is missing the annotation.

Signed-off-by Dan Carpenter <[email protected]>

---
Sparse doesn't complain about this because it hits the "error: bad integer constant expression" and stops printing warnings.

drivers/gpu/drm/drm_ioc32.c +2 -2

index 2f4c434..764794b 100644
@@ -457,7 +457,7 @@ static int compat_drm_infobufs(struct file *file, unsigned int cmd,
 	request = compat_alloc_user_space(nbytes);
 	if (!access_ok(VERIFY_WRITE, request, nbytes))
 		return -EFAULT;
-	list = (struct drm_buf_desc *) (request + 1);
+	list = (struct drm_buf_desc __user *) (request + 1);
 
 	if (__put_user(count, &request->count)
 	    || __put_user(list, &request->list))

@@ -518,7 +518,7 @@ static int compat_drm_mapbufs(struct file *file, unsigned int cmd,
 	request = compat_alloc_user_space(nbytes);
 	if (!access_ok(VERIFY_WRITE, request, nbytes))
 		return -EFAULT;
-	list = (struct drm_buf_pub *) (request + 1);
+	list = (struct drm_buf_pub __user *) (request + 1);
 
 	if (__put_user(count, &request->count)
 	    || __put_user(list, &request->list))