x86: kaslr: move ELF relocation handling to C
PATCH 1/1 x86: kaslr: move ELF relocation handling to C
Moves the relocation handling into C, after decompression. Only kernels that need relocation support will use the code. The new CONFIG_RANDOMIZE_BASE does not yet do anything except turn on this logic for 64-bit kernels.
Based on work by Neill Clift and Michael Davidson.
---
In case it wasn't clear, this is for the tip/kaslr tree.
--- arch/x86/Kconfig | 10 +++-- arch/x86/Makefile | 8 ++-- arch/x86/boot/compressed/head_32.S | 31 ++------------ arch/x86/boot/compressed/head_64.S | 1 + arch/x86/boot/compressed/misc.c | 77 +++++++++++++++++++++++++++++++++- arch/x86/include/asm/page_32_types.h | 2 + arch/x86/include/asm/page_64_types.h | 5 --- arch/x86/include/asm/page_types.h | 6 +++ 8 files changed, 99 insertions(+), 41 deletions(-)
arch/x86/Kconfig +7 -3
@@ -1698,13 +1698,17 @@ config RELOCATABLE it has been loaded at and the compile time physical address (CONFIG_PHYSICAL_START) is ignored. -# Relocation on x86-32 needs some additional build support +config RANDOMIZE_BASE + def_bool n + depends on RELOCATABLE + +# Relocation on x86 needs some additional build support config X86_NEED_RELOCS def_bool y - depends on X86_32 && RELOCATABLE + depends on RANDOMIZE_BASE || (X86_32 && RELOCATABLE) config PHYSICAL_ALIGN - hex "Alignment value to which kernel should be aligned" if X86_32 + hex "Alignment value to which kernel should be aligned" default "0x1000000" range 0x2000 0x1000000 ---help---
arch/x86/Makefile +4 -4
@@ -16,6 +16,10 @@ endif # e.g.: obj-y += foo_$(BITS).o export BITS +ifdef CONFIG_X86_NEED_RELOCS + LDFLAGS_vmlinux := --emit-relocs +endif + ifeq ($(CONFIG_X86_32),y) BITS := 32 UTS_MACHINE := i386
@@ -25,10 +29,6 @@ ifeq ($(CONFIG_X86_32),y) KBUILD_AFLAGS += $(biarch) KBUILD_CFLAGS += $(biarch) - ifdef CONFIG_RELOCATABLE - LDFLAGS_vmlinux := --emit-relocs - endif - KBUILD_CFLAGS += -msoft-float -mregparm=3 -freg-struct-return # Never want PIC in a 32-bit kernel, prevent breakage with GCC built
arch/x86/boot/compressed/head_32.S +3 -28
@@ -181,8 +181,9 @@ relocated: /* * Do the decompression, and jump to the new kernel.. */ - leal z_extract_offset_negative(%ebx), %ebp /* push arguments for decompress_kernel: */ + pushl $z_output_len /* decompressed length */ + leal z_extract_offset_negative(%ebx), %ebp pushl %ebp /* output address */ pushl $z_input_len /* input_len */ leal input_data(%ebx), %eax
@@ -191,33 +192,7 @@ relocated: pushl %eax /* heap area */ pushl %esi /* real mode pointer */ call decompress_kernel - addl $20, %esp - -#if CONFIG_RELOCATABLE -/* - * Find the address of the relocations. - */ - leal z_output_len(%ebp), %edi - -/* - * Calculate the delta between where vmlinux was compiled to run - * and where it was actually loaded. - */ - movl %ebp, %ebx - subl $LOAD_PHYSICAL_ADDR, %ebx - jz 2f /* Nothing to be done if loaded at compiled addr. */ -/* - * Process relocations. - */ - -1: subl $4, %edi - movl (%edi), %ecx - testl %ecx, %ecx - jz 2f - addl %ebx, -__PAGE_OFFSET(%ebx, %ecx) - jmp 1b -2: -#endif + addl $24, %esp /* * Jump to the decompressed kernel.
arch/x86/boot/compressed/head_64.S +1 -0
@@ -340,6 +340,7 @@ relocated: leaq input_data(%rip), %rdx /* input_data */ movl $z_input_len, %ecx /* input_len */ movq %rbp, %r8 /* output target address */ + movq $z_output_len, %r9 /* decompressed length */ call decompress_kernel popq %rsi
arch/x86/boot/compressed/misc.c +76 -1
95 lines not on this page · raw message
arch/x86/include/asm/page_32_types.h +2 -0
@@ -15,6 +15,8 @@*/ #define __PAGE_OFFSET _AC(CONFIG_PAGE_OFFSET, UL) +#define __START_KERNEL_map __PAGE_OFFSET +#define THREAD_SIZE_ORDER 1#define THREAD_SIZE (PAGE_SIZE << THREAD_SIZE_ORDER)
arch/x86/include/asm/page_64_types.h +0 -5
@@ -32,11 +32,6 @@*/ #define __PAGE_OFFSET _AC(0xffff880000000000, UL) -#define __PHYSICAL_START ((CONFIG_PHYSICAL_START + \ - (CONFIG_PHYSICAL_ALIGN - 1)) & \ - ~(CONFIG_PHYSICAL_ALIGN - 1)) - -#define __START_KERNEL (__START_KERNEL_map + __PHYSICAL_START)#define __START_KERNEL_map _AC(0xffffffff80000000, UL)/* See Documentation/x86/x86_64/mm.txt for a description of the memory map. */
arch/x86/include/asm/page_types.h +6 -0
@@ -33,6 +33,12 @@ (((current->personality &READ_IMPLIES_EXEC ) ?VM_EXEC :0 ) | \ VM_READ | VM_WRITE | VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC) +#define __PHYSICAL_START ((CONFIG_PHYSICAL_START + \ + (CONFIG_PHYSICAL_ALIGN - 1)) & \ + ~(CONFIG_PHYSICAL_ALIGN - 1)) + +#define __START_KERNEL (__START_KERNEL_map + __PHYSICAL_START) +#ifdef CONFIG_X86_64 #include <asm/page_64_types.h> #else
Signature · 6 lines
1.7.9.5 -- Kees Cook Chrome OS Security
Quoted 4 lines · Kees Cook
Moves the relocation handling into C, after decompression. Only kernels that need relocation support will use the code. The new
CONFIG_RANDOMIZE_BASEdoes not yet do anything except turn on this logic for 64-bit kernels.
So why not keep the inactive CONFIG_RANDOMIZE_BASE hunks in a separate patch, and just have this one clean, orthogonal patch that moves relocation handling into C?
Thanks,
Ingo
Quoted 11 lines · Ingo Molnar
Quoted 4 lines · Kees Cook
Moves the relocation handling into C, after decompression. Only kernels that need relocation support will use the code. The new
CONFIG_RANDOMIZE_BASEdoes not yet do anything except turn on this logic for 64-bit kernels.So why not keep the inactive
CONFIG_RANDOMIZE_BASEhunks in a separate patch, and just have this one clean, orthogonal patch that moves relocation handling into C?
I had wanted there to be a way to test building with 64-bit relocations. With this patch and CONFIG_RANDOMIZE_BASE=y, I could do that. Would you rather I remove those pieces?
-Kees
--
Kees Cook
Chrome OS Security
Quoted 9 lines · Kees Cook
Quoted 8 lines · Ingo Molnar
Quoted 4 lines · Kees Cook
Moves the relocation handling into C, after decompression. Only kernels that need relocation support will use the code. The new
CONFIG_RANDOMIZE_BASEdoes not yet do anything except turn on this logic for 64-bit kernels.
Quoted 7 lines
Quoted 3 lines
So why not keep the inactive
CONFIG_RANDOMIZE_BASEhunks in a separate patch, and just have this one clean, orthogonal patch that moves relocation handling into C?I had wanted there to be a way to test building with 64-bit relocations. With this patch and
CONFIG_RANDOMIZE_BASE=y, I could do that. Would you rather I remove those pieces?
But AFAICS CONFIG_RANDOMIZE_BASE is not an interactive config option, so how did you turn it on?
But no strong objections in any case.
Thanks,
Ingo
Quoted 16 lines · Ingo Molnar
Quoted 13 lines · Kees Cook
Quoted 11 lines · Ingo Molnar
Quoted 4 lines · Kees Cook
Moves the relocation handling into C, after decompression. Only kernels that need relocation support will use the code. The new
CONFIG_RANDOMIZE_BASEdoes not yet do anything except turn on this logic for 64-bit kernels.So why not keep the inactive
CONFIG_RANDOMIZE_BASEhunks in a separate patch, and just have this one clean, orthogonal patch that moves relocation handling into C?
Quoted 6 lines
Quoted 3 lines
I had wanted there to be a way to test building with 64-bit relocations. With this patch and
CONFIG_RANDOMIZE_BASE=y, I could do that. Would you rather I remove those pieces?But AFAICS
CONFIG_RANDOMIZE_BASEis not an interactive config option, so how did you turn it on?
I directly edited the .config file to enable it.
Quoted 1 line
But no strong objections in any case.
HPA, any opinion? How would you like to see arranged for tip/kaslr?
-Kees
--
Kees Cook
Chrome OS Security