Skip to contentSkip to conversation

irda: irlmp_reasons[] can be static

PATCH Applied Fengguang Wu 3 participants 3 messages Apr 20, 2013 – Apr 25, 2013 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 5171ea81.dFNn973/RcdmuuQR%[email protected]

#1 lore raw

PATCH 1/1 irda: irlmp_reasons[] can be static

---
 irlmp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/irda/irlmp.c +1 -1
index 1064621..98ad6ec 100644
@@ -58,7 +58,7 @@ int  sysctl_discovery_slots   = 6; /* 6 slots by default */
 int  sysctl_lap_keepalive_time = LM_IDLE_TIMEOUT * 1000 / HZ;
 char sysctl_devname[65];
 
-const char *irlmp_reasons[] = {
+static const char *irlmp_reasons[] = {
 	"ERROR, NOT USED",
 	"LM_USER_REQUEST",
 	"LM_LAP_DISCONNECT",
Acked-by on v1 1/1
#2 lore raw
Quoted 10 lines · Fengguang Wu
---
 irlmp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/irda/irlmp.c +0 -0
index 1064621..98ad6ec 100644

net/irda/irlmp.c int sysctl_discovery_slots = 6; /* 6 slots by default */ · line 61

Quoted 5 lines
net/irda/irlmp.c +1 -1
@@ -58,7 +58,7 @@ int  sysctl_discovery_slots   = 6; /* 6 slots by default */
 int  sysctl_lap_keepalive_time = LM_IDLE_TIMEOUT * 1000 / HZ;
 char sysctl_devname[65];
 
-const char *irlmp_reasons[] = {
+static const char *irlmp_reasons[] = {

Oops. Sorry for that. I do run Sparse on my patches but I missed that.

regards,
dan carpenter

maintainer Applied
#3 lore raw

From: Dan Carpenter <[email protected]>
Date: Sat, 20 Apr 2013 14:11:51 +0300

Quoted 14 lines · Fengguang Wu
Quoted 13 lines
---
 irlmp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/irda/irlmp.c +0 -0
index 1064621..98ad6ec 100644
@@ -58,7 +58,7 @@ int  sysctl_discovery_slots   = 6; /* 6 slots by default */
 int  sysctl_lap_keepalive_time = LM_IDLE_TIMEOUT * 1000 / HZ;
 char sysctl_devname[65];
 
Quoted 7 lines

net/irda/irlmp.c int sysctl_discovery_slots = 6; /* 6 slots by default */ · line 61

Quoted 2 lines
net/irda/irlmp.c +1 -1
-const char *irlmp_reasons[] = {
+static const char *irlmp_reasons[] = {

Oops. Sorry for that. I do run Sparse on my patches but I missed that.

Applied to net-next, thanks everyone.