Skip to contentSkip to conversation

arm: bootm: call udc_disable() before booting linux

PATCH RESEND New Mike Dunn 3 participants 4 messages Apr 20, 2013 – Apr 25, 2013 Arm (32-bit)

lore
Share & tools
lore

Mike Dunn

author
#0 lore raw

PATCH RESEND 1/1 arm: bootm: call udc_disable() before booting linux

On the pxa270, if the udc device is not disabled before jumping to linux, the device fails to initialize in linux because it was left in a running state, and the linux driver assumes that it is in a disabled state.

---
Arguably, this is a bug in the linux driver, but it seemed pretty simple and benign to just disable it in u-boot. I'll also send a patch to upstream kernel to fix its udc driver.

 arch/arm/include/asm/bootm.h |    1 +
 arch/arm/lib/bootm.c         |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)
arch/arm/include/asm/bootm.h +1 -0
index db2ff94..68189cc 100644
@@ -21,6 +21,7 @@
 
 #ifdef CONFIG_USB_DEVICE
 extern void udc_disconnect(void);
+extern void udc_disable(void);
 #endif
 
 #endif
arch/arm/lib/bootm.c +1 -0
index f3b30c5..6daa7bf 100644
@@ -105,6 +105,7 @@ static void announce_and_cleanup(void)
 
 #ifdef CONFIG_USB_DEVICE
 	udc_disconnect();
+	udc_disable();
 #endif
 	cleanup_before_linux();
 }
Signature · 1 line
1.7.8.6
#1 lore raw

PATCH RESEND 1/1 arm: bootm: call udc_disable() before booting linux

Quoted 5 lines · Mike Dunn

On the pxa270, if the udc device is not disabled before jumping to linux, the device fails to initialize in linux because it was left in a running state, and the linux driver assumes that it is in a disabled state.

Shouldn't it be fixed in Linux, in this case?

--
Otavio Salvador O.S. Systems
E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br

#2 lore raw

PATCH RESEND 1/1 arm: bootm: call udc_disable() before booting linux

Dear Otavio Salvador,

Quoted 8 lines · Mike Dunn
Quoted 5 lines

On the pxa270, if the udc device is not disabled before jumping to linux, the device fails to initialize in linux because it was left in a running state, and the linux driver assumes that it is in a disabled state.

Shouldn't it be fixed in Linux, in this case?

There is a whole thread about this in the previous version if this patch, dig it up in the mailing list, you'll surely find your answer there shortly.

Best regards,
Marek Vasut

#3 lore raw

PATCH RESEND 1/1 arm: bootm: call udc_disable() before booting linux

In reply to Mike Dunn

Dear Mike Dunn,

Quoted 5 lines

On the pxa270, if the udc device is not disabled before jumping to linux, the device fails to initialize in linux because it was left in a running state, and the linux driver assumes that it is in a disabled state.

Applied this and the USB patch.

Best regards,
Marek Vasut