runltp: syscalls/mount0* and inotify03 tests are getting skipped from runltp's execution

PATCH In review Ramesh 3 participants 9 messages Apr 5, 2013 – Apr 22, 2013

Share & tools

Ramesh

author

2013-04-05 10:19 UTC #0 lore raw

PATCH 1/1 runltp: syscalls/mount0* and inotify03 tests are getting skipped from runltp's execution

Some of the tests which require a block device for their execution are skipped
when runltp is run without any block device being specified on commandline.Most
of such tests are from syscalls group and as a work around to make these tests
run even when no block device is specified,I have made use of loopback device
to create a block device with ext4 filesystem. So,runltp is modified to create
a block device and set the values for DEVICE and DEVICE_FS_TYPE accordingly.

Following are the skipped tests,
----
inotify03 inotify03 -D DEVICE -T DEVICE_FS_TYPE
mount01 mount01 -D DEVICE -T DEVICE_FS_TYPE
mount02 mount02 -D DEVICE -T DEVICE_FS_TYPE
mount03 mount03 -D DEVICE -T DEVICE_FS_TYPE
mount04 mount04 -D DEVICE -T DEVICE_FS_TYPE
umount01 umount01 -D DEVICE -T DEVICE_FS_TYPE
umount02 umount02 -D DEVICE -T DEVICE_FS_TYPE
umount03 umount03 -D DEVICE -T DEVICE_FS_TYPE
----

Please review the patch and let me know if any more changes are needed.

Signed-off-by Ramesh YR <[email protected]>

---
  runltp |   52 +++++++++++++++++++++++++++++++++++++++++++++++-----
  1 files changed, 47 insertions(+), 5 deletions(-)

runltp +7 -3

index 04cc690..d7e3f0d 100755
@@ -681,14 +681,22 @@ main()
 
      if [ -n "$DEVICE" ]; then
          sed -i "s|DEVICE|$DEVICE|"  ${TMP}/alltests
+    RC=$?
      else
-        echo "remove test cases which require the block device."
-        echo "You can specify it with option -b"
-        sed -i "/DEVICE/d"  ${TMP}/alltests
+    create_block
+    if [ $? -eq 0 ]; then
+        sed -i "s|DEVICE|$DEVICE|"  ${TMP}/alltests
+        RC=$?
+    else
+        echo -e "no block device was specified on commandline.\n Block

device could not be created using loopback device"
+ echo -e "Tests which require block device are disabled.\n You
can specify it with option -b"
+ sed -i "/DEVICE/d" ${TMP}/alltests
+ RC=$?
+ fi
fi

- if [ $? -ne 0 ]; then
- echo "FATAL: error during prcessing alltests file by sed"
+ if [ $RC -ne 0 ]; then
+ echo "FATAL: error during processing alltests file by sed"
exit 1
fi

@@ -971,8 +979,42 @@ main()
exit $VALUE
}

+create_block()
+{

+    #create a block device with ext4 filesystem.
+    dd if=/dev/zero of=${TMP}/test.img bs=1kB count=10240 &>/dev/null
+    if [ $? -ne 0 ]; then

+ echo "Failed to create loopback device image,please check disk
space and re-run"
+ return 1
+ else

+        ##search for an unused loop dev
+        LOOP_DEV=$(losetup -f)
+        if [ $? -ne 0 ]; then
+            echo "no unused loop device is found"
+            return 1
+        else
+            ##attach the created file to loop dev.
+            losetup $LOOP_DEV ${TMP}/test.img &>/dev/null
+            if [ $? -ne 0 ]; then

+ echo "losetup failed to create block device"
+ return 1
+ else
+ mkfs.ext4 $LOOP_DEV &>/dev/null
+ [ $? -ne 0 ] && (echo "creating a ext4 block device
failed" && return 1)

+                #set the values in alltests which require block device.
+                DEVICE=$LOOP_DEV
+                DEVICE_FS_TYPE="ext4"
+                return 0

+ fi
+ fi
+ fi
+}
+
+
cleanup()
{
+ [ -e "${TEMP}/test.img" ] && rm -f ${TEMP}/test.img
+ [ "$LOOP_DEV" ] && losetup -d $LOOP_DEV

      rm -rf ${TMP}

}

Signature · 14 lines

Regards,
Ramesh


------------------------------------------------------------------------------
Minimize network downtime and maximize team effectiveness.
Reduce network management and security costs.Learn how to hire 
the most talented Cisco Certified professionals. Visit the 
Employer Resources Portal
http://www.cisco.com/web/learning/employer_resources/index.html
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Wanlong Gao

2013-04-08 00:58 UTC #1 lore raw

Quoted 11 lines · Ramesh

Some of the tests which require a block device for their execution are skipped
when runltp is run without any block device being specified on commandline.Most
of such tests are from syscalls group and as a work around to make these tests
run even when no block device is specified,I have made use of loopback device
to create a block device with ext4 filesystem. So,runltp is modified to create
a block device and set the values for DEVICE and DEVICE_FS_TYPE accordingly.

I like this change, but seems that your email client wrapped the lines, please take care of this issue when you respin the patch.

Thanks,
Wanlong Gao

Quoted 90 lines

Following are the skipped tests,
----
inotify03 inotify03 -D DEVICE -T DEVICE_FS_TYPE mount01 mount01 -D DEVICE -T DEVICE_FS_TYPE mount02 mount02 -D DEVICE -T DEVICE_FS_TYPE mount03 mount03 -D DEVICE -T DEVICE_FS_TYPE mount04 mount04 -D DEVICE -T DEVICE_FS_TYPE umount01 umount01 -D DEVICE -T DEVICE_FS_TYPE umount02 umount02 -D DEVICE -T DEVICE_FS_TYPE umount03 umount03 -D DEVICE -T DEVICE_FS_TYPE
----

Please review the patch and let me know if any more changes are needed.

Signed-off-by Ramesh YR <[email protected]>

---
  runltp |   52 +++++++++++++++++++++++++++++++++++++++++++++++-----
  1 files changed, 47 insertions(+), 5 deletions(-)

runltp +7 -3

index 04cc690..d7e3f0d 100755
@@ -681,14 +681,22 @@ main()
 
      if [ -n "$DEVICE" ]; then
          sed -i "s|DEVICE|$DEVICE|"  ${TMP}/alltests
+    RC=$?
      else
-        echo "remove test cases which require the block device."
-        echo "You can specify it with option -b"
-        sed -i "/DEVICE/d"  ${TMP}/alltests
+    create_block
+    if [ $? -eq 0 ]; then
+        sed -i "s|DEVICE|$DEVICE|"  ${TMP}/alltests
+        RC=$?
+    else
+        echo -e "no block device was specified on commandline.\n Block

device could not be created using loopback device"
+ echo -e "Tests which require block device are disabled.\n You
can specify it with option -b"

runltp +11 -2

+        sed -i "/DEVICE/d"  ${TMP}/alltests
+        RC=$?
+    fi
      fi
 
-    if [ $? -ne 0 ]; then
-            echo "FATAL: error during prcessing alltests file by sed"
+    if [ $RC -ne 0 ]; then
+            echo "FATAL: error during processing alltests file by sed"
              exit 1
      fi

@@ -971,8 +979,42 @@ main()
      exit $VALUE
  }
 
+create_block()
+{
+    #create a block device with ext4 filesystem.
+    dd if=/dev/zero of=${TMP}/test.img bs=1kB count=10240 &>/dev/null
+    if [ $? -ne 0 ]; then
+        echo "Failed to create loopback device image,please check disk

space and re-run"

runltp +16 -0

+        return 1
+    else
+        ##search for an unused loop dev
+        LOOP_DEV=$(losetup -f)
+        if [ $? -ne 0 ]; then
+            echo "no unused loop device is found"
+            return 1
+        else
+            ##attach the created file to loop dev.
+            losetup $LOOP_DEV ${TMP}/test.img &>/dev/null
+            if [ $? -ne 0 ]; then
+                echo "losetup failed to create block device"
+                return 1
+            else
+                mkfs.ext4 $LOOP_DEV &>/dev/null
+                [ $? -ne 0 ] && (echo "creating a ext4 block device

failed" && return 1)

runltp +6 -0

+                #set the values in alltests which require block device.
+                DEVICE=$LOOP_DEV
+                DEVICE_FS_TYPE="ext4"
+                return 0
+            fi
+        fi

runltp

Quoted 10 lines

runltp +6 -0

+    fi
+}
+
+
  cleanup()
  {
+    [ -e "${TEMP}/test.img" ] && rm -f ${TEMP}/test.img
+    [ "$LOOP_DEV" ] && losetup -d $LOOP_DEV
      rm -rf ${TMP}
  }

------------------------------------------------------------------------------
Minimize network downtime and maximize team effectiveness. Reduce network management and security costs.Learn how to hire the most talented Cisco Certified professionals. Visit the Employer Resources Portal
http://www.cisco.com/web/learning/employer_resources/index.html
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Ramesh

author

2013-04-09 07:02 UTC #2 lore raw

Quoted 111 lines · Wanlong Gao

Quoted 11 lines · Ramesh
Some of the tests which require a block device for their execution are skipped
when runltp is run without any block device being specified on commandline.Most
of such tests are from syscalls group and as a work around to make these tests
run even when no block device is specified,I have made use of loopback device
to create a block device with ext4 filesystem. So,runltp is modified to create
a block device and set the values for DEVICE and DEVICE_FS_TYPE accordingly.
I like this change, but seems that your email client wrapped the lines, please take care of this issue when you respin the patch.
Thanks,
Wanlong Gao
Quoted 92 lines
Following are the skipped tests,
----
inotify03 inotify03 -D DEVICE -T DEVICE_FS_TYPE mount01 mount01 -D DEVICE -T DEVICE_FS_TYPE mount02 mount02 -D DEVICE -T DEVICE_FS_TYPE mount03 mount03 -D DEVICE -T DEVICE_FS_TYPE mount04 mount04 -D DEVICE -T DEVICE_FS_TYPE umount01 umount01 -D DEVICE -T DEVICE_FS_TYPE umount02 umount02 -D DEVICE -T DEVICE_FS_TYPE umount03 umount03 -D DEVICE -T DEVICE_FS_TYPE
----
Please review the patch and let me know if any more changes are needed.
Signed-off-by Ramesh YR<[email protected]>
---
   runltp |   52 +++++++++++++++++++++++++++++++++++++++++++++++-----
   1 files changed, 47 insertions(+), 5 deletions(-)
runltp +7 -3
index 04cc690..d7e3f0d 100755
@@ -681,14 +681,22 @@ main()
 
       if [ -n "$DEVICE" ]; then
           sed -i "s|DEVICE|$DEVICE|"  ${TMP}/alltests
+    RC=$?
       else
-        echo "remove test cases which require the block device."
-        echo "You can specify it with option -b"
-        sed -i "/DEVICE/d"  ${TMP}/alltests
+    create_block
+    if [ $? -eq 0 ]; then
+        sed -i "s|DEVICE|$DEVICE|"  ${TMP}/alltests
+        RC=$?
+    else
+        echo -e "no block device was specified on commandline.\n Block
device could not be created using loopback device"
+ echo -e "Tests which require block device are disabled.\n You
can specify it with option -b"
runltp +11 -2
+        sed -i "/DEVICE/d"  ${TMP}/alltests
+        RC=$?
+    fi
       fi
 
-    if [ $? -ne 0 ]; then
-            echo "FATAL: error during prcessing alltests file by sed"
+    if [ $RC -ne 0 ]; then
+            echo "FATAL: error during processing alltests file by sed"
               exit 1
       fi
@@ -971,8 +979,42 @@ main()
       exit $VALUE
   }
 
+create_block()
+{
+    #create a block device with ext4 filesystem.
+    dd if=/dev/zero of=${TMP}/test.img bs=1kB count=10240&>/dev/null
+    if [ $? -ne 0 ]; then
+        echo "Failed to create loopback device image,please check disk
space and re-run"
runltp +16 -0
+        return 1
+    else
+        ##search for an unused loop dev
+        LOOP_DEV=$(losetup -f)
+        if [ $? -ne 0 ]; then
+            echo "no unused loop device is found"
+            return 1
+        else
+            ##attach the created file to loop dev.
+            losetup $LOOP_DEV ${TMP}/test.img&>/dev/null
+            if [ $? -ne 0 ]; then
+                echo "losetup failed to create block device"
+                return 1
+            else
+                mkfs.ext4 $LOOP_DEV&>/dev/null
+                [ $? -ne 0 ]&&  (echo "creating a ext4 block device
failed"&& return 1)
runltp +9 -0
+                #set the values in alltests which require block device.
+                DEVICE=$LOOP_DEV
+                DEVICE_FS_TYPE="ext4"
+                return 0
+            fi
+        fi
+    fi
+}
+

Quoted 9 lines

runltp

Quoted 8 lines

runltp +3 -0

+
   cleanup()
   {
+    [ -e "${TEMP}/test.img" ]&&  rm -f ${TEMP}/test.img
+    [ "$LOOP_DEV" ]&&  losetup -d $LOOP_DEV
       rm -rf ${TMP}
   }

Hi,

I have corrected few indentation flaws and I think this patch should be fine to commit.
Please let me know if you are still facing any issues in extracting this patch for commit.

Signed-off-by Ramesh YR <[email protected]>

---
  runltp |   51 ++++++++++++++++++++++++++++++++++++++++++++++-----
  1 files changed, 46 insertions(+), 5 deletions(-)

runltp +7 -3

index 04cc690..5562b9c 100755
@@ -681,14 +681,22 @@ main()
 
      if [ -n "$DEVICE" ]; then
          sed -i "s|DEVICE|$DEVICE|"  ${TMP}/alltests
+        RC=$?
      else
-        echo "remove test cases which require the block device."
-        echo "You can specify it with option -b"
-        sed -i "/DEVICE/d"  ${TMP}/alltests
+        create_block
+        if [ $? -eq 0 ]; then
+            sed -i "s|DEVICE|$DEVICE|"  ${TMP}/alltests
+            RC=$?
+        else
+            echo -e "no block device was specified on commandline.\n

Block device could not be created using loopback device"
+ echo -e "Tests which require block device are disabled.\n
You can specify it with option -b"
+ sed -i "/DEVICE/d" ${TMP}/alltests
+ RC=$?
+ fi
fi

- if [ $? -ne 0 ]; then
- echo "FATAL: error during prcessing alltests file by sed"
+ if [ $RC -ne 0 ]; then
+ echo "FATAL: error during processing alltests file by sed"
exit 1
fi

@@ -971,8 +979,41 @@ main()
exit $VALUE
}

+create_block()
+{

+    #create a block device with ext4 filesystem.
+    dd if=/dev/zero of=${TMP}/test.img bs=1kB count=10240 &>/dev/null
+    if [ $? -ne 0 ]; then

+ echo "Failed to create loopback device image,please check disk
space and re-run"
+ return 1
+ else

+        ##search for an unused loop dev
+        LOOP_DEV=$(losetup -f)
+        if [ $? -ne 0 ]; then
+            echo "no unused loop device is found"
+            return 1
+        else
+            ##attach the created file to loop dev.
+            losetup $LOOP_DEV ${TMP}/test.img &>/dev/null
+            if [ $? -ne 0 ]; then

+ echo "losetup failed to create block device"
+ return 1
+ else
+ mkfs.ext4 $LOOP_DEV &>/dev/null
+ [ $? -ne 0 ] && (echo "creating a ext4 block device
failed" && return 1)

+                #set the values in alltests which require block device.
+                DEVICE=$LOOP_DEV
+                DEVICE_FS_TYPE="ext4"
+                return 0

+ fi
+ fi
+ fi
+}
+
cleanup()
{
+ [ "$LOOP_DEV" ] && losetup -d $LOOP_DEV
+ [ -e "${TEMP}/test.img" ] && rm -f ${TEMP}/test.img

      rm -rf ${TMP}

}

Signature · 19 lines

Regards,
Ramesh







------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Wanlong Gao

Acked-by

2013-04-15 03:15 UTC #3 lore raw

Quoted 121 lines · Ramesh

Quoted 111 lines · Wanlong Gao
Quoted 11 lines · Ramesh
Some of the tests which require a block device for their execution are skipped
when runltp is run without any block device being specified on commandline.Most
of such tests are from syscalls group and as a work around to make these tests
run even when no block device is specified,I have made use of loopback device
to create a block device with ext4 filesystem. So,runltp is modified to create
a block device and set the values for DEVICE and DEVICE_FS_TYPE accordingly.
I like this change, but seems that your email client wrapped the lines, please take care of this issue when you respin the patch.
Thanks,
Wanlong Gao
Quoted 92 lines
Following are the skipped tests,
----
inotify03 inotify03 -D DEVICE -T DEVICE_FS_TYPE mount01 mount01 -D DEVICE -T DEVICE_FS_TYPE mount02 mount02 -D DEVICE -T DEVICE_FS_TYPE mount03 mount03 -D DEVICE -T DEVICE_FS_TYPE mount04 mount04 -D DEVICE -T DEVICE_FS_TYPE umount01 umount01 -D DEVICE -T DEVICE_FS_TYPE umount02 umount02 -D DEVICE -T DEVICE_FS_TYPE umount03 umount03 -D DEVICE -T DEVICE_FS_TYPE
----
Please review the patch and let me know if any more changes are needed.
Signed-off-by Ramesh YR<[email protected]>
---
   runltp |   52 +++++++++++++++++++++++++++++++++++++++++++++++-----
   1 files changed, 47 insertions(+), 5 deletions(-)
runltp +7 -3
index 04cc690..d7e3f0d 100755
@@ -681,14 +681,22 @@ main()
 
       if [ -n "$DEVICE" ]; then
           sed -i "s|DEVICE|$DEVICE|"  ${TMP}/alltests
+    RC=$?
       else
-        echo "remove test cases which require the block device."
-        echo "You can specify it with option -b"
-        sed -i "/DEVICE/d"  ${TMP}/alltests
+    create_block
+    if [ $? -eq 0 ]; then
+        sed -i "s|DEVICE|$DEVICE|"  ${TMP}/alltests
+        RC=$?
+    else
+        echo -e "no block device was specified on commandline.\n Block
device could not be created using loopback device"
+ echo -e "Tests which require block device are disabled.\n You
can specify it with option -b"
runltp +11 -2
+        sed -i "/DEVICE/d"  ${TMP}/alltests
+        RC=$?
+    fi
       fi
 
-    if [ $? -ne 0 ]; then
-            echo "FATAL: error during prcessing alltests file by sed"
+    if [ $RC -ne 0 ]; then
+            echo "FATAL: error during processing alltests file by sed"
               exit 1
       fi
@@ -971,8 +979,42 @@ main()
       exit $VALUE
   }
 
+create_block()
+{
+    #create a block device with ext4 filesystem.
+    dd if=/dev/zero of=${TMP}/test.img bs=1kB count=10240&>/dev/null
+    if [ $? -ne 0 ]; then
+        echo "Failed to create loopback device image,please check disk
space and re-run"
runltp +16 -0
+        return 1
+    else
+        ##search for an unused loop dev
+        LOOP_DEV=$(losetup -f)
+        if [ $? -ne 0 ]; then
+            echo "no unused loop device is found"
+            return 1
+        else
+            ##attach the created file to loop dev.
+            losetup $LOOP_DEV ${TMP}/test.img&>/dev/null
+            if [ $? -ne 0 ]; then
+                echo "losetup failed to create block device"
+                return 1
+            else
+                mkfs.ext4 $LOOP_DEV&>/dev/null
+                [ $? -ne 0 ]&&  (echo "creating a ext4 block device
failed"&& return 1)
runltp +9 -0
+                #set the values in alltests which require block device.
+                DEVICE=$LOOP_DEV
+                DEVICE_FS_TYPE="ext4"
+                return 0
+            fi
+        fi
+    fi
+}
+
Quoted 9 lines
runltp
Quoted 8 lines
runltp +3 -0
+
   cleanup()
   {
+    [ -e "${TEMP}/test.img" ]&&  rm -f ${TEMP}/test.img
+    [ "$LOOP_DEV" ]&&  losetup -d $LOOP_DEV
       rm -rf ${TMP}
   }

Quoted 7 lines

Hi,
I have corrected few indentation flaws and I think this patch should be fine to commit. Please let me know if you are still facing any issues in extracting this patch for commit.
Signed-off-by Ramesh YR <[email protected]>

Acked-by Wanlong Gao <[email protected]>

Any other objections?

Thanks,
Wanlong Gao

Quoted 68 lines

---
 runltp |   51 ++++++++++++++++++++++++++++++++++++++++++++++-----
 1 files changed, 46 insertions(+), 5 deletions(-)

runltp +41 -5

index 04cc690..5562b9c 100755
@@ -681,14 +681,22 @@ main()
 
     if [ -n "$DEVICE" ]; then
         sed -i "s|DEVICE|$DEVICE|"  ${TMP}/alltests
+        RC=$?
     else
-        echo "remove test cases which require the block device."
-        echo "You can specify it with option -b"
-        sed -i "/DEVICE/d"  ${TMP}/alltests
+        create_block
+        if [ $? -eq 0 ]; then
+            sed -i "s|DEVICE|$DEVICE|"  ${TMP}/alltests
+            RC=$?
+        else
+            echo -e "no block device was specified on commandline.\n Block device could not be created using loopback device"
+            echo -e "Tests which require block device are disabled.\n You can specify it with option -b"
+            sed -i "/DEVICE/d"  ${TMP}/alltests
+            RC=$?
+        fi
     fi
 
-    if [ $? -ne 0 ]; then
-            echo "FATAL: error during prcessing alltests file by sed"
+    if [ $RC -ne 0 ]; then
+            echo "FATAL: error during processing alltests file by sed"
             exit 1
     fi

@@ -971,8 +979,41 @@ main()
     exit $VALUE
 }
 
+create_block()
+{
+    #create a block device with ext4 filesystem.
+    dd if=/dev/zero of=${TMP}/test.img bs=1kB count=10240 &>/dev/null
+    if [ $? -ne 0 ]; then
+        echo "Failed to create loopback device image,please check disk space and re-run"
+        return 1
+    else
+        ##search for an unused loop dev
+        LOOP_DEV=$(losetup -f)
+        if [ $? -ne 0 ]; then
+            echo "no unused loop device is found"
+            return 1
+        else
+            ##attach the created file to loop dev.
+            losetup $LOOP_DEV ${TMP}/test.img &>/dev/null
+            if [ $? -ne 0 ]; then
+                echo "losetup failed to create block device"
+                return 1
+            else
+                mkfs.ext4 $LOOP_DEV &>/dev/null
+                [ $? -ne 0 ] && (echo "creating a ext4 block device failed" && return 1)
+                #set the values in alltests which require block device.
+                DEVICE=$LOOP_DEV
+                DEVICE_FS_TYPE="ext4"
+                return 0
+            fi
+        fi

runltp main() · line 1019

Quoted 10 lines

runltp +5 -0

+    fi
+}
+
 cleanup()
 {
+    [ "$LOOP_DEV" ] && losetup -d $LOOP_DEV
+    [ -e "${TEMP}/test.img" ] && rm -f ${TEMP}/test.img
     rm -rf ${TMP}
 }

------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced analytics on semi-structured data. The platform includes APIs for building apps and a phenomenal toolset for data science. Developers can use our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

[email protected]

2013-04-15 13:23 UTC #4 lore raw

Hi!

Quoted 6 lines

Quoted 1 line
Signed-off-by Ramesh YR <[email protected]>
Acked-by Wanlong Gao <[email protected]>
Any other objections?

The patch logic looks fine.

The only thing that doesn't look 100% right are the overly long lines (which could be fixed by splitting the messages and print each sentence
with it's own echo).

Signature · 13 lines

Cyril Hrubis
[email protected]

------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Wanlong Gao

2013-04-16 01:39 UTC #5 lore raw

In reply to Ramesh

Quoted 7 lines · Ramesh

Hi,
I have corrected few indentation flaws and I think this patch should be fine to commit. Please let me know if you are still facing any issues in extracting this patch for commit.
Signed-off-by Ramesh YR <[email protected]>

Applied with the long-line-echo fixed, thank you.

Wanlong Gao

Ramesh

author

2013-04-22 08:58 UTC #6 lore raw

Quoted 7 lines · Wanlong Gao

Quoted 6 lines · Ramesh
Hi,
I have corrected few indentation flaws and I think this patch should be fine to commit. Please let me know if you are still facing any issues in extracting this patch for commit.

Quoted 6 lines

Quoted 1 line
Signed-off-by Ramesh YR<[email protected]>
Applied with the long-line-echo fixed, thank you.
Wanlong Gao

Thanks Wanlong !

I think History part in runltp script needs to be updated to reflect the changes.

Regards,
Ramesh

Wanlong Gao

2013-04-22 09:04 UTC #7 lore raw

Quoted 9 lines · Ramesh

Quoted 8 lines · Wanlong Gao
Quoted 7 lines · Ramesh
Hi,
I have corrected few indentation flaws and I think this patch should be fine to commit. Please let me know if you are still facing any issues in extracting this patch for commit.
Signed-off-by Ramesh YR<[email protected]>

Quoted 8 lines

Quoted 5 lines
Applied with the long-line-echo fixed, thank you.
Wanlong Gao
Thanks Wanlong !
I think History part in runltp script needs to be updated to reflect the changes.

Patches are welcome! ;)

Thanks,
Wanlong Gao

Quoted 6 lines

Regards,
Ramesh

[email protected]

2013-04-22 10:01 UTC #8 lore raw

In reply to Ramesh

Hi!

Quoted 2 lines

I think History part in runltp script needs to be updated to reflect the changes.

Since we started to use git and make sure the commit messages describe the change well the "History" stored in the files are not that relevant anymore. If there is history that could not be found by 'git log filename' it is kept. For new changes is updating the "History" is not recomended.

Signature · 13 lines

Cyril Hrubis
[email protected]

------------------------------------------------------------------------------
Precog is a next-generation analytics platform capable of advanced
analytics on semi-structured data. The platform includes APIs for building
apps and a phenomenal toolset for data science. Developers can use
our toolset for easy data analysis & visualization. Get a free account!
http://www2.precog.com/precogplatform/slashdotnewsletter
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list