pinctrl: coh901: add device tree support
Subsystems (3)
PATCH 5/23 pinctrl: coh901: add device tree support
From: Linus Walleij <[email protected]>
This makes it possible to probe the COH901 pinctrl driver from the device tree, and assigned the device tree node in the gpio_chip so we can look up cross-references from the device tree.
Signed-off-by Linus Walleij <[email protected]>
--- .../devicetree/bindings/gpio/gpio-stericsson-coh901.txt | 9 +++++++++ drivers/pinctrl/pinctrl-coh901.c | 9 +++++++++ 2 files changed, 18 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/gpio-stericsson-coh901.txt
Documentation/devicetree/bindings/gpio/gpio-stericsson-coh901.txt new file +9 -0
@@ -0,0 +1,9 @@ +ST-Ericsson COH 901 571/3 GPIO controller + +Required properties: +- compatible: Compatible property value should be "stericsson,gpio-coh901" +- reg: Physical base address of the controller and length of memory mapped + region. +- interrupts: the 0...n interrupts assigned to the different GPIO ports/banks. +- interrupt-names: name the interrupts after port/bank, "gpio0", "gpio1" etc. +
drivers/pinctrl/pinctrl-coh901.c +9 -0
@@ -808,6 +808,9 @@ static int __init u300_gpio_probe(struct platform_device *pdev) }dev_dbg (gpio->dev,"initialized %d GPIO ports\n" , portno); +#ifdef CONFIG_OF_GPIO + gpio->chip.of_node = pdev->dev.of_node; +#endif err =gpiochip_add (&gpio->chip);if (err) {dev_err (gpio->dev,"unable to add gpiochip: %d\n" , err);
@@ -861,9 +864,15 @@ static int __exit u300_gpio_remove(struct platform_device *pdev)return 0 ; } +static const struct of_device_id u300_gpio_match[] = { + { .compatible ="stericsson,gpio-coh901" }, + {}, +}; +static struct platform_driver u300_gpio_driver = { .driver = { .name ="u300-gpio" , + .of_match_table = u300_gpio_match, }, .remove =__exit_p (u300_gpio_remove), };
Signature · 1 line
1.7.11.3
PATCH 5/23 pinctrl: coh901: add device tree support
Documentation/devicetree/bindings/gpio/gpio-stericsson-coh901.txt line 9
Quoted 7 lines · Linus Walleij
Documentation/devicetree/bindings/gpio/gpio-stericsson-coh901.txt new file +7
-0+Required properties: +- compatible: Compatible property value should be "stericsson,gpio-coh901" +- reg: Physical base address of the controller and length of memory mapped + region. +- interrupts: the 0...n interrupts assigned to the different GPIO ports/banks. +- interrupt-names: name the interrupts after port/bank, "gpio0", "gpio1" etc. +
I think it would be better to leave out the interrupt-names in this case, since the name directly corresponds to the index, so there is no ambiguity.
Arnd